From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50566) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHEvf-00084b-Uv for qemu-devel@nongnu.org; Mon, 20 Jul 2015 13:32:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZHEvc-0003ls-Nf for qemu-devel@nongnu.org; Mon, 20 Jul 2015 13:32:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40545) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHEvc-0003lo-Hu for qemu-devel@nongnu.org; Mon, 20 Jul 2015 13:32:36 -0400 References: <1435782155-31412-1-git-send-email-armbru@redhat.com> <1435782155-31412-4-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <55AD30AF.5070008@redhat.com> Date: Mon, 20 Jul 2015 11:32:31 -0600 MIME-Version: 1.0 In-Reply-To: <1435782155-31412-4-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MOqaHfLKd5hErRtJpEJ2wouA5GpGMA6kh" Subject: Re: [Qemu-devel] [PATCH RFC v2 03/47] qapi: Simplify guardname() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, berto@igalia.com, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --MOqaHfLKd5hErRtJpEJ2wouA5GpGMA6kh Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/01/2015 02:21 PM, Markus Armbruster wrote: > The guards around built-in declarations lose their _H. It never made > much sense anyway. Correct - the _H tail on the guard for the overall file makes sense (when the overall file ends in .h), but for an unrelated use in the middle of the file, it has no bearing on any file name and does not need a _H tail. >=20 > Signed-off-by: Markus Armbruster > --- > scripts/qapi.py | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) Reviewed-by: Eric Blake For an example of what it changes, qapi-types.h sees changes like this (while the original #ifndef QAPI_TYPES_H guard at the front of the file remains unchanged, which is good): --- qapi-types.h.old 2015-07-20 10:40:19.513650697 -0600 +++ qapi-types.h 2015-07-20 11:27:15.481152848 -0600 @@ -20,8 +20,8 @@ #include -#ifndef QAPI_TYPES_BUILTIN_STRUCT_DECL_H -#define QAPI_TYPES_BUILTIN_STRUCT_DECL_H +#ifndef QAPI_TYPES_BUILTIN_STRUCT_DECL +#define QAPI_TYPES_BUILTIN_STRUCT_DECL typedef struct int32List @@ -141,7 +141,7 @@ struct uint32List *next; } uint32List; -#endif /* QAPI_TYPES_BUILTIN_STRUCT_DECL_H */ +#endif /* QAPI_TYPES_BUILTIN_STRUCT_DECL */ extern const char * const ErrorClass_lookup[]; =2E.. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --MOqaHfLKd5hErRtJpEJ2wouA5GpGMA6kh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVrTCvAAoJEKeha0olJ0NqhbUH/1O6sBhBinL/cR4JX8uyxpDh iANMqITMCvnVIGPjnglARLJYuIeUjkpSXmpM6JnbY8nyPQk56cAvoCN3avnhMWYI ZaiMDEBEax1XR7Sva6Ig1STww6Wi5Q62Ai53RKzvlgnbHx79zkODtrB9XHFT41gU A+HJpAtGqwrL6uwAmq3U52lCR5TgNz0pQYsiq0rYhlqtCiYlutJfiMG5iEXcs623 kQK6NNfhV2w+/z4c0Ei8a+XlNgyoqH7gpIYf5plxygtpW6Lw8ujj1PVCxqajfwQD sWQCkL3SHSa3q6i3jEsxJXqT+8aDcUWFpxQ4bKQdN7ac8KnQTV96UAAahTGKpXM= =/g5z -----END PGP SIGNATURE----- --MOqaHfLKd5hErRtJpEJ2wouA5GpGMA6kh--