From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59475) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHNGj-0007jX-El for qemu-devel@nongnu.org; Mon, 20 Jul 2015 22:26:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZHNGe-0002wO-P0 for qemu-devel@nongnu.org; Mon, 20 Jul 2015 22:26:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55362) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHNGe-0002wJ-JG for qemu-devel@nongnu.org; Mon, 20 Jul 2015 22:26:52 -0400 References: <1435782155-31412-1-git-send-email-armbru@redhat.com> <1435782155-31412-11-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <55ADADDC.4010708@redhat.com> Date: Mon, 20 Jul 2015 20:26:36 -0600 MIME-Version: 1.0 In-Reply-To: <1435782155-31412-11-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8ur8Mlvjqk2KP5Qr1628FVGjIjQvxQ04m" Subject: Re: [Qemu-devel] [PATCH RFC v2 10/47] qapi-visit: Fix two name arguments passed to visitors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, berto@igalia.com, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8ur8Mlvjqk2KP5Qr1628FVGjIjQvxQ04m Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/01/2015 02:21 PM, Markus Armbruster wrote: > The generated code passes mangled schema names to visit_type_enum() > and union's visit_start_struct(). Fix it to pass the names > unadulterated, like we do everywhere else. >=20 > Only qapi-schema-test.json actually has names where this makes a > difference: enum __org.qemu_x-Enum, flat union __org.qemu_x-Union2, > simple union __org.qemu_x-Union1 and its implicit enum > __org.qemu_x-Union1Kind. I'm glad I added that test - it covers things that will affect downstream extensions, but which don't affect mainline. >=20 > Signed-off-by: Markus Armbruster > --- > scripts/qapi-visit.py | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --8ur8Mlvjqk2KP5Qr1628FVGjIjQvxQ04m Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVra3cAAoJEKeha0olJ0NqwtYH/1si4nEAPhiHqBJ8/C+AFt0E 9cC6IBBF9mhxOX8r2YmkDSNAMzBoIHUy8eaN4CK9fE4Tg8EtoPFVf4cu8GSnZw7X ZltwdY/iEZy7BoaCuEwv7J6Np/MH9+4xz2daulqecF68cHOJQaJJMk4uKvNTPEgJ jZkiUCeTw8RrHNjjEEO1PpILa0H7+Wfs1JnA6ojsk44L6yr4EQJbdxd8ufpdJoJD z7/yj/6SSYjScD/3McZ3rLaAMMtBMCM1g36EFaPpDrfLlBZxqNAOqSaRQpmQkRnL fa+u8DgiAZe6qgtjxg1c1+aQgCmU7uKdhQYQN2M5MPygoE9+xAsVk05MqKC2pn0= =2Pr2 -----END PGP SIGNATURE----- --8ur8Mlvjqk2KP5Qr1628FVGjIjQvxQ04m--