From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZI4Cp-0008Jr-DN for qemu-devel@nongnu.org; Wed, 22 Jul 2015 20:17:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZI4Ck-0003RS-LX for qemu-devel@nongnu.org; Wed, 22 Jul 2015 20:17:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34197) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZI3qA-0001MR-JQ for qemu-devel@nongnu.org; Wed, 22 Jul 2015 19:54:22 -0400 References: <1435782155-31412-1-git-send-email-armbru@redhat.com> <1435782155-31412-29-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <55B021D5.5070602@redhat.com> Date: Wed, 22 Jul 2015 17:05:57 -0600 MIME-Version: 1.0 In-Reply-To: <1435782155-31412-29-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UOSVt6t9B4ckwtFmkqU1xV7fnpIMmjGd4" Subject: Re: [Qemu-devel] [PATCH RFC v2 28/47] qapi-commands: Convert to QAPISchemaVisitor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, berto@igalia.com, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UOSVt6t9B4ckwtFmkqU1xV7fnpIMmjGd4 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/01/2015 02:22 PM, Markus Armbruster wrote: > Output unchanged except for white-space. Indeed, and the diffstat shows it was only one blank line: qga-qmp-marshal.c | 1 + 1 file changed, 1 insertion(+) MUCH friendlier to review :) >=20 > Signed-off-by: Markus Armbruster > --- > scripts/qapi-commands.py | 157 ++++++++++++++++++++++++++-------------= -------- > scripts/qapi.py | 2 +- > 2 files changed, 87 insertions(+), 72 deletions(-) >=20 Here, I can confidently say: Reviewed-by: Eric Blake > +++ b/scripts/qapi.py > @@ -1366,7 +1366,7 @@ def c_type(value, is_param=3DFalse): > return c_name(value) + pointer_suffix > =20 > def is_c_ptr(value): > - return c_type(value).endswith(pointer_suffix) > + return value.endswith(pointer_suffix) Perhaps this cleanup could be floated earlier in the series? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --UOSVt6t9B4ckwtFmkqU1xV7fnpIMmjGd4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVsCHVAAoJEKeha0olJ0NqN7gH/iXAm0VNb24Ax+S3Wxlr1ApR qcc94mwRsn4pWXCnuZo71gUs16ERWmr5Dm9ToU6ZJ7ekCcyQxK46pNGVKxqRBBST m2VPuwXzL88yjjz+KLcX8O4rvUbSZJRJNj8XG9VIax+RSdNY5OvInfwSSJGXT5Qx pNjswSgpcMbu85Ox7QTViF6ONg3+sFlf8xdlm0TZnj3e1E1T/WcJ2IGou+UScaZx z34yiNSiDjg4URzTrVPrioDPEUe5/Pj6Jdbt7b3S1hYTMIKrtzb9eh2RYmWhrBWt XJqv83rGQgr3RjimzNJkrDTfcCfo1flnc86RhzwaoUmN3/xeR3Z2Cnjr0vB1Zbc= =0vvk -----END PGP SIGNATURE----- --UOSVt6t9B4ckwtFmkqU1xV7fnpIMmjGd4--