From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37699) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZILq3-0005Uj-8t for qemu-devel@nongnu.org; Thu, 23 Jul 2015 15:07:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZILpz-0005TE-6A for qemu-devel@nongnu.org; Thu, 23 Jul 2015 15:07:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59010) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZILpz-0005Sy-20 for qemu-devel@nongnu.org; Thu, 23 Jul 2015 15:07:23 -0400 References: <1435782155-31412-1-git-send-email-armbru@redhat.com> <1435782155-31412-37-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <55B13B65.6030100@redhat.com> Date: Thu, 23 Jul 2015 13:07:17 -0600 MIME-Version: 1.0 In-Reply-To: <1435782155-31412-37-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sgFHAOiWjCWCLdw9OtEvgqkS4Ab0vTIOq" Subject: Re: [Qemu-devel] [PATCH RFC v2 36/47] qapi: Rename qmp_marshal_input_FOO() to qmp_marshal_FOO() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, berto@igalia.com, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --sgFHAOiWjCWCLdw9OtEvgqkS4Ab0vTIOq Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/01/2015 02:22 PM, Markus Armbruster wrote: > These functions marshal both input and output. >=20 > Signed-off-by: Markus Armbruster > --- > docs/qapi-code-gen.txt | 4 +- > docs/writing-qmp-commands.txt | 8 +- > monitor.c | 2 +- > qmp-commands.hx | 240 +++++++++++++++++++++-------------= -------- > scripts/qapi-commands.py | 4 +- > 5 files changed, 129 insertions(+), 129 deletions(-) Diffstat here says it is a straight rename; likewise the diff on the generated code: qga/qapi-generated/qga-qmp-marshal.c | 116 ++++++++-------- qmp-commands.h | 240 +++++++++++++++++------------------ qmp-marshal.c | 240 +++++++++++++++++------------------ 3 files changed, 298 insertions(+), 298 deletions(-) Missing: you overlooked a comment in qmp.c line 154: #ifndef CONFIG_SPICE /* * qmp-commands.hx ensures that QMP command query-spice exists only * #ifdef CONFIG_SPICE. Necessary for an accurate query-commands * result. However, the QAPI schema is blissfully unaware of that, * and the QAPI code generator happily generates a dead * qmp_marshal_input_query_spice() that calls qmp_query_spice(). * Provide it one, or else linking fails. * FIXME Educate the QAPI schema on CONFIG_SPICE. */ With that fixed, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --sgFHAOiWjCWCLdw9OtEvgqkS4Ab0vTIOq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVsTtlAAoJEKeha0olJ0NqmSsIAIhKx5SaSREJGtAO/ku1tAxV tRf9bEzyY/zq87JXXrlopvkWn6E3lcG1lRrRmxgrwzTkAfLe9Phf6UALp8HdbtBc Ew/7zeshy/XMdNWrYXiucobFfFT+VXIjL0ESxTK1B7uX/ZeBTVKErPJ4S2vQduwI dKLyfu5RdrT2J0sZnQTdD0I7zkOug6cwDaUfrxeBbrh6TgW7gg6st253/a55hWRs TFcMTPq3HpeM4xkitADqf0gLodlJBD8LK/QBGoDPkxLJP+iKBVzeCXqSOa9ZzOuE 8CQSZY3zkREJmHpEKpEgDuCRUWxHdgJjTRbjcjTMsoMS7HovEYFxooLQv6Gak1o= =3Zjl -----END PGP SIGNATURE----- --sgFHAOiWjCWCLdw9OtEvgqkS4Ab0vTIOq--