All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Ceresoli <luca@lucaceresoli.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v7 1/1] rtl8821au: new package
Date: Sat, 25 Jul 2015 15:22:08 +0200	[thread overview]
Message-ID: <55B38D80.9070605@lucaceresoli.net> (raw)
In-Reply-To: <20150725101601.GB3662@free.fr>

Dear Yann,

Yann E. MORIN wrote:
> Christian, Luca, All,
>
> Luca, a licensing question for you... ;-)
>
> On 2015-07-24 15:32 -0700, Christian Stewart spake thusly:
>> This patch adds the rtl8821au wifi driver. The driver is sourced from
>> ulli-kroll's work on GitHub, which includes various fixes and better LED
>> handling. Currently USB3 support is broken in this driver - it will
>> only connect to the EHCI controller in a USB3 port.
>>
>> Signed-off-by: Christian Stewart <christian@paral.in>
> [--SNIP--]
[...]
>> --- /dev/null
>> +++ b/package/rtl8821au/rtl8821au.mk
>> @@ -0,0 +1,21 @@
>> +################################################################################
>> +#
>> +# rtl8821au
>> +#
>> +################################################################################
>> +
>> +RTL8821AU_VERSION = f58e4a7fb27551bdbb4aee9db6086dd6ad996c8d
>> +RTL8821AU_SITE = $(call github,ulli-kroll,rtl8821au,$(RTL8821AU_VERSION))
>> +RTL8821AU_CFLAGS_ENDIAN = -DCONFIG_$(call qstrip,$(BR2_ENDIAN))_ENDIAN
>
> You forgot the licensing information:
>
>      RTL8821AU_LICENSE = GPLv2
>      RTL8821AU_LICENSE_FILES = COPYING
>
> Luca:
>
> Also, two firmware blobs are installed, and we have no licensing info
> for those two; usually it's a proprietary license.
>
> I wonder if/how we can reflect this in the licensing info above.

I can't think of any option other than:

   RTL8821AU_LICENSE = GPLv2, proprietary (firmware blobs)

-- 
Luca

  reply	other threads:[~2015-07-25 13:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-24 22:32 [Buildroot] [PATCH v7 1/1] rtl8821au: new package Christian Stewart
2015-07-25 10:01 ` Yann E. MORIN
2015-07-25 10:16 ` Yann E. MORIN
2015-07-25 13:22   ` Luca Ceresoli [this message]
2015-07-25 14:32     ` Yann E. MORIN
2015-07-25 15:57       ` Luca Ceresoli
2015-07-25 16:29 ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55B38D80.9070605@lucaceresoli.net \
    --to=luca@lucaceresoli.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.