From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Wise Subject: Re: [PATCH V6 6/9] isert: Rename IO functions to more descriptive names Date: Sun, 26 Jul 2015 15:17:19 -0500 Message-ID: <55B5404F.5040404@opengridcomputing.com> References: <20150724161331.25617.8475.stgit@build2.ogc.int> <20150724161848.25617.26092.stgit@build2.ogc.int> <55B4B190.7070305@dev.mellanox.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <55B4B190.7070305-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sagi Grimberg , dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org Cc: infinipath-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, roid-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org List-Id: linux-rdma@vger.kernel.org On 7/26/2015 5:08 AM, Sagi Grimberg wrote: > On 7/24/2015 7:18 PM, Steve Wise wrote: >> This is in preparation for adding new FRMR-only IO handlers >> for devices that support FRMR and not PI. > > Steve, > > I've given this some thought and I think we should avoid splitting > logic from PI and iWARP. The reason (other than code duplication) is > that currently the iser target support only up to 1MB IOs. I have some > code (not done yet) to support larger IOs by using multiple > registrations per IO (with or without PI). > With a little tweaking I think we can get iwarp to fit in too... > > So, do you mind if I take a crack at it? Sure, go ahead. Let me know how I can help. Certainly I can test it for you. I'm very keen to get this in for 4.3 if possible... -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from linode.aoot.com ([69.164.194.13]:46259 "EHLO linode.aoot.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754550AbbGZURW (ORCPT ); Sun, 26 Jul 2015 16:17:22 -0400 Subject: Re: [PATCH V6 6/9] isert: Rename IO functions to more descriptive names To: Sagi Grimberg , dledford@redhat.com References: <20150724161331.25617.8475.stgit@build2.ogc.int> <20150724161848.25617.26092.stgit@build2.ogc.int> <55B4B190.7070305@dev.mellanox.co.il> Cc: infinipath@intel.com, sagig@mellanox.com, ogerlitz@mellanox.com, roid@mellanox.com, linux-rdma@vger.kernel.org, eli@mellanox.com, target-devel@vger.kernel.org, linux-nfs@vger.kernel.org, bfields@fieldses.org From: Steve Wise Message-ID: <55B5404F.5040404@opengridcomputing.com> Date: Sun, 26 Jul 2015 15:17:19 -0500 MIME-Version: 1.0 In-Reply-To: <55B4B190.7070305@dev.mellanox.co.il> Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-nfs-owner@vger.kernel.org List-ID: On 7/26/2015 5:08 AM, Sagi Grimberg wrote: > On 7/24/2015 7:18 PM, Steve Wise wrote: >> This is in preparation for adding new FRMR-only IO handlers >> for devices that support FRMR and not PI. > > Steve, > > I've given this some thought and I think we should avoid splitting > logic from PI and iWARP. The reason (other than code duplication) is > that currently the iser target support only up to 1MB IOs. I have some > code (not done yet) to support larger IOs by using multiple > registrations per IO (with or without PI). > With a little tweaking I think we can get iwarp to fit in too... > > So, do you mind if I take a crack at it? Sure, go ahead. Let me know how I can help. Certainly I can test it for you. I'm very keen to get this in for 4.3 if possible...