From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54927) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJlDA-0007cF-LR for qemu-devel@nongnu.org; Mon, 27 Jul 2015 12:25:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZJlD4-0006L6-8Z for qemu-devel@nongnu.org; Mon, 27 Jul 2015 12:25:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51486) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJlD4-0006HR-05 for qemu-devel@nongnu.org; Mon, 27 Jul 2015 12:25:02 -0400 References: <1435782155-31412-1-git-send-email-armbru@redhat.com> <1435782155-31412-27-git-send-email-armbru@redhat.com> <55B00970.2060206@redhat.com> <87mvyhwpjb.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <55B65B5C.6060600@redhat.com> Date: Mon, 27 Jul 2015 10:25:00 -0600 MIME-Version: 1.0 In-Reply-To: <87mvyhwpjb.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="IjelF0Qqr7P0MLTspOj6pT3od4Ih1oVED" Subject: Re: [Qemu-devel] [PATCH RFC v2 26/47] qapi-types: Convert to QAPISchemaVisitor, fixing flat unions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, berto@igalia.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --IjelF0Qqr7P0MLTspOj6pT3od4Ih1oVED Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/27/2015 10:09 AM, Markus Armbruster wrote: >=20 >> I'm sure there are further things that could be done, but at this poin= t, >> I hope you get my picture, and I'll quit focusing on this particular p= atch. >=20 > We need to decide how much code churn to accept just for making the dif= f > of the generated code easier to review. At this point, I'd be happy with just adding a script or other high-level instructions in the commit message that says how to divide a generated file into pieces (pull out all *List types into one piece, all typedefs into another, etc) and which can be done both pre- and post-patch. With pieces in hand, if you can easily compare that each pair is minimally different, then you have a nice reassurance that the difference in the overall file is due merely to differences in how the pieces are interleaved, and not to added or unintentionally dropped material. As you pointed out, there comes a point of diminishing returns in trying to clean up code that will just be discarded. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --IjelF0Qqr7P0MLTspOj6pT3od4Ih1oVED Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVtltcAAoJEKeha0olJ0NqyYgH/jUXpfCKY71pO/SHocEuqOXc +9FtW7o24L/k3qlyzyIbnfkOwxhklPAzpIruuhZkp5Q1BCPv08wLODTiBU4I8BRy 3W30nfcLBkMTaqMTkLt4UyNmTW6CPveB6cXC+GB2v6qVYOxVRDu9E2aELG76arP1 PWVTJXExR+3ynRDx3kJVS8pCw11MBmMQCHxIIFyqEaWPrHWKxuRq1AVEpplbjBOc AlpIuh4s3SKK6qZ+wtYM66e/1XzpUXDNYRHhGBiQ2la6me3BzLcqdBchYZ3aFrfJ tl+s8WLYMUxGmJJzzr1wYiPXIJ4rFIsFvcNvdPXAUI6l/zndX3WidPi/dGqhurE= =xsKV -----END PGP SIGNATURE----- --IjelF0Qqr7P0MLTspOj6pT3od4Ih1oVED--