From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55831) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKCYi-0000dn-0G for qemu-devel@nongnu.org; Tue, 28 Jul 2015 17:37:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZKCYd-0005JH-2F for qemu-devel@nongnu.org; Tue, 28 Jul 2015 17:37:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51949) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKCYc-0005IO-T0 for qemu-devel@nongnu.org; Tue, 28 Jul 2015 17:37:06 -0400 References: <1435782155-31412-1-git-send-email-armbru@redhat.com> <1435782155-31412-34-git-send-email-armbru@redhat.com> <55B11AF1.3000509@redhat.com> <87h9ooy71o.fsf@blackfin.pond.sub.org> <55B7F072.8000706@redhat.com> From: Eric Blake Message-ID: <55B7F600.2060701@redhat.com> Date: Tue, 28 Jul 2015 15:37:04 -0600 MIME-Version: 1.0 In-Reply-To: <55B7F072.8000706@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4CrEx6q0ak7DwNqiDptGDfSG4WC812hJI" Subject: Re: [Qemu-devel] [PATCH RFC v2 33/47] qapi: Clean up after recent conversions to QAPISchemaVisitor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, berto@igalia.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4CrEx6q0ak7DwNqiDptGDfSG4WC812hJI Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/28/2015 03:13 PM, Eric Blake wrote: >=20 >>>> -def generate_command_decl(name, args, ret_type): >>>> - arglist=3D"" >>>> +def gen_command_decl(name, args, rets): >>> >>> I can see how 'args' is plural (even if it is a single string for the= >>> name of a type containing the args), but should it be 'ret' instead o= f >>> 'rets'? >> >> I'm open to better ideas on terminology. >=20 > Not sure I'm thinking of anything better; so while I found it unusual, > the explanation helps and I certainly won't reject it as wrong. Maybe gen_command_decl(name, arg_type, ret_type) since we've already reduced the set of dictionaries into a single type name (where the type name is possibly implicit)? After all, we're not calling the function with a python list or set, but with a singlar string (where that string is the name of a type, and it is the type that then has multiple members to form plural arguments or plural return values). A bit more typing, though, so up to you. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --4CrEx6q0ak7DwNqiDptGDfSG4WC812hJI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVt/YAAAoJEKeha0olJ0NqhnkH/0RbXIBfzZ6vTKwF4ah3PhYq bukjXt6IzNR/Z3beFnEn1BpaGb4hkN6sVE5dFc6UhayFyAhG7pagch8+2V2uC9CQ bujb/ye1r92HEpFQzSQnzMgP/LRru3TXcvWpTLJ8s+WstqgUgS32GuzZN9wPwYZv iFodeY02IHPIQb5UkuJ3qwE4EInwoG6RBOD2t0h4osCHbiWClzOsxrcWM3pMZDaq dmsIw712FCbpOGYZaOKziLoJ+VYPLIAURnpCneAGAsbLhlyL5RIriVuKVZWkRRR+ EjhBKsH1g4qPsJtcWvzgUgeagNPrtAGkoojLnNUjEo0uS1fRh/tjhE+T568qJJs= =nGfE -----END PGP SIGNATURE----- --4CrEx6q0ak7DwNqiDptGDfSG4WC812hJI--