From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43408)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1ZKMGM-0000uv-2o
	for qemu-devel@nongnu.org; Wed, 29 Jul 2015 03:58:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1ZKMGI-0002Vb-6B
	for qemu-devel@nongnu.org; Wed, 29 Jul 2015 03:58:54 -0400
Received: from david.siemens.de ([192.35.17.14]:53429)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1ZKMGH-0002GI-Td
	for qemu-devel@nongnu.org; Wed, 29 Jul 2015 03:58:50 -0400
References: <20150728225701.GK3467@type.home> <55B8831A.6090707@siemens.com>
	<20150729074710.GZ3467@type.home>
From: Jan Kiszka <jan.kiszka@siemens.com>
Message-ID: <55B887AC.9020109@siemens.com>
Date: Wed, 29 Jul 2015 09:58:36 +0200
MIME-Version: 1.0
In-Reply-To: <20150729074710.GZ3467@type.home>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCHv4 00/18] slirp: Adding IPv6 support to Qemu
	-net user mode
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Samuel Thibault <samuel.thibault@gnu.org>
Cc: zhanghailiang <zhang.zhanghailiang@huawei.com>, Li Zhijian <lizhijian@cn.fujitsu.com>, Stefan Hajnoczi <stefanha@gmail.com>, Jason Wang <jasowang@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Vasiliy Tolstov <v.tolstov@selfip.ru>, peter.huangpeng@huawei.com, "Gonglei (Arei)" <arei.gonglei@huawei.com>, Stefan Hajnoczi <stefanha@redhat.com>, Yang Hongyang <yanghy@cn.fujitsu.com>, Dave Gilbert <dgilbert@redhat.com>

On 2015-07-29 09:47, Samuel Thibault wrote:
> Jan Kiszka, le Wed 29 Jul 2015 09:39:06 +0200, a =E9crit :
>> Make sure to add the proper From: of the actual author.
>=20
> Ok. Two of the patches are however from a different author, I haven't
> found how to specify different From addresses with git send-email.

This knowledge is buried in scripts here, but IIRC it should suffice
having recorded authorship correctly in git.

>=20
>> Also, some are signed-off by you, others not. As a maintainer, you
>> should sign all of them. Or is there a particular reason (not yet
>> reviewed etc.)?
>=20
> The reason was just that I hadn't touched those patches at all, but I
> reviewed them all.

If you touch a patch and it's just trivial, add a simple changelog like

Signed-off-by: Author ....
[Samuel: fix minor style issue etc.]
Signed-off-by: You

If you change the patch significantly, rather remove the authors
signed-off and ask to provide it again for the modified version.

Jan

--=20
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux