From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH v2] acpi: Use kstrtoul() instead of strtoul()/simple_strtoul() Date: Wed, 29 Jul 2015 12:58:06 -0700 Message-ID: <55B9304E.6020408@roeck-us.net> References: <1438043542-2960-1-git-send-email-linux@roeck-us.net> <94F2FBAB4432B54E8AACC7DFDE6C92E37D329493@ORSMSX112.amr.corp.intel.com> <55B91DAF.3060605@roeck-us.net> <94F2FBAB4432B54E8AACC7DFDE6C92E37D3294E8@ORSMSX112.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from bh-25.webhostbox.net ([208.91.199.152]:56440 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752406AbbG2T6J (ORCPT ); Wed, 29 Jul 2015 15:58:09 -0400 In-Reply-To: <94F2FBAB4432B54E8AACC7DFDE6C92E37D3294E8@ORSMSX112.amr.corp.intel.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Moore, Robert" , "rjw@rjwysocki.net" Cc: "lenb@kernel.org" , "Zheng, Lv" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devel@acpica.org" On 07/29/2015 12:33 PM, Moore, Robert wrote: >> -----Original Message----- >> From: Guenter Roeck [mailto:linux@roeck-us.net] >> Sent: Wednesday, July 29, 2015 11:39 AM >> To: Moore, Robert; rjw@rjwysocki.net >> Cc: lenb@kernel.org; Zheng, Lv; linux-acpi@vger.kernel.org; linux- >> kernel@vger.kernel.org; devel@acpica.org >> Subject: Re: [PATCH v2] acpi: Use kstrtoul() instead of >> strtoul()/simple_strtoul() >> >> On 07/29/2015 10:51 AM, Moore, Robert wrote: >>> >>> >>>> -----Original Message----- >>>> From: Guenter Roeck [mailto:linux@roeck-us.net] >>>> Sent: Monday, July 27, 2015 5:32 PM >>>> To: rjw@rjwysocki.net >>>> Cc: lenb@kernel.org; Moore, Robert; Zheng, Lv; >>>> linux-acpi@vger.kernel.org; linux-kernel@vger.kernel.org; >>>> devel@acpica.org; Guenter Roeck >>>> Subject: [PATCH v2] acpi: Use kstrtoul() instead of >>>> strtoul()/simple_strtoul() >>>> >>>> simple_strtoul() is deprecated; replace with kstrtoul() and >> kstrtouint(). >>> >>> The ACPICA code is os-independent and cannot use these functions (at >> least not directly). >>> >>> >> Odd argument, given that kstrtoul() is used already in the acpi code. > > They are not in the os-independent ACPICA code. The ACPI-related drivers are another story, since they are OS-dendent. > That this OS independent code mandates functions such as strtoul(), which may not exist in a target OS, and that it maps strtoul() to simple_strtoul() in a global include file, doesn't seem to be correct either and is asking for repeated trouble. I would have hoped that at the very least such mappings would be implemented in local include files. On the other side, my patch to remove the second global definition of strtoul has been accepted, so the problem I was trying to solve has been addressed elsewhere. With that, my patch is no longer needed at this time, at least until someone else redefines strtoul(). Thanks, Guenter