From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43889) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKypV-0003OC-6L for qemu-devel@nongnu.org; Thu, 30 Jul 2015 21:09:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZKypS-0000qF-G9 for qemu-devel@nongnu.org; Thu, 30 Jul 2015 21:09:45 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:31187) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKypR-0000os-Ta for qemu-devel@nongnu.org; Thu, 30 Jul 2015 21:09:42 -0400 Message-ID: <55BACAB9.3040804@huawei.com> Date: Fri, 31 Jul 2015 09:09:13 +0800 From: Ting Wang MIME-Version: 1.0 References: <1435306033-58372-1-git-send-email-kathy.wangting@huawei.com> <20150730120551.49b5d3c6@redhat.com> In-Reply-To: <20150730120551.49b5d3c6@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5] hmp: add info iothreads command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: stefanha@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, wu.wubin@huawei.com, armbru@redhat.com On 2015-7-31 0:05, Luiz Capitulino wrote: > On Fri, 26 Jun 2015 16:07:13 +0800 > Ting Wang wrote: > >> Make "info iothreads" available on the HMP monitor. >> >> For example, the results are as follows when executing qemu >> command with "-object iothread,id=iothread-1 -object >> iothread,id=iothread-2". >> (qemu) info iothreads >> iothread-1: thread_id=123 >> iothread-2: thread_id=456 >> >> Signed-off-by: Ting Wang > Reviewed-by: Luiz Capitulino > > Markus will take this patch via his tree. Thanks. Ting >> --- >> v5: use "for" instead of "while" >> --- >> hmp-commands.hx | 2 ++ >> hmp.c | 13 +++++++++++++ >> hmp.h | 1 + >> monitor.c | 7 +++++++ >> 4 files changed, 23 insertions(+)execute >> >> diff --git a/hmp-commands.hx b/hmp-commands.hx >> index d3b7932..c8c8d79 100644 >> --- a/hmp-commands.hx >> +++ b/hmp-commands.hx >> @@ -1790,6 +1790,8 @@ show roms >> show the TPM device >> @item info memory-devices >> show the memory devices >> +@item info iothreads >> +show iothreads >> @end table >> ETEXI >> >> diff --git a/hmp.c b/hmp.c >> index 070aaf8..7192494 100644 >> --- a/hmp.c >> +++ b/hmp.c >> @@ -1963,6 +1963,19 @@ void hmp_info_memory_devices(Monitor *mon, const QDict *qdict) >> qapi_free_MemoryDeviceInfoList(info_list); >> } >> >> +void hmp_info_iothreads(Monitor *mon, const QDict *qdict) >> +{ >> + IOThreadInfoList *info_list = qmp_query_iothreads(NULL); >> + IOThreadInfoList *info; >> + >> + for (info = info_list; info; info = info->next) { >> + monitor_printf(mon, "%s: thread_id=%" PRId64 "\n", >> + info->value->id, info->value->thread_id); >> + } >> + >> + qapi_free_IOThreadInfoList(info_list); >> +} >> + >> void hmp_qom_list(Monitor *mon, const QDict *qdict) >> { >> const char *path = qdict_get_try_str(qdict, "path"); >> diff --git a/hmp.h b/hmp.h >> index 0cf4f2a..c139a97 100644 >> --- a/hmp.h >> +++ b/hmp.h >> @@ -39,6 +39,7 @@ void hmp_info_balloon(Monitor *mon, const QDict *qdict); >> void hmp_info_pci(Monitor *mon, const QDict *qdict); >> void hmp_info_block_jobs(Monitor *mon, const QDict *qdict); >> void hmp_info_tpm(Monitor *mon, const QDict *qdict); >> +void hmp_info_iothreads(Monitor *mon, const QDict *qdict); >> void hmp_quit(Monitor *mon, const QDict *qdict); >> void hmp_stop(Monitor *mon, const QDict *qdict); >> void hmp_system_reset(Monitor *mon, const QDict *qdict); >> diff --git a/monitor.c b/monitor.c >> index aeea2b5..917e827 100644 >> --- a/monitor.c >> +++ b/monitor.c >> @@ -2850,6 +2850,13 @@ static mon_cmd_t info_cmds[] = { >> .mhandler.cmd = hmp_info_memory_devices, >> }, >> { >> + .name = "iothreads", >> + .args_type = "", >> + .params = "", >> + .help = "show iothreads", >> + .mhandler.cmd = hmp_info_iothreads, >> + }, >> + { >> .name = "rocker", >> .args_type = "name:s", >> .params = "name", > > . >