From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sunil Kamath Subject: Re: [SKL-DMC-BUGFIX 2/5] drm/i915/skl: Making DC6 entry is the last call in suspend flow. Date: Tue, 04 Aug 2015 16:55:59 +0530 Message-ID: <55C0A147.4040605@intel.com> References: <1438619136-18268-1-git-send-email-animesh.manna@intel.com> <1438619136-18268-3-git-send-email-animesh.manna@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 43F856E282 for ; Tue, 4 Aug 2015 04:26:02 -0700 (PDT) In-Reply-To: <1438619136-18268-3-git-send-email-animesh.manna@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Animesh Manna Cc: intel-gfx@lists.freedesktop.org, Rajneesh Bhardwaj , Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org T24gTW9uZGF5IDAzIEF1Z3VzdCAyMDE1IDA5OjU1IFBNLCBBbmltZXNoIE1hbm5hIHdyb3RlOgo+ IE1taW8gcmVnaXN0ZXIgYWNjZXNzIGFmdGVyIGRjNi9kYzUgZW50cnkgaXMgbm90IGFsbG93ZWQg d2hlbgo+IERDNiBwb3dlciBzdGF0ZXMgYXJlIGVuYWJsZWQgYWNjb3JkaW5nIHRvIGJzcGVjIChi c3BlYy1pZCAwNTI3KSwKPiBzbyBlbmFibGluZyBkYzYgYXMgdGhlIGxhc3QgY2FsbCBpbiBzdXNw ZW5kIGZsb3cuCj4KPiB2MTogSW5pdGlhbCB2ZXJzaW9uLgo+Cj4gdjI6IGNvbW1pdCBtZXNzYWdl IHVwZGF0ZWQgYmFzZWQgb24gY29tbWVudCBmcm9tIFZhdGhzYWxhLgo+Cj4gQ2M6IERhbmllbCBW ZXR0ZXIgPGRhbmllbC52ZXR0ZXJAaW50ZWwuY29tPgo+IENjOiBEYW1pZW4gTGVzcGlhdSA8ZGFt aWVuLmxlc3BpYXVAaW50ZWwuY29tPgo+IENjOiBJbXJlIERlYWsgPGltcmUuZGVha0BpbnRlbC5j b20+Cj4gQ2M6IFN1bmlsIEthbWF0aCA8c3VuaWwua2FtYXRoQGludGVsLmNvbT4KPiBTaWduZWQt b2ZmLWJ5OiBBbmltZXNoIE1hbm5hIDxhbmltZXNoLm1hbm5hQGludGVsLmNvbT4KPiBTaWduZWQt b2ZmLWJ5OiBWYXRoc2FsYSBOYWdhcmFqdSA8dmF0aHNhbGEubmFnYXJhanVAaW50ZWwuY29tPgo+ IFNpZ25lZC1vZmYtYnk6IFJham5lZXNoIEJoYXJkd2FqIDxyYWpuZWVzaC5iaGFyZHdhakBpbnRl bC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jICAgICAgICAg fCAxMiArKysrKystLS0tLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oICAg ICAgICB8ICAyICsrCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3BtLmMg fCAzMyArKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgIDMgZmlsZXMgY2hhbmdl ZCwgMTYgaW5zZXJ0aW9ucygrKSwgMzEgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf ZHJ2LmMKPiBpbmRleCAwZDY3NzVhLi5lMWQwMTAyIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZHJ2LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Ry di5jCj4gQEAgLTEwMTcsMTQgKzEwMTcsMTEgQEAgc3RhdGljIGludCBza2xfc3VzcGVuZF9jb21w bGV0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gICB7Cj4gICAJLyogRW5h YmxpbmcgREM2IGlzIG5vdCBhIGhhcmQgcmVxdWlyZW1lbnQgdG8gZW50ZXIgcnVudGltZSBEMyAq Lwo+ICAgCj4gLQkvKgo+IC0JICogVGhpcyBpcyB0byBlbnN1cmUgdGhhdCBDU1IgaXNuJ3QgaWRl bnRpZmllZCBhcyBsb2FkZWQgYmVmb3JlCj4gLQkgKiBDU1ItbG9hZGluZyBwcm9ncmFtIGlzIGNh bGxlZCBkdXJpbmcgcnVudGltZS1yZXN1bWUuCj4gLQkgKi8KPiAtCWludGVsX2Nzcl9sb2FkX3N0 YXR1c19zZXQoZGV2X3ByaXYsIEZXX1VOSU5JVElBTElaRUQpOwo+IC0KPiAgIAlza2xfdW5pbml0 X2NkY2xrKGRldl9wcml2KTsKPiAgIAo+ICsJaWYgKGludGVsX2Nzcl9sb2FkX3N0YXR1c19nZXQo ZGV2X3ByaXYpID09IEZXX0xPQURFRCkKPiArCQlza2xfZW5hYmxlX2RjNihkZXZfcHJpdik7Cj4g Kwo+ICAgCXJldHVybiAwOwo+ICAgfQo+ICAgCj4gQEAgLTEwNzEsNiArMTA2OCw5IEBAIHN0YXRp YyBpbnQgc2tsX3Jlc3VtZV9wcmVwYXJlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp dikKPiAgIHsKPiAgIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gZGV2X3ByaXYtPmRldjsKPiAg IAo+ICsJaWYgKGludGVsX2Nzcl9sb2FkX3N0YXR1c19nZXQoZGV2X3ByaXYpID09IEZXX0xPQURF RCkKPiArCQlza2xfZGlzYWJsZV9kYzYoZGV2X3ByaXYpOwo+ICsKPiAgIAlza2xfaW5pdF9jZGNs ayhkZXZfcHJpdik7Cj4gICAJaW50ZWxfY3NyX2xvYWRfcHJvZ3JhbShkZXYpOwo+ICAgCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiBpbmRleCA0N2NlZjBlLi4wNmYzNDZmIDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiBAQCAtMTExNyw2ICsxMTE3LDggQEAgdm9pZCBieHRfZW5h YmxlX2RjOShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpOwo+ICAgdm9pZCBieHRf ZGlzYWJsZV9kYzkoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KTsKPiAgIHZvaWQg c2tsX2luaXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KTsKPiAgIHZv aWQgc2tsX3VuaW5pdF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpOwo+ ICt2b2lkIHNrbF9lbmFibGVfZGM2KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdik7 Cj4gK3ZvaWQgc2tsX2Rpc2FibGVfZGM2KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp dik7Cj4gICB2b2lkIGludGVsX2RwX2dldF9tX24oc3RydWN0IGludGVsX2NydGMgKmNydGMsCj4g ICAJCSAgICAgIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpwaXBlX2NvbmZpZyk7Cj4gICB2b2lk IGludGVsX2RwX3NldF9tX24oc3RydWN0IGludGVsX2NydGMgKmNydGMsIGVudW0gbGlua19tX25f c2V0IG1fbik7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3J1bnRp bWVfcG0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3J1bnRpbWVfcG0uYwo+IGluZGV4 IDYzOTNiNzYuLmM2NjAyNDUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfcnVudGltZV9wbS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcnVudGlt ZV9wbS5jCj4gQEAgLTUzMiw3ICs1MzIsNyBAQCBzdGF0aWMgdm9pZCBhc3NlcnRfY2FuX2Rpc2Fi bGVfZGM2KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgIAkJIkRDNiBhbHJl YWR5IHByb2dyYW1tZWQgdG8gYmUgZGlzYWJsZWQuXG4iKTsKPiAgIH0KPiAgIAo+IC1zdGF0aWMg dm9pZCBza2xfZW5hYmxlX2RjNihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4g K3ZvaWQgc2tsX2VuYWJsZV9kYzYoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ ICAgewo+ICAgCXVpbnQzMl90IHZhbDsKPiAgIAo+IEBAIC01NDksNyArNTQ5LDcgQEAgc3RhdGlj IHZvaWQgc2tsX2VuYWJsZV9kYzYoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ ICAgCVBPU1RJTkdfUkVBRChEQ19TVEFURV9FTik7Cj4gICB9Cj4gICAKPiAtc3RhdGljIHZvaWQg c2tsX2Rpc2FibGVfZGM2KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiArdm9p ZCBza2xfZGlzYWJsZV9kYzYoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAg ewo+ICAgCXVpbnQzMl90IHZhbDsKPiAgIAo+IEBAIC02MTAsMTAgKzYxMCwxMCBAQCBzdGF0aWMg dm9pZCBza2xfc2V0X3Bvd2VyX3dlbGwoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 LAo+ICAgCQkJCSFJOTE1X1JFQUQoSFNXX1BXUl9XRUxMX0JJT1MpLAo+ICAgCQkJCSJJbnZhbGlk IGZvciBwb3dlciB3ZWxsIHN0YXR1cyB0byBiZSBlbmFibGVkLCB1bmxlc3MgZG9uZSBieSB0aGUg QklPUywgXAo+ICAgCQkJCXdoZW4gcmVxdWVzdCBpcyB0byBkaXNhYmxlIVxuIik7Cj4gLQkJCWlm ICgoR0VOOV9FTkFCTEVfREM1KGRldikgfHwgU0tMX0VOQUJMRV9EQzYoZGV2KSkgJiYKPiAtCQkJ CXBvd2VyX3dlbGwtPmRhdGEgPT0gU0tMX0RJU1BfUFdfMikgewo+ICsJCQlpZiAocG93ZXJfd2Vs bC0+ZGF0YSA9PSBTS0xfRElTUF9QV18yKSB7Cj4gKwkJCQlpZiAoR0VOOV9FTkFCTEVfREM1KGRl dikpCj4gKwkJCQkJZ2VuOV9kaXNhYmxlX2RjNShkZXZfcHJpdik7Cj4gICAJCQkJaWYgKFNLTF9F TkFCTEVfREM2KGRldikpIHsKPiAtCQkJCQlza2xfZGlzYWJsZV9kYzYoZGV2X3ByaXYpOwo+ICAg CQkJCQkvKgo+ICAgCQkJCQkgKiBEREkgYnVmZmVyIHByb2dyYW1taW5nIHVubmVjZXNzYXJ5IGR1 cmluZyBkcml2ZXItbG9hZC9yZXN1bWUKPiAgIAkJCQkJICogYXMgaXQncyBhbHJlYWR5IGRvbmUg ZHVyaW5nIG1vZGVzZXQgaW5pdGlhbGl6YXRpb24gdGhlbi4KPiBAQCAtNjIxLDggKzYyMSw2IEBA IHN0YXRpYyB2b2lkIHNrbF9zZXRfcG93ZXJfd2VsbChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYsCj4gICAJCQkJCSAqLwo+ICAgCQkJCQlpZiAoIWRldl9wcml2LT5wb3dlcl9kb21h aW5zLmluaXRpYWxpemluZykKPiAgIAkJCQkJCWludGVsX3ByZXBhcmVfZGRpKGRldik7Cj4gLQkJ CQl9IGVsc2Ugewo+IC0JCQkJCWdlbjlfZGlzYWJsZV9kYzUoZGV2X3ByaXYpOwo+ICAgCQkJCX0K PiAgIAkJCX0KPiAgIAkJCUk5MTVfV1JJVEUoSFNXX1BXUl9XRUxMX0RSSVZFUiwgdG1wIHwgcmVx X21hc2spOwo+IEBAIC02NDIsMjQgKzY0MCw5IEBAIHN0YXRpYyB2b2lkIHNrbF9zZXRfcG93ZXJf d2VsbChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gICAJCQlQT1NUSU5HX1JF QUQoSFNXX1BXUl9XRUxMX0RSSVZFUik7Cj4gICAJCQlEUk1fREVCVUdfS01TKCJEaXNhYmxpbmcg JXNcbiIsIHBvd2VyX3dlbGwtPm5hbWUpOwo+ICAgCj4gLQkJCWlmICgoR0VOOV9FTkFCTEVfREM1 KGRldikgfHwgU0tMX0VOQUJMRV9EQzYoZGV2KSkgJiYKPiAtCQkJCXBvd2VyX3dlbGwtPmRhdGEg PT0gU0tMX0RJU1BfUFdfMikgewo+IC0JCQkJZW51bSBjc3Jfc3RhdGUgc3RhdGU7Cj4gLQkJCQkv KiBUT0RPOiB3YWl0IGZvciBhIGNvbXBsZXRpb24gZXZlbnQgb3IKPiAtCQkJCSAqIHNpbWlsYXIg aGVyZSBpbnN0ZWFkIG9mIGJ1c3kKPiAtCQkJCSAqIHdhaXRpbmcgdXNpbmcgd2FpdF9mb3IgZnVu Y3Rpb24uCj4gLQkJCQkgKi8KPiAtCQkJCXdhaXRfZm9yKChzdGF0ZSA9IGludGVsX2Nzcl9sb2Fk X3N0YXR1c19nZXQoZGV2X3ByaXYpKSAhPQo+IC0JCQkJCQlGV19VTklOSVRJQUxJWkVELCAxMDAw KTsKPiAtCQkJCWlmIChzdGF0ZSAhPSBGV19MT0FERUQpCj4gLQkJCQkJRFJNX0VSUk9SKCJDU1Ig ZmlybXdhcmUgbm90IHJlYWR5ICglZClcbiIsCj4gLQkJCQkJCQlzdGF0ZSk7Cj4gLQkJCQllbHNl Cj4gLQkJCQkJaWYgKFNLTF9FTkFCTEVfREM2KGRldikpCj4gLQkJCQkJCXNrbF9lbmFibGVfZGM2 KGRldl9wcml2KTsKPiAtCQkJCQllbHNlCj4gLQkJCQkJCWdlbjlfZW5hYmxlX2RjNShkZXZfcHJp dik7Cj4gLQkJCX0KPiArCQkJaWYgKEdFTjlfRU5BQkxFX0RDNShkZXYpICYmCj4gKwkJCQlwb3dl cl93ZWxsLT5kYXRhID09IFNLTF9ESVNQX1BXXzIpCj4gKwkJCQkJZ2VuOV9lbmFibGVfZGM1KGRl dl9wcml2KTsKPiAgIAkJfQo+ICAgCX0KPiAgIApTYW1lIGNvbW1lbnQgYXMgYmVmb3JlOgoKVGhp cyBpcyByZWFsbHkgcmlnaHQgY2hhbmdlLgpXaXRoIHRoaXMgd2Ugd2lsbCBnbyBiYWNrIHRvIG91 ciBvcmlnaW5hbCBkZXNpZ24uCkRlZXBlc3QgcG9zc2libGUgZGlzcGxheSBzdGF0ZSB3aWxsIGJl IHRyaWdnZXJlZCBieSByZXNwZWN0aXZlIHN1c3BlbmQgCmNvbXBsZXRlLgpmb3IgZXhhbXBsZSBp biBCWFQgd2UgdHJpZ2dlciBEQzkgZnJvbSBieHRfc3VzcGVuZF9jb21wbGV0ZSBhbmQgd29ya3Mg CmZpbmUgd2l0aCBycG0gaW50ZWdyYXRlZC4KU2FtZSBjYXNlIGhlcmUgZm9yIFNLTCBmb3IgREM2 IHdoaWNoIHVzZXMgRE1DLgoKUmlnaHQgYnVnIGZpeC4KClJldmlld2VkLWJ5OiBBLlN1bmlsIEth bWF0aCA8c3VuaWwua2FtYXRoQGludGVsLmNvbT4KX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZngK