From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755563AbbHFO3q (ORCPT ); Thu, 6 Aug 2015 10:29:46 -0400 Received: from regular1.263xmail.com ([211.150.99.140]:41972 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753533AbbHFO3o (ORCPT ); Thu, 6 Aug 2015 10:29:44 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: <02b9457648b5eb6e124acb44b934f7aa> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [RFC PATCH 2/8] drm: exynos/dp: convert to drm bridge mode To: Jingoo Han , "'Heiko Stuebner'" , "'Russell King'" , "'Fabio Estevam'" , "'Inki Dae'" References: <1438868947-22132-1-git-send-email-ykk@rock-chips.com> <1438870041-23130-1-git-send-email-ykk@rock-chips.com> <000001d0d052$f44fa3a0$dceeeae0$@com> Cc: djkurtz@google.com, dianders@google.com, "'Takashi Iwai'" , "'Andrzej Hajda'" , "'Thierry Reding'" , "'Philipp Zabel'" , "'David Airlie'" , "'Gustavo Padovan'" , "'Seung-Woo Kim'" , "'Kyungmin Park'" , "'Krzysztof Kozlowski'" , "'Kukjin Kim'" , "'Ajay Kumar'" , "'Joonyoung Shim'" , "'Vincent Palatin'" , "'Mark Yao'" , "'Andy Yan'" , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org From: Yakir Yang Message-ID: <55C36F49.6020207@rock-chips.com> Date: Thu, 6 Aug 2015 22:29:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <000001d0d052$f44fa3a0$dceeeae0$@com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jingoo, 在 2015/8/6 22:19, Jingoo Han 写道: > On Thursday, August 06, 2015 11:07 PM, Yakir Yang wrote: >> In order to move exynos dp code to bridge directory, >> we need to convert driver drm bridge mode first. As >> dp driver already have a ptn3460 bridge, so we need >> to move ptn bridge to the next bridge of dp bridge. >> >> Signed-off-by: Yakir Yang >> --- >> drivers/gpu/drm/exynos/exynos_dp_core.c | 196 ++++++++++++++++++++------------ >> drivers/gpu/drm/exynos/exynos_dp_core.h | 2 + >> 2 files changed, 126 insertions(+), 72 deletions(-) >> >> diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/exynos/exynos_dp_core.c >> index a8097a4..aa99e23 100644 >> --- a/drivers/gpu/drm/exynos/exynos_dp_core.c >> +++ b/drivers/gpu/drm/exynos/exynos_dp_core.c >> @@ -3,6 +3,7 @@ >> * >> * Copyright (C) 2012 Samsung Electronics Co., Ltd. >> * Author: Jingoo Han >> + * Yakir Yang > Please don't add this. > You just fixed some parts of this code. I don't find the reason > why you have to be added to author for this file. > If you want the title for an author, please send the patch > for a new IP, instead of modifying the exiting codes. Okay, thanks for your remind ;) >> [...] >> MODULE_AUTHOR("Jingoo Han "); >> +MODULE_AUTHOR("Yakir Yang "); > The same as above. Done >> MODULE_DESCRIPTION("Samsung SoC DP Driver"); >> MODULE_LICENSE("GPL v2"); >> diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.h b/drivers/gpu/drm/exynos/exynos_dp_core.h >> index c321ad5..f2584b8 100644 >> --- a/drivers/gpu/drm/exynos/exynos_dp_core.h >> +++ b/drivers/gpu/drm/exynos/exynos_dp_core.h >> @@ -3,6 +3,7 @@ >> * >> * Copyright (C) 2012 Samsung Electronics Co., Ltd. >> * Author: Jingoo Han >> + * Yakir Yang > The same as above. > Here, you just added 1 line. If we add someone to author > in this way, a lot of people should be added to author. Done - Yakir > Best regards, > Jingoo Han > > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yakir Yang Subject: Re: [RFC PATCH 2/8] drm: exynos/dp: convert to drm bridge mode Date: Thu, 6 Aug 2015 22:29:29 +0800 Message-ID: <55C36F49.6020207@rock-chips.com> References: <1438868947-22132-1-git-send-email-ykk@rock-chips.com> <1438870041-23130-1-git-send-email-ykk@rock-chips.com> <000001d0d052$f44fa3a0$dceeeae0$@com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <000001d0d052$f44fa3a0$dceeeae0$@com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jingoo Han , 'Heiko Stuebner' , 'Russell King' , 'Fabio Estevam' , 'Inki Dae' Cc: 'Krzysztof Kozlowski' , dri-devel@lists.freedesktop.org, 'Andrzej Hajda' , 'Gustavo Padovan' , 'Ajay Kumar' , linux-samsung-soc@vger.kernel.org, 'Vincent Palatin' , linux-rockchip@lists.infradead.org, 'Kukjin Kim' , 'Thierry Reding' , dianders@google.com, linux-arm-kernel@lists.infradead.org, 'Seung-Woo Kim' , linux-kernel@vger.kernel.org, 'Kyungmin Park' , djkurtz@google.com, 'Andy Yan' List-Id: linux-samsung-soc@vger.kernel.org SGkgSmluZ29vLAoK5ZyoIDIwMTUvOC82IDIyOjE5LCBKaW5nb28gSGFuIOWGmemBkzoKPiBPbiBU aHVyc2RheSwgQXVndXN0IDA2LCAyMDE1IDExOjA3IFBNLCBZYWtpciBZYW5nIHdyb3RlOgo+PiBJ biBvcmRlciB0byBtb3ZlIGV4eW5vcyBkcCBjb2RlIHRvIGJyaWRnZSBkaXJlY3RvcnksCj4+IHdl IG5lZWQgdG8gY29udmVydCBkcml2ZXIgZHJtIGJyaWRnZSBtb2RlIGZpcnN0LiBBcwo+PiBkcCBk cml2ZXIgYWxyZWFkeSBoYXZlIGEgcHRuMzQ2MCBicmlkZ2UsIHNvIHdlIG5lZWQKPj4gdG8gbW92 ZSBwdG4gYnJpZGdlIHRvIHRoZSBuZXh0IGJyaWRnZSBvZiBkcCBicmlkZ2UuCj4+Cj4+IFNpZ25l ZC1vZmYtYnk6IFlha2lyIFlhbmcgPHlra0Byb2NrLWNoaXBzLmNvbT4KPj4gLS0tCj4+ICAgZHJp dmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHBfY29yZS5jIHwgMTk2ICsrKysrKysrKysrKysr KysrKysrLS0tLS0tLS0tLS0tCj4+ICAgZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHBf Y29yZS5oIHwgICAyICsKPj4gICAyIGZpbGVzIGNoYW5nZWQsIDEyNiBpbnNlcnRpb25zKCspLCA3 MiBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9leHlub3Mv ZXh5bm9zX2RwX2NvcmUuYyBiL2RyaXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9zX2RwX2NvcmUu Ywo+PiBpbmRleCBhODA5N2E0Li5hYTk5ZTIzIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vZXh5bm9zL2V4eW5vc19kcF9jb3JlLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2V4eW5v cy9leHlub3NfZHBfY29yZS5jCj4+IEBAIC0zLDYgKzMsNyBAQAo+PiAgICAqCj4+ICAgICogQ29w eXJpZ2h0IChDKSAyMDEyIFNhbXN1bmcgRWxlY3Ryb25pY3MgQ28uLCBMdGQuCj4+ICAgICogQXV0 aG9yOiBKaW5nb28gSGFuIDxqZzEuaGFuQHNhbXN1bmcuY29tPgo+PiArICogICAgICAgICBZYWtp ciBZYW5nIDx5a2tAcm9jay1jaGlwcy5jb20+Cj4gUGxlYXNlIGRvbid0IGFkZCB0aGlzLgo+IFlv dSBqdXN0IGZpeGVkIHNvbWUgcGFydHMgb2YgdGhpcyBjb2RlLiBJIGRvbid0IGZpbmQgdGhlIHJl YXNvbgo+IHdoeSB5b3UgaGF2ZSB0byBiZSBhZGRlZCB0byBhdXRob3IgZm9yIHRoaXMgZmlsZS4K PiBJZiB5b3Ugd2FudCB0aGUgdGl0bGUgZm9yIGFuIGF1dGhvciwgcGxlYXNlIHNlbmQgdGhlIHBh dGNoCj4gZm9yIGEgbmV3IElQLCBpbnN0ZWFkIG9mIG1vZGlmeWluZyB0aGUgZXhpdGluZyBjb2Rl cy4KCk9rYXksIHRoYW5rcyBmb3IgeW91ciByZW1pbmQgOykKCj4+ICAgWy4uLl0KPj4gICBNT0RV TEVfQVVUSE9SKCJKaW5nb28gSGFuIDxqZzEuaGFuQHNhbXN1bmcuY29tPiIpOwo+PiArTU9EVUxF X0FVVEhPUigiWWFraXIgWWFuZyA8eWtrQHJvY2stY2hpcHMuY29tPiIpOwo+IFRoZSBzYW1lIGFz IGFib3ZlLgoKRG9uZQo+PiAgIE1PRFVMRV9ERVNDUklQVElPTigiU2Ftc3VuZyBTb0MgRFAgRHJp dmVyIik7Cj4+ICAgTU9EVUxFX0xJQ0VOU0UoIkdQTCB2MiIpOwo+PiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHBfY29yZS5oIGIvZHJpdmVycy9ncHUvZHJtL2V4 eW5vcy9leHlub3NfZHBfY29yZS5oCj4+IGluZGV4IGMzMjFhZDUuLmYyNTg0YjggMTAwNjQ0Cj4+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9zX2RwX2NvcmUuaAo+PiArKysgYi9k cml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcF9jb3JlLmgKPj4gQEAgLTMsNiArMyw3IEBA Cj4+ICAgICoKPj4gICAgKiBDb3B5cmlnaHQgKEMpIDIwMTIgU2Ftc3VuZyBFbGVjdHJvbmljcyBD by4sIEx0ZC4KPj4gICAgKiBBdXRob3I6IEppbmdvbyBIYW4gPGpnMS5oYW5Ac2Ftc3VuZy5jb20+ Cj4+ICsgKiAgICAgICAgIFlha2lyIFlhbmcgPHlra0Byb2NrLWNoaXBzLmNvbT4KPiBUaGUgc2Ft ZSBhcyBhYm92ZS4KPiBIZXJlLCB5b3UganVzdCBhZGRlZCAxIGxpbmUuIElmIHdlIGFkZCBzb21l b25lIHRvIGF1dGhvcgo+IGluIHRoaXMgd2F5LCBhIGxvdCBvZiBwZW9wbGUgc2hvdWxkIGJlIGFk ZGVkIHRvIGF1dGhvci4KCkRvbmUKCi0gWWFraXIKPiBCZXN0IHJlZ2FyZHMsCj4gSmluZ29vIEhh bgo+Cj4KPgo+Cj4KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: ykk@rock-chips.com (Yakir Yang) Date: Thu, 6 Aug 2015 22:29:29 +0800 Subject: [RFC PATCH 2/8] drm: exynos/dp: convert to drm bridge mode In-Reply-To: <000001d0d052$f44fa3a0$dceeeae0$@com> References: <1438868947-22132-1-git-send-email-ykk@rock-chips.com> <1438870041-23130-1-git-send-email-ykk@rock-chips.com> <000001d0d052$f44fa3a0$dceeeae0$@com> Message-ID: <55C36F49.6020207@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Jingoo, ? 2015/8/6 22:19, Jingoo Han ??: > On Thursday, August 06, 2015 11:07 PM, Yakir Yang wrote: >> In order to move exynos dp code to bridge directory, >> we need to convert driver drm bridge mode first. As >> dp driver already have a ptn3460 bridge, so we need >> to move ptn bridge to the next bridge of dp bridge. >> >> Signed-off-by: Yakir Yang >> --- >> drivers/gpu/drm/exynos/exynos_dp_core.c | 196 ++++++++++++++++++++------------ >> drivers/gpu/drm/exynos/exynos_dp_core.h | 2 + >> 2 files changed, 126 insertions(+), 72 deletions(-) >> >> diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/exynos/exynos_dp_core.c >> index a8097a4..aa99e23 100644 >> --- a/drivers/gpu/drm/exynos/exynos_dp_core.c >> +++ b/drivers/gpu/drm/exynos/exynos_dp_core.c >> @@ -3,6 +3,7 @@ >> * >> * Copyright (C) 2012 Samsung Electronics Co., Ltd. >> * Author: Jingoo Han >> + * Yakir Yang > Please don't add this. > You just fixed some parts of this code. I don't find the reason > why you have to be added to author for this file. > If you want the title for an author, please send the patch > for a new IP, instead of modifying the exiting codes. Okay, thanks for your remind ;) >> [...] >> MODULE_AUTHOR("Jingoo Han "); >> +MODULE_AUTHOR("Yakir Yang "); > The same as above. Done >> MODULE_DESCRIPTION("Samsung SoC DP Driver"); >> MODULE_LICENSE("GPL v2"); >> diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.h b/drivers/gpu/drm/exynos/exynos_dp_core.h >> index c321ad5..f2584b8 100644 >> --- a/drivers/gpu/drm/exynos/exynos_dp_core.h >> +++ b/drivers/gpu/drm/exynos/exynos_dp_core.h >> @@ -3,6 +3,7 @@ >> * >> * Copyright (C) 2012 Samsung Electronics Co., Ltd. >> * Author: Jingoo Han >> + * Yakir Yang > The same as above. > Here, you just added 1 line. If we add someone to author > in this way, a lot of people should be added to author. Done - Yakir > Best regards, > Jingoo Han > > > > >