From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754394AbbHFO6E (ORCPT ); Thu, 6 Aug 2015 10:58:04 -0400 Received: from regular1.263xmail.com ([211.150.99.135]:36065 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752677AbbHFO6B (ORCPT ); Thu, 6 Aug 2015 10:58:01 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [RFC PATCH 3/8] drm: bridge: analogix_dp: split exynos dp driver to bridge dir To: Jingoo Han , "'Heiko Stuebner'" , "'Russell King'" , "'Fabio Estevam'" , "'Inki Dae'" References: <1438868947-22132-1-git-send-email-ykk@rock-chips.com> <1438870763-23796-1-git-send-email-ykk@rock-chips.com> <000101d0d054$f34e9c70$d9ebd550$@com> Cc: djkurtz@google.com, dianders@google.com, "'Takashi Iwai'" , "'Andrzej Hajda'" , "'Thierry Reding'" , "'Philipp Zabel'" , "'David Airlie'" , "'Gustavo Padovan'" , "'Seung-Woo Kim'" , "'Kyungmin Park'" , "'Krzysztof Kozlowski'" , "'Kukjin Kim'" , "'Ajay Kumar'" , "'Joonyoung Shim'" , "'Vincent Palatin'" , "'Mark Yao'" , "'Andy Yan'" , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org From: Yakir Yang Message-ID: <55C375DE.5070001@rock-chips.com> Date: Thu, 6 Aug 2015 22:57:34 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <000101d0d054$f34e9c70$d9ebd550$@com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jingoo, 在 2015/8/6 22:33, Jingoo Han 写道: > On Thursday, August 06, 2015 11:19 PM, Yakir Yang wrote: >> Split the dp core driver from exynos directory to bridge >> directory, and rename the core driver to analogix_dp_*, >> leave the platform code to analogix_dp-exynos. >> >> Signed-off-by: Yakir Yang >> --- >> drivers/gpu/drm/bridge/Kconfig | 5 + >> drivers/gpu/drm/bridge/Makefile | 1 + >> .../exynos_dp_core.c => bridge/analogix_dp_core.c} | 751 +++++------- >> drivers/gpu/drm/bridge/analogix_dp_core.h | 286 +++++ >> drivers/gpu/drm/bridge/analogix_dp_reg.c | 1266 ++++++++++++++++++++ >> .../exynos_dp_reg.h => bridge/analogix_dp_reg.h} | 260 ++-- >> drivers/gpu/drm/exynos/Kconfig | 5 +- >> drivers/gpu/drm/exynos/Makefile | 2 +- >> drivers/gpu/drm/exynos/analogix_dp-exynos.c | 240 ++++ >> drivers/gpu/drm/exynos/exynos_dp_core.h | 283 ----- >> include/drm/bridge/analogix_dp.h | 22 + >> 11 files changed, 2287 insertions(+), 834 deletions(-) >> rename drivers/gpu/drm/{exynos/exynos_dp_core.c => bridge/analogix_dp_core.c} (54%) >> create mode 100644 drivers/gpu/drm/bridge/analogix_dp_core.h >> create mode 100644 drivers/gpu/drm/bridge/analogix_dp_reg.c >> rename drivers/gpu/drm/{exynos/exynos_dp_reg.h => bridge/analogix_dp_reg.h} (63%) >> create mode 100644 drivers/gpu/drm/exynos/analogix_dp-exynos.c >> delete mode 100644 drivers/gpu/drm/exynos/exynos_dp_core.h >> create mode 100644 include/drm/bridge/analogix_dp.h >> >> [...] >> rename from drivers/gpu/drm/exynos/exynos_dp_core.c >> rename to drivers/gpu/drm/bridge/analogix_dp_core.c >> index aa99e23..28724d4 100644 >> --- a/drivers/gpu/drm/exynos/exynos_dp_core.c >> +++ b/drivers/gpu/drm/bridge/analogix_dp_core.c >> @@ -1,7 +1,8 @@ >> /* >> - * Samsung SoC DP (Display Port) interface driver. >> + * Analogix Core DP (Display Port) interface driver. >> * >> * Copyright (C) 2012 Samsung Electronics Co., Ltd. >> + * Copyright (C) FuZhou Rockchip Electronics Co., Ltd. > What is the reason to add this copyright? > You just replace 'exynos' prefix with 'analogix' prefix. > I cannot find the reason to add the copyright. > Oh! Thanks for your point out, sorry for this one - Yakir >> * >> -- >> 2.1.2 > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yakir Yang Subject: Re: [RFC PATCH 3/8] drm: bridge: analogix_dp: split exynos dp driver to bridge dir Date: Thu, 6 Aug 2015 22:57:34 +0800 Message-ID: <55C375DE.5070001@rock-chips.com> References: <1438868947-22132-1-git-send-email-ykk@rock-chips.com> <1438870763-23796-1-git-send-email-ykk@rock-chips.com> <000101d0d054$f34e9c70$d9ebd550$@com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <000101d0d054$f34e9c70$d9ebd550$@com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jingoo Han , 'Heiko Stuebner' , 'Russell King' , 'Fabio Estevam' , 'Inki Dae' Cc: 'Krzysztof Kozlowski' , dri-devel@lists.freedesktop.org, 'Andrzej Hajda' , 'Gustavo Padovan' , 'Ajay Kumar' , linux-samsung-soc@vger.kernel.org, 'Vincent Palatin' , linux-rockchip@lists.infradead.org, 'Kukjin Kim' , 'Thierry Reding' , dianders@google.com, linux-arm-kernel@lists.infradead.org, 'Seung-Woo Kim' , linux-kernel@vger.kernel.org, 'Kyungmin Park' , djkurtz@google.com, 'Andy Yan' List-Id: linux-samsung-soc@vger.kernel.org SmluZ29vLAoK5ZyoIDIwMTUvOC82IDIyOjMzLCBKaW5nb28gSGFuIOWGmemBkzoKPiBPbiBUaHVy c2RheSwgQXVndXN0IDA2LCAyMDE1IDExOjE5IFBNLCBZYWtpciBZYW5nIHdyb3RlOgo+PiBTcGxp dCB0aGUgZHAgY29yZSBkcml2ZXIgZnJvbSBleHlub3MgZGlyZWN0b3J5IHRvIGJyaWRnZQo+PiBk aXJlY3RvcnksIGFuZCByZW5hbWUgdGhlIGNvcmUgZHJpdmVyIHRvIGFuYWxvZ2l4X2RwXyosCj4+ IGxlYXZlIHRoZSBwbGF0Zm9ybSBjb2RlIHRvIGFuYWxvZ2l4X2RwLWV4eW5vcy4KPj4KPj4gU2ln bmVkLW9mZi1ieTogWWFraXIgWWFuZyA8eWtrQHJvY2stY2hpcHMuY29tPgo+PiAtLS0KPj4gICBk cml2ZXJzL2dwdS9kcm0vYnJpZGdlL0tjb25maWcgICAgICAgICAgICAgICAgICAgICB8ICAgIDUg Kwo+PiAgIGRyaXZlcnMvZ3B1L2RybS9icmlkZ2UvTWFrZWZpbGUgICAgICAgICAgICAgICAgICAg IHwgICAgMSArCj4+ICAgLi4uL2V4eW5vc19kcF9jb3JlLmMgPT4gYnJpZGdlL2FuYWxvZ2l4X2Rw X2NvcmUuY30gfCAgNzUxICsrKysrLS0tLS0tLQo+PiAgIGRyaXZlcnMvZ3B1L2RybS9icmlkZ2Uv YW5hbG9naXhfZHBfY29yZS5oICAgICAgICAgIHwgIDI4NiArKysrKwo+PiAgIGRyaXZlcnMvZ3B1 L2RybS9icmlkZ2UvYW5hbG9naXhfZHBfcmVnLmMgICAgICAgICAgIHwgMTI2NiArKysrKysrKysr KysrKysrKysrKwo+PiAgIC4uLi9leHlub3NfZHBfcmVnLmggPT4gYnJpZGdlL2FuYWxvZ2l4X2Rw X3JlZy5ofSAgIHwgIDI2MCArKy0tCj4+ICAgZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9LY29uZmln ICAgICAgICAgICAgICAgICAgICAgfCAgICA1ICstCj4+ICAgZHJpdmVycy9ncHUvZHJtL2V4eW5v cy9NYWtlZmlsZSAgICAgICAgICAgICAgICAgICAgfCAgICAyICstCj4+ICAgZHJpdmVycy9ncHUv ZHJtL2V4eW5vcy9hbmFsb2dpeF9kcC1leHlub3MuYyAgICAgICAgfCAgMjQwICsrKysKPj4gICBk cml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcF9jb3JlLmggICAgICAgICAgICB8ICAyODMg LS0tLS0KPj4gICBpbmNsdWRlL2RybS9icmlkZ2UvYW5hbG9naXhfZHAuaCAgICAgICAgICAgICAg ICAgICB8ICAgMjIgKwo+PiAgIDExIGZpbGVzIGNoYW5nZWQsIDIyODcgaW5zZXJ0aW9ucygrKSwg ODM0IGRlbGV0aW9ucygtKQo+PiAgIHJlbmFtZSBkcml2ZXJzL2dwdS9kcm0ve2V4eW5vcy9leHlu b3NfZHBfY29yZS5jID0+IGJyaWRnZS9hbmFsb2dpeF9kcF9jb3JlLmN9ICg1NCUpCj4+ICAgY3Jl YXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYW5hbG9naXhfZHBfY29yZS5o Cj4+ICAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYW5hbG9naXhf ZHBfcmVnLmMKPj4gICByZW5hbWUgZHJpdmVycy9ncHUvZHJtL3tleHlub3MvZXh5bm9zX2RwX3Jl Zy5oID0+IGJyaWRnZS9hbmFsb2dpeF9kcF9yZWcuaH0gKDYzJSkKPj4gICBjcmVhdGUgbW9kZSAx MDA2NDQgZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9hbmFsb2dpeF9kcC1leHlub3MuYwo+PiAgIGRl bGV0ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcF9jb3JlLmgK Pj4gICBjcmVhdGUgbW9kZSAxMDA2NDQgaW5jbHVkZS9kcm0vYnJpZGdlL2FuYWxvZ2l4X2RwLmgK Pj4KPj4gWy4uLl0KPj4gcmVuYW1lIGZyb20gZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3Nf ZHBfY29yZS5jCj4+IHJlbmFtZSB0byBkcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2FuYWxvZ2l4X2Rw X2NvcmUuYwo+PiBpbmRleCBhYTk5ZTIzLi4yODcyNGQ0IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcF9jb3JlLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2JyaWRnZS9hbmFsb2dpeF9kcF9jb3JlLmMKPj4gQEAgLTEsNyArMSw4IEBACj4+ICAgLyoKPj4g LSAqIFNhbXN1bmcgU29DIERQIChEaXNwbGF5IFBvcnQpIGludGVyZmFjZSBkcml2ZXIuCj4+ICsg KiBBbmFsb2dpeCBDb3JlIERQIChEaXNwbGF5IFBvcnQpIGludGVyZmFjZSBkcml2ZXIuCj4+ICAg ICoKPj4gICAgKiBDb3B5cmlnaHQgKEMpIDIwMTIgU2Ftc3VuZyBFbGVjdHJvbmljcyBDby4sIEx0 ZC4KPj4gKyAqIENvcHlyaWdodCAoQykgRnVaaG91IFJvY2tjaGlwIEVsZWN0cm9uaWNzIENvLiwg THRkLgo+IFdoYXQgaXMgdGhlIHJlYXNvbiB0byBhZGQgdGhpcyBjb3B5cmlnaHQ/Cj4gWW91IGp1 c3QgcmVwbGFjZSAnZXh5bm9zJyBwcmVmaXggd2l0aCAnYW5hbG9naXgnIHByZWZpeC4KPiBJIGNh bm5vdCBmaW5kIHRoZSByZWFzb24gdG8gYWRkIHRoZSBjb3B5cmlnaHQuCj4KCk9oISBUaGFua3Mg Zm9yIHlvdXIgcG9pbnQgb3V0LCBzb3JyeSBmb3IgdGhpcyBvbmUKCi0gWWFraXIKPj4gICAgKgo+ PiAtLQo+PiAyLjEuMgo+Cj4KPgo+CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: ykk@rock-chips.com (Yakir Yang) Date: Thu, 6 Aug 2015 22:57:34 +0800 Subject: [RFC PATCH 3/8] drm: bridge: analogix_dp: split exynos dp driver to bridge dir In-Reply-To: <000101d0d054$f34e9c70$d9ebd550$@com> References: <1438868947-22132-1-git-send-email-ykk@rock-chips.com> <1438870763-23796-1-git-send-email-ykk@rock-chips.com> <000101d0d054$f34e9c70$d9ebd550$@com> Message-ID: <55C375DE.5070001@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Jingoo, ? 2015/8/6 22:33, Jingoo Han ??: > On Thursday, August 06, 2015 11:19 PM, Yakir Yang wrote: >> Split the dp core driver from exynos directory to bridge >> directory, and rename the core driver to analogix_dp_*, >> leave the platform code to analogix_dp-exynos. >> >> Signed-off-by: Yakir Yang >> --- >> drivers/gpu/drm/bridge/Kconfig | 5 + >> drivers/gpu/drm/bridge/Makefile | 1 + >> .../exynos_dp_core.c => bridge/analogix_dp_core.c} | 751 +++++------- >> drivers/gpu/drm/bridge/analogix_dp_core.h | 286 +++++ >> drivers/gpu/drm/bridge/analogix_dp_reg.c | 1266 ++++++++++++++++++++ >> .../exynos_dp_reg.h => bridge/analogix_dp_reg.h} | 260 ++-- >> drivers/gpu/drm/exynos/Kconfig | 5 +- >> drivers/gpu/drm/exynos/Makefile | 2 +- >> drivers/gpu/drm/exynos/analogix_dp-exynos.c | 240 ++++ >> drivers/gpu/drm/exynos/exynos_dp_core.h | 283 ----- >> include/drm/bridge/analogix_dp.h | 22 + >> 11 files changed, 2287 insertions(+), 834 deletions(-) >> rename drivers/gpu/drm/{exynos/exynos_dp_core.c => bridge/analogix_dp_core.c} (54%) >> create mode 100644 drivers/gpu/drm/bridge/analogix_dp_core.h >> create mode 100644 drivers/gpu/drm/bridge/analogix_dp_reg.c >> rename drivers/gpu/drm/{exynos/exynos_dp_reg.h => bridge/analogix_dp_reg.h} (63%) >> create mode 100644 drivers/gpu/drm/exynos/analogix_dp-exynos.c >> delete mode 100644 drivers/gpu/drm/exynos/exynos_dp_core.h >> create mode 100644 include/drm/bridge/analogix_dp.h >> >> [...] >> rename from drivers/gpu/drm/exynos/exynos_dp_core.c >> rename to drivers/gpu/drm/bridge/analogix_dp_core.c >> index aa99e23..28724d4 100644 >> --- a/drivers/gpu/drm/exynos/exynos_dp_core.c >> +++ b/drivers/gpu/drm/bridge/analogix_dp_core.c >> @@ -1,7 +1,8 @@ >> /* >> - * Samsung SoC DP (Display Port) interface driver. >> + * Analogix Core DP (Display Port) interface driver. >> * >> * Copyright (C) 2012 Samsung Electronics Co., Ltd. >> + * Copyright (C) FuZhou Rockchip Electronics Co., Ltd. > What is the reason to add this copyright? > You just replace 'exynos' prefix with 'analogix' prefix. > I cannot find the reason to add the copyright. > Oh! Thanks for your point out, sorry for this one - Yakir >> * >> -- >> 2.1.2 > > > >