From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753651AbbHFPA4 (ORCPT ); Thu, 6 Aug 2015 11:00:56 -0400 Received: from regular1.263xmail.com ([211.150.99.139]:45082 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751075AbbHFPAy (ORCPT ); Thu, 6 Aug 2015 11:00:54 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [RFC PATCH 0/8] Add Analogix Core Display Port Driver To: Jingoo Han , "'Heiko Stuebner'" , "'Russell King'" , "'Fabio Estevam'" , "'Inki Dae'" References: <1438868947-22132-1-git-send-email-ykk@rock-chips.com> <000201d0d056$06cff040$146fd0c0$@com> Cc: djkurtz@google.com, dianders@google.com, "'Takashi Iwai'" , "'Andrzej Hajda'" , "'Thierry Reding'" , "'Philipp Zabel'" , "'David Airlie'" , "'Gustavo Padovan'" , "'Seung-Woo Kim'" , "'Kyungmin Park'" , "'Krzysztof Kozlowski'" , "'Kukjin Kim'" , "'Ajay Kumar'" , "'Joonyoung Shim'" , "'Vincent Palatin'" , "'Mark Yao'" , "'Andy Yan'" , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org From: Yakir Yang Message-ID: <55C3769F.2010405@rock-chips.com> Date: Thu, 6 Aug 2015 23:00:47 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <000201d0d056$06cff040$146fd0c0$@com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jingoo, 在 2015/8/6 22:41, Jingoo Han 写道: > On Thursday, August 06, 2015 10:49 PM, Yakir Yang wrote: >> Hi all, >> Samsung exynos and Rockchip rk3288 almost share same dp controller, >> so I split the common code out, then rk3288 and exynos can re-used the >> same dp core driver. Cause I can't find the exact IP name of exynos dp >> controller, so I decide to name dp core driver with "analogix" which I >> find in rk3288 eDP TRM ;) > > OK, I see. > The Samsung Exynos eDP contoller and Rockchip rk3288 eDP contoller share > the same IP. So, a lot of parts can be re-used. I agree with this. > However, we have to review the code carefully, as others did. Yeah, feel happy to be reviewed ;) > I also cannot find the exact IP name. The "analogix" may be the vendor name > of this IP. Okay, so "analogix" is okay for now Thanks, - Yakir > Best regards, > Jingoo Han > >> Beyond that, there are three light registers setting differents bewteen >> exynos and rk3288. >> 1. RK3288 have five special pll resigters which not indicata in exynos >> dp controller. >> 2. The address of DP_PHY_PD(dp phy power manager register) are different >> between rk3288 and exynos. >> 3. Rk3288 and exynos have different setting with AUX_HW_RETRY_CTL(dp debug >> register). >> >> My series patches can be divider into two parts: One for spliting the >> analogix_dp code from exynos dp driver. Another are trying to add rk3288 >> dp driver support. >> >> Best regards, >> - Yakir >> >> >> -- >> 2.1.2 > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: ykk@rock-chips.com (Yakir Yang) Date: Thu, 6 Aug 2015 23:00:47 +0800 Subject: [RFC PATCH 0/8] Add Analogix Core Display Port Driver In-Reply-To: <000201d0d056$06cff040$146fd0c0$@com> References: <1438868947-22132-1-git-send-email-ykk@rock-chips.com> <000201d0d056$06cff040$146fd0c0$@com> Message-ID: <55C3769F.2010405@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Jingoo, ? 2015/8/6 22:41, Jingoo Han ??: > On Thursday, August 06, 2015 10:49 PM, Yakir Yang wrote: >> Hi all, >> Samsung exynos and Rockchip rk3288 almost share same dp controller, >> so I split the common code out, then rk3288 and exynos can re-used the >> same dp core driver. Cause I can't find the exact IP name of exynos dp >> controller, so I decide to name dp core driver with "analogix" which I >> find in rk3288 eDP TRM ;) > > OK, I see. > The Samsung Exynos eDP contoller and Rockchip rk3288 eDP contoller share > the same IP. So, a lot of parts can be re-used. I agree with this. > However, we have to review the code carefully, as others did. Yeah, feel happy to be reviewed ;) > I also cannot find the exact IP name. The "analogix" may be the vendor name > of this IP. Okay, so "analogix" is okay for now Thanks, - Yakir > Best regards, > Jingoo Han > >> Beyond that, there are three light registers setting differents bewteen >> exynos and rk3288. >> 1. RK3288 have five special pll resigters which not indicata in exynos >> dp controller. >> 2. The address of DP_PHY_PD(dp phy power manager register) are different >> between rk3288 and exynos. >> 3. Rk3288 and exynos have different setting with AUX_HW_RETRY_CTL(dp debug >> register). >> >> My series patches can be divider into two parts: One for spliting the >> analogix_dp code from exynos dp driver. Another are trying to add rk3288 >> dp driver support. >> >> Best regards, >> - Yakir >> >> >> -- >> 2.1.2 > > > >