From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yakir Yang Subject: Re: [RFC PATCH 0/8] Add Analogix Core Display Port Driver Date: Fri, 7 Aug 2015 16:17:43 +0800 Message-ID: <55C469A7.90507@rock-chips.com> References: <1438868947-22132-1-git-send-email-ykk@rock-chips.com> <000201d0d056$06cff040$146fd0c0$@com> <55C3769F.2010405@rock-chips.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0490297834==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ajay kumar , Sean Paul , Sean Paul Cc: Krzysztof Kozlowski , "dri-devel@lists.freedesktop.org" , Andrzej Hajda , Gustavo Padovan , Ajay Kumar , "linux-samsung-soc@vger.kernel.org" , Vincent Palatin , "linux-rockchip@lists.infradead.org" , Kukjin Kim , Russell King , Thierry Reding , "dianders@google.com" , "linux-arm-kernel@lists.infradead.org" , Fabio Estevam , Jingoo Han , Seung-Woo Kim , "linux-kernel@vger.kernel.org" , Kyungmin Park List-Id: linux-samsung-soc@vger.kernel.org This is a multi-part message in MIME format. --===============0490297834== Content-Type: multipart/alternative; boundary="------------000505040805060908020309" This is a multi-part message in MIME format. --------------000505040805060908020309 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Ajay, =E5=9C=A8 2015/8/7 14:11, Ajay kumar =E5=86=99=E9=81=93: > +Sean > Woh, okay, I will loop you and Sean to cc list in follow versions ;) -Yakir > On Thursday, August 6, 2015, Yakir Yang > wrote: > > Jingoo, > > =E5=9C=A8 2015/8/6 22:41, Jingoo Han =E5=86=99=E9=81=93: > > On Thursday, August 06, 2015 10:49 PM, Yakir Yang wrote: > > Hi all, > Samsung exynos and Rockchip rk3288 almost share same > dp controller, > so I split the common code out, then rk3288 and exynos can > re-used the > same dp core driver. Cause I can't find the exact IP name > of exynos dp > controller, so I decide to name dp core driver with > "analogix" which I > find in rk3288 eDP TRM ;) > > > OK, I see. > The Samsung Exynos eDP contoller and Rockchip rk3288 eDP > contoller share > the same IP. So, a lot of parts can be re-used. I agree with th= is. > However, we have to review the code carefully, as others did. > > Yeah, feel happy to be reviewed ;) > > I also cannot find the exact IP name. The "analogix" may be > the vendor name > of this IP. > > Okay, so "analogix" is okay for now > > Thanks, > - Yakir > > Best regards, > Jingoo Han > > Beyond that, there are three light registers setting > differents bewteen > exynos and rk3288. > 1. RK3288 have five special pll resigters which not > indicata in exynos > dp controller. > 2. The address of DP_PHY_PD(dp phy power manager register) > are different > between rk3288 and exynos. > 3. Rk3288 and exynos have different setting with > AUX_HW_RETRY_CTL(dp debug > register). > > My series patches can be divider into two parts: One for > spliting the > analogix_dp code from exynos dp driver. Another are trying > to add rk3288 > dp driver support. > > Best regards, > - Yakir > > > -- > 2.1.2 > > > > > > > > -- > To unsubscribe from this list: send the line "unsubscribe > linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > --------------000505040805060908020309 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ajay,

=E5=9C=A8 2015/8/7 14:11, Ajay kumar =E5= =86=99=E9=81=93:
+Sean


Woh, okay, I will loop you and Sean to cc list in follow versions=C2=A0 ;)

-Yakir
On Thursday, August 6, 2015, Yakir Yang <ykk@r= ock-chips.com> wrote:
Jingoo,

=E5=9C=A8 2015/8/6 22:41, Jingoo Han =E5=86=99=E9=81=93:
On Thursday, August 06, 2015 10:49 PM, Yakir Yang wrote:
Hi all,
=C2=A0 =C2=A0 Samsung exynos and Rockchip rk3288 almost share= same dp controller,
so I split the common code out, then rk3288 and exynos can re-used the
same dp core driver. Cause I can't find the exact IP name of exynos dp
controller, so I decide to name dp core driver with "analogix" which I
find in rk3288 eDP TRM ;)

OK, I see.
The Samsung Exynos eDP contoller and Rockchip rk3288 eDP contoller share
the same IP. So, a lot of parts can be re-used. I agree with this.
However, we have to review the code carefully, as others did.
Yeah, feel happy to be reviewed=C2=A0 ;)

I also cannot find the exact IP name. The "analogix" may be the vendor name
of this IP.
Okay, so "analogix" is okay for now

Thanks,
- Yakir
Best regards,
Jingoo Han

Beyond that, there are three light registers setting differents bewteen
exynos and rk3288.
1. RK3288 have five special pll resigters which not indicata in exynos
=C2=A0 =C2=A0 dp controller.
2. The address of DP_PHY_PD(dp phy power manager register) are different
=C2=A0 =C2=A0 between rk3288 and exynos.
3. Rk3288 and exynos have different setting with AUX_HW_RETRY_CTL(dp debug
=C2=A0 =C2=A0 register).

My series patches can be divider into two parts: One for spliting the
analogix_dp code from exynos dp driver. Another are trying to add rk3288
dp driver support.

Best regards,
- Yakir


--
2.1.2






--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vg= er.kernel.org
More majordomo info at=C2=A0 http://vger.kernel.org/majordomo-info.html

--------------000505040805060908020309-- --===============0490297834== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0490297834==--