From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752189AbbHGKR4 (ORCPT ); Fri, 7 Aug 2015 06:17:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48087 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750863AbbHGKRy (ORCPT ); Fri, 7 Aug 2015 06:17:54 -0400 Subject: Re: [PATCH] kvm:powerpc:Fix error handling in the function mpic_set_default_irq_routing To: Nicholas Krause , agraf@suse.com References: <1438881190-27287-1-git-send-email-xerofoify@gmail.com> Cc: gleb@kernel.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org From: Paolo Bonzini Message-ID: <55C485CD.4040708@redhat.com> Date: Fri, 7 Aug 2015 12:17:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1438881190-27287-1-git-send-email-xerofoify@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/08/2015 19:13, Nicholas Krause wrote: > diff --git a/arch/powerpc/kvm/mpic.c b/arch/powerpc/kvm/mpic.c > index 6249cdc..5a18859 100644 > --- a/arch/powerpc/kvm/mpic.c > +++ b/arch/powerpc/kvm/mpic.c > @@ -1641,13 +1641,16 @@ static void mpic_destroy(struct kvm_device *dev) > static int mpic_set_default_irq_routing(struct openpic *opp) > { > struct kvm_irq_routing_entry *routing; > + int ret; > > /* Create a nop default map, so that dereferencing it still works */ > routing = kzalloc((sizeof(*routing)), GFP_KERNEL); > if (!routing) > return -ENOMEM; > > - kvm_set_irq_routing(opp->kvm, routing, 0, 0); > + ret = kvm_set_irq_routing(opp->kvm, routing, 0, 0); > + if (ret) > + return ret; > > kfree(routing); > return 0; The patch leaks the "routing" variable if you hit the error path. Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Date: Fri, 07 Aug 2015 10:17:49 +0000 Subject: Re: [PATCH] kvm:powerpc:Fix error handling in the function mpic_set_default_irq_routing Message-Id: <55C485CD.4040708@redhat.com> List-Id: References: <1438881190-27287-1-git-send-email-xerofoify@gmail.com> In-Reply-To: <1438881190-27287-1-git-send-email-xerofoify@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Nicholas Krause , agraf@suse.com Cc: gleb@kernel.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org On 06/08/2015 19:13, Nicholas Krause wrote: > diff --git a/arch/powerpc/kvm/mpic.c b/arch/powerpc/kvm/mpic.c > index 6249cdc..5a18859 100644 > --- a/arch/powerpc/kvm/mpic.c > +++ b/arch/powerpc/kvm/mpic.c > @@ -1641,13 +1641,16 @@ static void mpic_destroy(struct kvm_device *dev) > static int mpic_set_default_irq_routing(struct openpic *opp) > { > struct kvm_irq_routing_entry *routing; > + int ret; > > /* Create a nop default map, so that dereferencing it still works */ > routing = kzalloc((sizeof(*routing)), GFP_KERNEL); > if (!routing) > return -ENOMEM; > > - kvm_set_irq_routing(opp->kvm, routing, 0, 0); > + ret = kvm_set_irq_routing(opp->kvm, routing, 0, 0); > + if (ret) > + return ret; > > kfree(routing); > return 0; The patch leaks the "routing" variable if you hit the error path. Paolo