From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v4 24/31] libxc: allow creating domains
 without emulated devices.
Date: Fri, 7 Aug 2015 17:36:57 +0100
Message-ID: <55C4DEA9.5000905@citrix.com>
References: <1438942688-7610-1-git-send-email-roger.pau@citrix.com>
	<1438942688-7610-25-git-send-email-roger.pau@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=654663106=Andrew.Cooper3@citrix.com>)
	id 1ZNkdi-0006EZ-JT
	for xen-devel@lists.xenproject.org; Fri, 07 Aug 2015 16:37:02 +0000
In-Reply-To: <1438942688-7610-25-git-send-email-roger.pau@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Roger Pau Monne <roger.pau@citrix.com>, xen-devel@lists.xenproject.org
Cc: Ian Jackson <ian.jackson@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 07/08/15 11:18, Roger Pau Monne wrote:
> @@ -1336,7 +1343,8 @@ static int meminit_hvm(struct xc_dom_image *dom)
>           * tot_pages will be target_pages - VGA_HOLE_SIZE after
>           * this call.
>           */
> -        rc = xc_domain_set_pod_target(xch, domid, target_pages - VGA_HOLE_SIZE,
> +        rc = xc_domain_set_pod_target(xch, domid, target_pages -
> +                                      dom->emulation ? VGA_HOLE_SIZE : 0,
>                                        NULL, NULL, NULL);

This might be more cleanly expressed as having d->vga_hole_size which is
either VGA_HOLE_SIZE or 0, depending on dom->emulation.

~Andrew