From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946771AbbHHQeK (ORCPT ); Sat, 8 Aug 2015 12:34:10 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:58375 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946708AbbHHQeI (ORCPT ); Sat, 8 Aug 2015 12:34:08 -0400 Subject: Re: [PATCH V10 4/5] arm64: apei: implement arch_apei_get_mem_attributes() To: Ard Biesheuvel , Matt Fleming References: <1438868434-28736-1-git-send-email-zjzhang@codeaurora.org> <1438868434-28736-5-git-send-email-zjzhang@codeaurora.org> <20150807093750.GB2625@codeblueprint.co.uk> <55C4F5E3.30704@codeaurora.org> <20150807185738.GF2625@codeblueprint.co.uk> Cc: Catalin Marinas , Will Deacon , Fu Wei , Al Stone , Borislav Petkov , Matt Fleming , "Rafael J. Wysocki" , Hanjun Guo , Leif Lindholm , "linux-kernel@vger.kernel.org" , Linaro ACPI Mailman List , Timur Tabi From: "Zhang, Jonathan Zhixiong" Message-ID: <55C62F7D.10702@codeaurora.org> Date: Sat, 8 Aug 2015 09:34:05 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/8/2015 1:11 AM, Ard Biesheuvel wrote: > On 7 August 2015 at 20:57, Matt Fleming wrote: >> On Fri, 07 Aug, at 11:16:03AM, Zhang, Jonathan Zhixiong wrote: >>> >>> On some (future) arm64 platforms, APEI/GHES region may have full >>> coherent access by platform. In such case, the APEI/GHES region have >>> the same memory attributes as the rest of system RAM, such region >>> do not need to be advised by UEFI as separate entry, but as part of >>> system RAM memory region. >>> That being said, for arm64 platforms that do not have WB capability >>> for APEI/GHES region, such region should be mapped accordingly. >> >> OK, so what I need to know right now is whether I need to drop this >> entire series from my pull request or whether you can send a patch on >> top of the existing ones in the EFI 'next' branch to address the mapping >> heuristic in arch_apei_get_mem_attributes(). >> >>>>> Jonathan, can you please provide the EFI memory map region attributes >>>>> for the GHES region that requires this series? >>> [Reserved | | | | | | | | |UC] >> >> Assuming this memmap entry is indicative of most GHES region on arm64 >> right now, I think it's worth taking this patch as-is and addressing the >> issue Ard raised as a separate patch. >> >> Does that work? >> > > I think that is fine. > > So we'll expect two patches on top of Matt's -next branch: > - one that removes the redundant __pgprot > - one that inverts the order in which the memory attributes are tested > > It would be good to have these in the same release so that the > behavior does not change between releases. I have above mentioned two changes ready to go. I will send V11 of the patch set out in the next hour. > > Thanks, > Ard. > -- Jonathan (Zhixiong) Zhang The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project