Re: [Qemu-devel] [PATCH for-2.5 3/6] Add new block driver interface to add/delete a BDS's child

From: Wen Congyang <wency@cn.fujitsu.com>
To: Alberto Garcia <berto@igalia.com>,
	qemu devel <qemu-devel@nongnu.org>,
	Eric Blake <eblake@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	zhanghailiang <zhang.zhanghailiang@huawei.com>,
	qemu block <qemu-block@nongnu.org>,
	Jiang Yunhong <yunhong.jiang@intel.com>,
	Dong Eddie <eddie.dong@intel.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Gonglei <arei.gonglei@huawei.com>,
	Yang Hongyang <yanghy@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH for-2.5 3/6] Add new block driver interface to add/delete a BDS's child
Date: Mon, 10 Aug 2015 17:53:07 +0800	[thread overview]
Message-ID: <55C87483.6030103@cn.fujitsu.com> (raw)
In-Reply-To: <w51pp2vimi4.fsf@maestria.local.igalia.com>

On 08/10/2015 04:19 PM, Alberto Garcia wrote:
> On Fri 31 Jul 2015 11:19:12 AM CEST, Wen Congyang wrote:
> 
>> +static const char *bdrv_get_id_or_node_name(BlockDriverState *bs)
>> +{
>> +    if (bs->blk) {
>> +        return blk_name(bs->blk);
>> +    }
>> +
>> +    return bs->node_name ? bs->node_name : "";
>> +}
> 
> You don't need to add this function, you can use
> bdrv_get_device_or_node_name() instead.

Yes, I will update it in the next version.

Thanks
Wen Congyang

> 
> Berto
> .
> 