From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752183AbbHJMlp (ORCPT ); Mon, 10 Aug 2015 08:41:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36974 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752071AbbHJMln (ORCPT ); Mon, 10 Aug 2015 08:41:43 -0400 Subject: Re: [PATCH] tools lib traceevent: add checks for returned EVENT_ERROR type To: Namhyung Kim References: <20150803170804.22235.88475.email-sent-by-dnelson@teal> <20150807105910.GE8624@krava.brq.redhat.com> <20150809031058.GD29295@danjae.kornet> Cc: Jiri Olsa , mingo@redhat.com, rostedt@goodmis.org, acme@kernel.org, linux-kernel@vger.kernel.org From: Dean Nelson Message-ID: <55C89C05.2080904@redhat.com> Date: Mon, 10 Aug 2015 07:41:41 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20150809031058.GD29295@danjae.kornet> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/08/2015 10:10 PM, Namhyung Kim wrote: > On Fri, Aug 07, 2015 at 12:59:10PM +0200, Jiri Olsa wrote: >> On Mon, Aug 03, 2015 at 01:08:05PM -0400, Dean Nelson wrote: >>> The second warning message and SIGSEGV stem from the issue expressed in the >>> first warning message, and are the result of ignoring the EVENT_ERROR type >>> returned back through the call chain. >>> >>> Dealing with the first warning message is beyond the scope of this patch. But >>> the second warning is addressed by this patch's first hunk. And the SIGSEGV is >>> eliminated by its second hunk. >>> >>> Signed-off-by: Dean Nelson >>> --- >>> tools/lib/traceevent/event-parse.c | 5 ++++- >>> 1 file changed, 4 insertions(+), 1 deletion(-) >>> >>> diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c >>> index cc25f05..72e2933 100644 >>> --- a/tools/lib/traceevent/event-parse.c >>> +++ b/tools/lib/traceevent/event-parse.c >>> @@ -1680,6 +1680,9 @@ process_cond(struct event_format *event, struct print_arg *top, char **tok) >>> type = process_arg(event, left, &token); >>> >>> again: >>> + if (type == EVENT_ERROR) >>> + goto out_free; >>> + >>> /* Handle other operations in the arguments */ >>> if (type == EVENT_OP && strcmp(token, ":") != 0) { >>> type = process_op(event, left, &token); >>> @@ -1940,7 +1943,7 @@ process_op(struct event_format *event, struct print_arg *arg, char **tok) >>> >>> type = process_arg_token(event, right, tok, type); >>> >>> - if (right->type == PRINT_OP && >>> + if (type != EVENT_ERROR && right->type == PRINT_OP && > > I think you'd better put the error check on separate lines. Other > than that look good to me. Okay. I've posted a v2. Consider v1 NAK'd. And thank you Namhyung for reviewing this patch! > > Thanks, > Namhyung > > >>> get_op_prio(arg->op.op) < get_op_prio(right->op.op)) { >>> struct print_arg tmp; >>> > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >