From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932675AbbHJT16 (ORCPT ); Mon, 10 Aug 2015 15:27:58 -0400 Received: from lists.s-osg.org ([54.187.51.154]:57000 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932448AbbHJT1z (ORCPT ); Mon, 10 Aug 2015 15:27:55 -0400 Message-ID: <55C8FB38.50707@osg.samsung.com> Date: Mon, 10 Aug 2015 13:27:52 -0600 From: Shuah Khan Organization: Samsung Open Source Group User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Thierry Reding , Andrew Morton CC: Eric B Munson , Andrea Arcangeli , linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan Subject: Re: [PATCH 1/4] selftests: vm: Fix mlock2-tests for 32-bit architectures References: <1438955055-587-1-git-send-email-thierry.reding@gmail.com> In-Reply-To: <1438955055-587-1-git-send-email-thierry.reding@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/07/2015 07:44 AM, Thierry Reding wrote: > From: Thierry Reding > > According to Documentation/vm/pagemap.txt, the /proc/pid/pagemap file > contains one 64-bit value for each virtual page. The test code relies > on the size of unsigned long being 64-bit, which breaks the test when > run on 32-bit architectures. Use a uint64_t to store values read from > the file instead, so that it works irrespective of the architecture's > word size. > > Signed-off-by: Thierry Reding > --- Looks good to me. Andrew! Would you like me to take this patch and the other two in this series through kselftest git? thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shuah Khan Subject: Re: [PATCH 1/4] selftests: vm: Fix mlock2-tests for 32-bit architectures Date: Mon, 10 Aug 2015 13:27:52 -0600 Message-ID: <55C8FB38.50707@osg.samsung.com> References: <1438955055-587-1-git-send-email-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1438955055-587-1-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Thierry Reding , Andrew Morton Cc: Eric B Munson , Andrea Arcangeli , linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Shuah Khan List-Id: linux-api@vger.kernel.org On 08/07/2015 07:44 AM, Thierry Reding wrote: > From: Thierry Reding > > According to Documentation/vm/pagemap.txt, the /proc/pid/pagemap file > contains one 64-bit value for each virtual page. The test code relies > on the size of unsigned long being 64-bit, which breaks the test when > run on 32-bit architectures. Use a uint64_t to store values read from > the file instead, so that it works irrespective of the architecture's > word size. > > Signed-off-by: Thierry Reding > --- Looks good to me. Andrew! Would you like me to take this patch and the other two in this series through kselftest git? thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org | (970) 217-8978