From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: Design doc of adding ACPI support for arm64 on Xen
 - version 5
Date: Fri, 28 Aug 2015 09:06:48 -0600
Message-ID: <55E09528020000780009DE26@prv-mh.provo.novell.com>
References: <55E02DC5.4090202@huawei.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <55E02DC5.4090202@huawei.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Shannon Zhao <zhaoshenglong@huawei.com>
Cc: Hangaohuai <hangaohuai@huawei.com>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Shannon Zhao <shannon.zhao@linaro.org>, andrew@fubar.geek.nz, "Huangpeng (Peter)" <peter.huangpeng@huawei.com>, Julien Grall <julien.grall@citrix.com>, Stefano Stabellini <stefano.stabellini@citrix.com>, David Vrabel <david.vrabel@citrix.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, xen-devel <xen-devel@lists.xen.org>, Parth Dixit <parth.dixit@linaro.org>, Christoffer Dall <christoffer.dall@linaro.org>, RogerPau Monne <roger.pau@citrix.com>
List-Id: xen-devel@lists.xenproject.org

>>> On 28.08.15 at 11:45, <zhaoshenglong@huawei.com> wrote:
> 2. Copy and change some EFI and ACPI tables
> -------------------------------------------
> a) Create EFI_SYSTEM_TABLE table
> Copy the header from the origin and change the value of FirmwareVendor.

Careful: The version in the header may imply that fields are there
which you aren't aware of. I think you need to adjust the version
field too. (Obviously along with FirmwareVendor you definitely also
want to change FirmwareRevision.)

> Create only one ConfigurationTable to store VendorGuid and VendorTable.

What do you mean with "Create only one ..." - there is only one.
DYM "Create one additional Configuration Table entry ...", implying
that the Configuration Table will need to by copied too?

> d) Copy MADT table
> It needs to change MADT table to restrict the number of vCPUs. We choose
> to copy the first dom0_max_vcpus GICC entries of MADT to new created
> MADT table when numa is not supported currently.

Copy means you imply to have an original? What if dom0_max_vcpus
is larger than the physical CPU count?

> g) Copy RSDP table
> Change the value of xsdt_physical_address in RSDP table. As we create a
> new XSDT table and the address of XSDT is changed, so it needs to update
> the value of "xsdt_physical_address" in RSDP. So Dom0 could get the
> right XSDT table rather than the old one. And it needs to update the
> value of VendorTable in EFI Configuration Table which is created in
> above step a).

How is this last sentence related to the handling of RSDP?

Jan