From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36414) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWSVh-0000aX-8v for qemu-devel@nongnu.org; Mon, 31 Aug 2015 13:04:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZWSVg-0001Lp-9L for qemu-devel@nongnu.org; Mon, 31 Aug 2015 13:04:45 -0400 References: <1439279489-13338-1-git-send-email-wency@cn.fujitsu.com> <1439279489-13338-2-git-send-email-wency@cn.fujitsu.com> From: Eric Blake Message-ID: <55E4891A.3030004@redhat.com> Date: Mon, 31 Aug 2015 11:04:26 -0600 MIME-Version: 1.0 In-Reply-To: <1439279489-13338-2-git-send-email-wency@cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wBHF4McAtOIFfXJhNSIKGdh8KU4HObfwg" Subject: Re: [Qemu-devel] [Patch for-2.5 v2 1/6] QAPI: move InetSocketAddress to qapi/common.json List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wen Congyang , qemu devel , Markus Armbruster , Alberto Garcia , Stefan Hajnoczi Cc: Kevin Wolf , zhanghailiang , qemu block , Jiang Yunhong , Dong Eddie , "Dr. David Alan Gilbert" , Gonglei , Yang Hongyang This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --wBHF4McAtOIFfXJhNSIKGdh8KU4HObfwg Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/11/2015 01:51 AM, Wen Congyang wrote: > It will be used by BlockdevOptionsNBD. >=20 > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > Reviewed-by: Alberto Garcia > --- > qapi-schema.json | 27 --------------------------- > qapi/common.json | 27 +++++++++++++++++++++++++++ > 2 files changed, 27 insertions(+), 27 deletions(-) >=20 Reviewed-by: Eric Blake > +++ b/qapi/common.json > @@ -114,3 +114,30 @@ > ## > { 'enum': 'OnOffAuto', > 'data': [ 'auto', 'on', 'off' ] } > + > +## > +# @InetSocketAddress > +# > +# Captures a socket address or address range in the Internet namespace= =2E > +# > +# @host: host part of the address > +# > +# @port: port part of the address, or lowest port if @to is present > +# > +# @to: highest port to try > +# > +# @ipv4: whether to accept IPv4 addresses, default try both IPv4 and I= Pv6 > +# #optional > +# > +# @ipv6: whether to accept IPv6 addresses, default try both IPv4 and I= Pv6 > +# #optional > +# > +# Since 1.3 > +## > +{ 'struct': 'InetSocketAddress', > + 'data': { > + 'host': 'str', > + 'port': 'str', > + '*to': 'uint16', The fact that 'port' is sometimes textual, and sometimes an integer, is pre-existing, so moving it does not affect the validity of this patch. But I wonder if we should in the future add an 'alternate' type that allows us to directly pass an integer for 'port', rather than always having to pass a stringized integer. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --wBHF4McAtOIFfXJhNSIKGdh8KU4HObfwg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV5IkaAAoJEKeha0olJ0NqeDEH/ifNXIn65tmVTpHm6zGvNHeI 1miThUGur4ck+TLa9GFE+XYcwsfyK6efa2RL130KLNJLFJXSPgsqxR62uj/qmrTh p91riZKZpzUNaFAguW3Keqadz0D4cy0J+7rnyveZaj/21adMetqX2Z535sbj526J KMP26ILCjuZk9Lp7AlCduAwSXm44eYrAUL/g2VWfQMeTA9jhXFGzSvqqMjeHidlK 2Yv5iBywaegxw6BUN5f0m0duQ+pzE4JACQie59bDl5MI8UUa+JYZWFzuO9AWDWZs WWc97vnFGX9G9/WbEqsPmqjYSyW0U/W3TR9GPUf5IktjfpYnjCxNrJjH9ayg5T4= =un35 -----END PGP SIGNATURE----- --wBHF4McAtOIFfXJhNSIKGdh8KU4HObfwg--