From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH 1/3] soc: qcom: smd: Represent channel layout in structures Date: Tue, 1 Sep 2015 10:51:02 -0700 Message-ID: <55E5E586.3060905@codeaurora.org> References: <1441071594-15941-1-git-send-email-sboyd@codeaurora.org> <1441071594-15941-2-git-send-email-sboyd@codeaurora.org> <20150901045502.GB13472@usrtlx11787.corpusers.net> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:59714 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753425AbbIARvF (ORCPT ); Tue, 1 Sep 2015 13:51:05 -0400 In-Reply-To: <20150901045502.GB13472@usrtlx11787.corpusers.net> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Bjorn Andersson Cc: Andy Gross , "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" On 08/31/2015 09:55 PM, Bjorn Andersson wrote: > On Mon 31 Aug 18:39 PDT 2015, Stephen Boyd wrote: > >> The rx and tx channel info are laid out in memory next to each >> other, and there are two types of channel info structures, byte >> based and word based. We have 4 pointers to these info >> structures, when we really only need two to point to the >> different types of structures. Encapsulate the byte based and word >> based tx/rx structures in a "full channel" structure that >> describes the layout of memory and reduces the number of pointers >> in the smd channel structure by two. >> > Saving the extra pointer doesn't feel like worth the change, but > representing the pair of info structs as one sounds like a reasonable > cleanup. Agreed. > > Reviewed-by: Bjorn Andersson >> Signed-off-by: Stephen Boyd >> --- >> drivers/soc/qcom/smd.c | 61 +++++++++++++++++++++++++++----------------------- >> 1 file changed, 33 insertions(+), 28 deletions(-) >> >> diff --git a/drivers/soc/qcom/smd.c b/drivers/soc/qcom/smd.c >> index edd9d9a37238..c16547b85e05 100644 >> --- a/drivers/soc/qcom/smd.c >> +++ b/drivers/soc/qcom/smd.c >> @@ -65,7 +65,9 @@ >> */ >> >> struct smd_channel_info; >> +struct smd_full_channel_info; > I would have called this "smd_channel_info_pair"... Sure I'll make the change and add your Reviewed-by. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753873AbbIARvH (ORCPT ); Tue, 1 Sep 2015 13:51:07 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:59714 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753425AbbIARvF (ORCPT ); Tue, 1 Sep 2015 13:51:05 -0400 Subject: Re: [PATCH 1/3] soc: qcom: smd: Represent channel layout in structures To: Bjorn Andersson References: <1441071594-15941-1-git-send-email-sboyd@codeaurora.org> <1441071594-15941-2-git-send-email-sboyd@codeaurora.org> <20150901045502.GB13472@usrtlx11787.corpusers.net> Cc: Andy Gross , "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" From: Stephen Boyd Message-ID: <55E5E586.3060905@codeaurora.org> Date: Tue, 1 Sep 2015 10:51:02 -0700 User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <20150901045502.GB13472@usrtlx11787.corpusers.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/31/2015 09:55 PM, Bjorn Andersson wrote: > On Mon 31 Aug 18:39 PDT 2015, Stephen Boyd wrote: > >> The rx and tx channel info are laid out in memory next to each >> other, and there are two types of channel info structures, byte >> based and word based. We have 4 pointers to these info >> structures, when we really only need two to point to the >> different types of structures. Encapsulate the byte based and word >> based tx/rx structures in a "full channel" structure that >> describes the layout of memory and reduces the number of pointers >> in the smd channel structure by two. >> > Saving the extra pointer doesn't feel like worth the change, but > representing the pair of info structs as one sounds like a reasonable > cleanup. Agreed. > > Reviewed-by: Bjorn Andersson >> Signed-off-by: Stephen Boyd >> --- >> drivers/soc/qcom/smd.c | 61 +++++++++++++++++++++++++++----------------------- >> 1 file changed, 33 insertions(+), 28 deletions(-) >> >> diff --git a/drivers/soc/qcom/smd.c b/drivers/soc/qcom/smd.c >> index edd9d9a37238..c16547b85e05 100644 >> --- a/drivers/soc/qcom/smd.c >> +++ b/drivers/soc/qcom/smd.c >> @@ -65,7 +65,9 @@ >> */ >> >> struct smd_channel_info; >> +struct smd_full_channel_info; > I would have called this "smd_channel_info_pair"... Sure I'll make the change and add your Reviewed-by. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 From: sboyd@codeaurora.org (Stephen Boyd) Date: Tue, 1 Sep 2015 10:51:02 -0700 Subject: [PATCH 1/3] soc: qcom: smd: Represent channel layout in structures In-Reply-To: <20150901045502.GB13472@usrtlx11787.corpusers.net> References: <1441071594-15941-1-git-send-email-sboyd@codeaurora.org> <1441071594-15941-2-git-send-email-sboyd@codeaurora.org> <20150901045502.GB13472@usrtlx11787.corpusers.net> Message-ID: <55E5E586.3060905@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 08/31/2015 09:55 PM, Bjorn Andersson wrote: > On Mon 31 Aug 18:39 PDT 2015, Stephen Boyd wrote: > >> The rx and tx channel info are laid out in memory next to each >> other, and there are two types of channel info structures, byte >> based and word based. We have 4 pointers to these info >> structures, when we really only need two to point to the >> different types of structures. Encapsulate the byte based and word >> based tx/rx structures in a "full channel" structure that >> describes the layout of memory and reduces the number of pointers >> in the smd channel structure by two. >> > Saving the extra pointer doesn't feel like worth the change, but > representing the pair of info structs as one sounds like a reasonable > cleanup. Agreed. > > Reviewed-by: Bjorn Andersson >> Signed-off-by: Stephen Boyd >> --- >> drivers/soc/qcom/smd.c | 61 +++++++++++++++++++++++++++----------------------- >> 1 file changed, 33 insertions(+), 28 deletions(-) >> >> diff --git a/drivers/soc/qcom/smd.c b/drivers/soc/qcom/smd.c >> index edd9d9a37238..c16547b85e05 100644 >> --- a/drivers/soc/qcom/smd.c >> +++ b/drivers/soc/qcom/smd.c >> @@ -65,7 +65,9 @@ >> */ >> >> struct smd_channel_info; >> +struct smd_full_channel_info; > I would have called this "smd_channel_info_pair"... Sure I'll make the change and add your Reviewed-by. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project