From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752039AbbIBBrC (ORCPT ); Tue, 1 Sep 2015 21:47:02 -0400 Received: from lucky1.263xmail.com ([211.157.147.132]:60612 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750717AbbIBBq7 (ORCPT ); Tue, 1 Sep 2015 21:46:59 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: s.infradead.org@null.null X-SENDER-IP: 173.239.41.18 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 1 Message-ID: <55E654F4.4000306@rock-chips.com> Date: Wed, 02 Sep 2015 09:46:28 +0800 From: Yakir Yang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Heiko Stuebner CC: Thierry Reding , Jingoo Han , Inki Dae , joe@perches.com, Kukjin Kim , Krzysztof Kozlowski , Mark Yao , Russell King , djkurtz@chromium.com, dianders@chromium.com, seanpaul@chromium.com, ajaynumb@gmail.com, Andrzej Hajda , Kyungmin Park , David Airlie , Gustavo Padovan , Andy Yan , Kumar Gala , Ian Campbell , Rob Herring , Pawel Moll , Kishon Vijay Abraham I , architt@codeaurora.org, robherring2@gmail.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@list.NULL.NULL, s.infradead.org@NULL.NULL Subject: Re: [PATCH v4 10/16] phy: Add driver for rockchip Display Port PHY References: <1441086371-24838-1-git-send-email-ykk@rock-chips.com> <1441087455-25533-1-git-send-email-ykk@rock-chips.com> <5077044.NGUl9gjQon@phil> <3270549.qIHk1CAA0Y@phil> In-Reply-To: <3270549.qIHk1CAA0Y@phil> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Heiko, 在 09/02/2015 04:58 AM, Heiko Stuebner 写道: > Hi Yakir, > > small nit more below > > Am Dienstag, 1. September 2015, 18:51:16 schrieb Heiko Stuebner: >> Am Dienstag, 1. September 2015, 14:04:15 schrieb Yakir Yang: >>> +- clocks: from common clock binding: handle to dp clock. >>> + of memory mapped region. >>> +- clock-names: from common clock binding: >>> + Required elements: "sclk_dp" "sclk_dp_24m" >>> + >>> +- rockchip,grf: this soc should set GRF regs, so need get grf here. >>> +- #phy-cells : from the generic PHY bindings, must be 0; >>> + >>> +Example: >>> + >>> +edp_phy: phy@ff770274 { >> edp_phy: edp-phy { >> >>> + compatilble = "rockchip,rk3288-dp-phy"; > typo: compatible Aha, thanks. - Yakir > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yakir Yang Subject: Re: [PATCH v4 10/16] phy: Add driver for rockchip Display Port PHY Date: Wed, 02 Sep 2015 09:46:28 +0800 Message-ID: <55E654F4.4000306@rock-chips.com> References: <1441086371-24838-1-git-send-email-ykk@rock-chips.com> <1441087455-25533-1-git-send-email-ykk@rock-chips.com> <5077044.NGUl9gjQon@phil> <3270549.qIHk1CAA0Y@phil> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <3270549.qIHk1CAA0Y@phil> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Heiko Stuebner Cc: Thierry Reding , Jingoo Han , Inki Dae , joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org, Kukjin Kim , Krzysztof Kozlowski , Mark Yao , Russell King , djkurtz-F7+t8E8rja9Wk0Htik3J/w@public.gmane.org, dianders-F7+t8E8rja9Wk0Htik3J/w@public.gmane.org, seanpaul-F7+t8E8rja9Wk0Htik3J/w@public.gmane.org, ajaynumb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Andrzej Hajda , Kyungmin Park , David Airlie , Gustavo Padovan , Andy Yan , Kumar Gala , Ian Campbell , Rob Herring , Pawel Moll , Kishon Vijay Abraham I , architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel List-Id: devicetree@vger.kernel.org Hi Heiko, =E5=9C=A8 09/02/2015 04:58 AM, Heiko Stuebner =E5=86=99=E9=81=93: > Hi Yakir, > > small nit more below > > Am Dienstag, 1. September 2015, 18:51:16 schrieb Heiko Stuebner: >> Am Dienstag, 1. September 2015, 14:04:15 schrieb Yakir Yang: >>> +- clocks: from common clock binding: handle to dp clock. >>> + of memory mapped region. >>> +- clock-names: from common clock binding: >>> + Required elements: "sclk_dp" "sclk_dp_24m" >>> + >>> +- rockchip,grf: this soc should set GRF regs, so need get grf here= =2E >>> +- #phy-cells : from the generic PHY bindings, must be 0; >>> + >>> +Example: >>> + >>> +edp_phy: phy@ff770274 { >> edp_phy: edp-phy { >> >>> + compatilble =3D "rockchip,rk3288-dp-phy"; > typo: compatible Aha, thanks. - Yakir > > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html