From: "Jan Beulich" <JBeulich@suse.com>
To: StefanoStabellini <stefano.stabellini@eu.citrix.com>
Cc: andrew.cooper3@citrix.com, Ian.Campbell@citrix.com,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3 1/2] xen: move perform_gunzip to common
Date: Wed, 02 Sep 2015 07:57:27 -0600 [thread overview]
Message-ID: <55E71C67020000780009F080@prv-mh.provo.novell.com> (raw)
In-Reply-To: <1441193587-5209-1-git-send-email-stefano.stabellini@eu.citrix.com>
>>> On 02.09.15 at 13:33, <stefano.stabellini@eu.citrix.com> wrote:
> The current gunzip code to decompress the Dom0 kernel is implemented in
> inflate.c which is included by bzimage.c.
>
> I am looking to doing the same on ARM64 but there is quite a bit of
> boilerplate definitions that I would need to import in order for
> inflate.c to work correctly.
>
> Instead of copying/pasting the code from x86/bzimage.c, move those
> definitions to a new common file, gunzip.c. Export only perform_gunzip
> and gzip_check. Leave output_length where it is.
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
provided ...
> --- a/xen/common/Makefile
> +++ b/xen/common/Makefile
> @@ -55,6 +55,7 @@ obj-y += vmap.o
> obj-y += vsprintf.o
> obj-y += wait.o
> obj-y += xmalloc_tlsf.o
> +obj-bin-y += gunzip.init.o
... this gets moved to its alphabetically correct place.
Jan
next prev parent reply other threads:[~2015-09-02 13:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 11:30 [PATCH v3 0/2] support gzipped kernels on arm Stefano Stabellini
2015-09-02 11:33 ` [PATCH v3 1/2] xen: move perform_gunzip to common Stefano Stabellini
2015-09-02 13:57 ` Jan Beulich [this message]
2015-09-02 11:33 ` [PATCH v3 2/2] xen/arm: support gzip compressed kernels Stefano Stabellini
2015-09-03 11:39 ` Julien Grall
2015-09-03 12:47 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E71C67020000780009F080@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=Ian.Campbell@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.