From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754865AbbICABd (ORCPT ); Wed, 2 Sep 2015 20:01:33 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:37760 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750805AbbICABb (ORCPT ); Wed, 2 Sep 2015 20:01:31 -0400 X-AuditID: cbfec7f5-f794b6d000001495-71-55e78dd76a37 Subject: Re: [PATCH v4 07/16] ARM: dts: exynos/dp: remove some properties that deprecated by analogix_dp driver To: Yakir Yang , Heiko Stuebner , Thierry Reding , Jingoo Han , Inki Dae , joe@perches.com, Kukjin Kim , Mark Yao References: <1441086371-24838-1-git-send-email-ykk@rock-chips.com> <1441087272-25353-1-git-send-email-ykk@rock-chips.com> Cc: Russell King , djkurtz@chromium.com, dianders@chromium.com, seanpaul@chromium.com, ajaynumb@gmail.com, Andrzej Hajda , Kyungmin Park , David Airlie , Gustavo Padovan , Andy Yan , Kumar Gala , Ian Campbell , Rob Herring , Pawel Moll , Kishon Vijay Abraham I , architt@codeaurora.org, robherring2@gmail.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <55E78DCF.1060308@samsung.com> Date: Thu, 03 Sep 2015 09:01:19 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-version: 1.0 In-reply-to: <1441087272-25353-1-git-send-email-ykk@rock-chips.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0iTYRTHed7L876aq9dl9ZBRMStIamYXeLCS6PoEBX5IkqDLyjeVdNqm khW5vICXLe3elmmWYi674BZeQqthSmprYioWNtFs1ryEzHWji3NEffudc37n/L8cnpbq2fl8 nDJZVCkV8TLoy7T9aula2aNzRK6adAfiN/etLNZZX1D44UgpjQte9QKckTPK4pKmqcGz4SyI c74UUPj15DjEBSOlLJ64m83h3wNOFls/VQJ8wV7I4DsuPYev2wcZ7BwOxQWDThrbhrQQv8wY 4XD1YDeLO+uLIJ7o/03ja68aKVx76SmFC6/eY7Dp80eIsxuaOPzF7Ya447adw29/zMRWzUVu 02JSVVwFSFamFhJHvZMined0FPnp6GFInaGPI5UVLkiqjbmQ1Lj7WWLPb6GIqSyd6DLHIHEZ u2ny0/CEIefMRkBquovpCOk+3w3RYnxcqqgKCT/kG2u/ksUl5a044bKYgQbcWZIHfHgkrEVt Tjvw8lxke/cA5gFfXiqUA6Q12zhv4QLo+fNM2mPNFo6jJqN5mgOEHAo97tnhYalwCpmH3LRn gRb0EH272zN9FgprkKmiDHojFiJd/gXGwxIhGOkG9KyHGWEpamlwTPMcIQq1vhyFXscffb34 btr3EbagrvGhKeanAuTI3hHsadPCImSqGqULgb/hvw3DP8vwn3UT0EYwR0w5kqQ+HJOwWq5W JKhTlDHyI4kJ1cD7MJO1oLw5zAIEHsj8JBrFh0gpq0hVpyVYAOJpWYDkabojUiqJVqSdFFWJ B1Up8aLaAgJ5RjZPoq8f3yMVYhTJ4jFRTBJVf6cU7zNfA063nl1/cDtztCN1NeUXcav80cKJ XJKx8dP2hs3v8ZiteJl7537T4OWU1trklpn7te5gf+vw3qBVr2GfzJi+ta+SMvQG1YWfslct 3xbSuCMwcbfyRj/b1Ww5oOzVBhStO7Nomyarzhala7dlLw/b9cbUnj0LzCg5/13YGSavWZCX L2PUsYrQYFqlVvwBlkMhQCwDAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01.09.2015 15:01, Yakir Yang wrote: > After exynos_dp have been splited the common IP code into analogix_dp driver, s/splited/split/ > the analogix_dp driver have deprecated some samsung platform properties which s/samsung/Samsung/ > could be dynamic parsed from EDID/MODE/DPCD message, so this is an update for s/dynamic/dynamically/ > exynos DTS file for dp-controller. /exynos/Exynos/ > > Beside analogix_dp have provide the backward compatibility, so there are no > bisectability break that make this change in a separate patch. It took me some time to figure out the meaning of this sentence... Did you want to say that backward compatibility is fully preserved? You are removing samsung,dynamic-range and samsung,ycbcr-coeff. I would assume that now: 1. on all these board these values would be parsed from EDID/MODE/DPCD message? 2. everything would work as previously? Am I understanding it correctly? The patch itself looks good. Best regards, Krzysztof > > Signed-off-by: Yakir Yang > --- > Changes in v4: > - Take Krzysztof suggest, separate all DTS changes to a separate patch. > > Changes in v3: None > Changes in v2: None > > arch/arm/boot/dts/exynos5250-arndale.dts | 2 -- > arch/arm/boot/dts/exynos5250-smdk5250.dts | 2 -- > arch/arm/boot/dts/exynos5250-snow.dts | 4 +--- > arch/arm/boot/dts/exynos5250-spring.dts | 4 +--- > arch/arm/boot/dts/exynos5420-peach-pit.dts | 4 +--- > arch/arm/boot/dts/exynos5420-smdk5420.dts | 2 -- > arch/arm/boot/dts/exynos5800-peach-pi.dts | 4 +--- > 7 files changed, 4 insertions(+), 18 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts > index db3f65f..4636862 100644 > --- a/arch/arm/boot/dts/exynos5250-arndale.dts > +++ b/arch/arm/boot/dts/exynos5250-arndale.dts > @@ -124,8 +124,6 @@ > &dp { > status = "okay"; > samsung,color-space = <0>; > - samsung,dynamic-range = <0>; > - samsung,ycbcr-coeff = <0>; > samsung,color-depth = <1>; > samsung,link-rate = <0x0a>; > samsung,lane-count = <4>; > diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts > index c625e71..cd424d6 100644 > --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts > +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts > @@ -80,8 +80,6 @@ > > &dp { > samsung,color-space = <0>; > - samsung,dynamic-range = <0>; > - samsung,ycbcr-coeff = <0>; > samsung,color-depth = <1>; > samsung,link-rate = <0x0a>; > samsung,lane-count = <4>; > diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts > index 0720caa..242b621 100644 > --- a/arch/arm/boot/dts/exynos5250-snow.dts > +++ b/arch/arm/boot/dts/exynos5250-snow.dts > @@ -244,12 +244,10 @@ > pinctrl-names = "default"; > pinctrl-0 = <&dp_hpd>; > samsung,color-space = <0>; > - samsung,dynamic-range = <0>; > - samsung,ycbcr-coeff = <0>; > samsung,color-depth = <1>; > samsung,link-rate = <0x0a>; > samsung,lane-count = <2>; > - samsung,hpd-gpio = <&gpx0 7 GPIO_ACTIVE_HIGH>; > + hpd-gpios = <&gpx0 7 GPIO_ACTIVE_HIGH>; > > ports { > port@0 { > diff --git a/arch/arm/boot/dts/exynos5250-spring.dts b/arch/arm/boot/dts/exynos5250-spring.dts > index c1edd6d..91881d7 100644 > --- a/arch/arm/boot/dts/exynos5250-spring.dts > +++ b/arch/arm/boot/dts/exynos5250-spring.dts > @@ -74,12 +74,10 @@ > pinctrl-names = "default"; > pinctrl-0 = <&dp_hpd_gpio>; > samsung,color-space = <0>; > - samsung,dynamic-range = <0>; > - samsung,ycbcr-coeff = <0>; > samsung,color-depth = <1>; > samsung,link-rate = <0x0a>; > samsung,lane-count = <1>; > - samsung,hpd-gpio = <&gpc3 0 GPIO_ACTIVE_HIGH>; > + hpd-gpios = <&gpc3 0 GPIO_ACTIVE_HIGH>; > }; > > &ehci { > diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts > index 8f4d76c..7433683 100644 > --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts > +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts > @@ -148,12 +148,10 @@ > pinctrl-names = "default"; > pinctrl-0 = <&dp_hpd_gpio>; > samsung,color-space = <0>; > - samsung,dynamic-range = <0>; > - samsung,ycbcr-coeff = <0>; > samsung,color-depth = <1>; > samsung,link-rate = <0x06>; > samsung,lane-count = <2>; > - samsung,hpd-gpio = <&gpx2 6 0>; > + hpd-gpio = <&gpx2 6 0>; > > ports { > port@0 { > diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts > index 98871f9..b3df3c1 100644 > --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts > +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts > @@ -92,8 +92,6 @@ > pinctrl-names = "default"; > pinctrl-0 = <&dp_hpd>; > samsung,color-space = <0>; > - samsung,dynamic-range = <0>; > - samsung,ycbcr-coeff = <0>; > samsung,color-depth = <1>; > samsung,link-rate = <0x0a>; > samsung,lane-count = <4>; > diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts > index 7d5b386..b89bff5 100644 > --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts > +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts > @@ -142,12 +142,10 @@ > pinctrl-names = "default"; > pinctrl-0 = <&dp_hpd_gpio>; > samsung,color-space = <0>; > - samsung,dynamic-range = <0>; > - samsung,ycbcr-coeff = <0>; > samsung,color-depth = <1>; > samsung,link-rate = <0x0a>; > samsung,lane-count = <2>; > - samsung,hpd-gpio = <&gpx2 6 0>; > + hpd-gpios = <&gpx2 6 0>; > panel = <&panel>; > }; > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: k.kozlowski@samsung.com (Krzysztof Kozlowski) Date: Thu, 03 Sep 2015 09:01:19 +0900 Subject: [PATCH v4 07/16] ARM: dts: exynos/dp: remove some properties that deprecated by analogix_dp driver In-Reply-To: <1441087272-25353-1-git-send-email-ykk@rock-chips.com> References: <1441086371-24838-1-git-send-email-ykk@rock-chips.com> <1441087272-25353-1-git-send-email-ykk@rock-chips.com> Message-ID: <55E78DCF.1060308@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 01.09.2015 15:01, Yakir Yang wrote: > After exynos_dp have been splited the common IP code into analogix_dp driver, s/splited/split/ > the analogix_dp driver have deprecated some samsung platform properties which s/samsung/Samsung/ > could be dynamic parsed from EDID/MODE/DPCD message, so this is an update for s/dynamic/dynamically/ > exynos DTS file for dp-controller. /exynos/Exynos/ > > Beside analogix_dp have provide the backward compatibility, so there are no > bisectability break that make this change in a separate patch. It took me some time to figure out the meaning of this sentence... Did you want to say that backward compatibility is fully preserved? You are removing samsung,dynamic-range and samsung,ycbcr-coeff. I would assume that now: 1. on all these board these values would be parsed from EDID/MODE/DPCD message? 2. everything would work as previously? Am I understanding it correctly? The patch itself looks good. Best regards, Krzysztof > > Signed-off-by: Yakir Yang > --- > Changes in v4: > - Take Krzysztof suggest, separate all DTS changes to a separate patch. > > Changes in v3: None > Changes in v2: None > > arch/arm/boot/dts/exynos5250-arndale.dts | 2 -- > arch/arm/boot/dts/exynos5250-smdk5250.dts | 2 -- > arch/arm/boot/dts/exynos5250-snow.dts | 4 +--- > arch/arm/boot/dts/exynos5250-spring.dts | 4 +--- > arch/arm/boot/dts/exynos5420-peach-pit.dts | 4 +--- > arch/arm/boot/dts/exynos5420-smdk5420.dts | 2 -- > arch/arm/boot/dts/exynos5800-peach-pi.dts | 4 +--- > 7 files changed, 4 insertions(+), 18 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts > index db3f65f..4636862 100644 > --- a/arch/arm/boot/dts/exynos5250-arndale.dts > +++ b/arch/arm/boot/dts/exynos5250-arndale.dts > @@ -124,8 +124,6 @@ > &dp { > status = "okay"; > samsung,color-space = <0>; > - samsung,dynamic-range = <0>; > - samsung,ycbcr-coeff = <0>; > samsung,color-depth = <1>; > samsung,link-rate = <0x0a>; > samsung,lane-count = <4>; > diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts > index c625e71..cd424d6 100644 > --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts > +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts > @@ -80,8 +80,6 @@ > > &dp { > samsung,color-space = <0>; > - samsung,dynamic-range = <0>; > - samsung,ycbcr-coeff = <0>; > samsung,color-depth = <1>; > samsung,link-rate = <0x0a>; > samsung,lane-count = <4>; > diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts > index 0720caa..242b621 100644 > --- a/arch/arm/boot/dts/exynos5250-snow.dts > +++ b/arch/arm/boot/dts/exynos5250-snow.dts > @@ -244,12 +244,10 @@ > pinctrl-names = "default"; > pinctrl-0 = <&dp_hpd>; > samsung,color-space = <0>; > - samsung,dynamic-range = <0>; > - samsung,ycbcr-coeff = <0>; > samsung,color-depth = <1>; > samsung,link-rate = <0x0a>; > samsung,lane-count = <2>; > - samsung,hpd-gpio = <&gpx0 7 GPIO_ACTIVE_HIGH>; > + hpd-gpios = <&gpx0 7 GPIO_ACTIVE_HIGH>; > > ports { > port at 0 { > diff --git a/arch/arm/boot/dts/exynos5250-spring.dts b/arch/arm/boot/dts/exynos5250-spring.dts > index c1edd6d..91881d7 100644 > --- a/arch/arm/boot/dts/exynos5250-spring.dts > +++ b/arch/arm/boot/dts/exynos5250-spring.dts > @@ -74,12 +74,10 @@ > pinctrl-names = "default"; > pinctrl-0 = <&dp_hpd_gpio>; > samsung,color-space = <0>; > - samsung,dynamic-range = <0>; > - samsung,ycbcr-coeff = <0>; > samsung,color-depth = <1>; > samsung,link-rate = <0x0a>; > samsung,lane-count = <1>; > - samsung,hpd-gpio = <&gpc3 0 GPIO_ACTIVE_HIGH>; > + hpd-gpios = <&gpc3 0 GPIO_ACTIVE_HIGH>; > }; > > &ehci { > diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts > index 8f4d76c..7433683 100644 > --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts > +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts > @@ -148,12 +148,10 @@ > pinctrl-names = "default"; > pinctrl-0 = <&dp_hpd_gpio>; > samsung,color-space = <0>; > - samsung,dynamic-range = <0>; > - samsung,ycbcr-coeff = <0>; > samsung,color-depth = <1>; > samsung,link-rate = <0x06>; > samsung,lane-count = <2>; > - samsung,hpd-gpio = <&gpx2 6 0>; > + hpd-gpio = <&gpx2 6 0>; > > ports { > port at 0 { > diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts > index 98871f9..b3df3c1 100644 > --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts > +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts > @@ -92,8 +92,6 @@ > pinctrl-names = "default"; > pinctrl-0 = <&dp_hpd>; > samsung,color-space = <0>; > - samsung,dynamic-range = <0>; > - samsung,ycbcr-coeff = <0>; > samsung,color-depth = <1>; > samsung,link-rate = <0x0a>; > samsung,lane-count = <4>; > diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts > index 7d5b386..b89bff5 100644 > --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts > +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts > @@ -142,12 +142,10 @@ > pinctrl-names = "default"; > pinctrl-0 = <&dp_hpd_gpio>; > samsung,color-space = <0>; > - samsung,dynamic-range = <0>; > - samsung,ycbcr-coeff = <0>; > samsung,color-depth = <1>; > samsung,link-rate = <0x0a>; > samsung,lane-count = <2>; > - samsung,hpd-gpio = <&gpx2 6 0>; > + hpd-gpios = <&gpx2 6 0>; > panel = <&panel>; > }; > >