From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932910AbbIDAgc (ORCPT ); Thu, 3 Sep 2015 20:36:32 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:29167 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753013AbbIDAg3 (ORCPT ); Thu, 3 Sep 2015 20:36:29 -0400 X-AuditID: cbfec7f5-f794b6d000001495-23-55e8e78add73 Subject: Re: [PATCH v4 11/16] drm: bridge: analogix/dp: add platform device type support To: Yakir Yang , Heiko Stuebner , Thierry Reding , Jingoo Han , Inki Dae , joe@perches.com, Kukjin Kim , Mark Yao References: <1441086371-24838-1-git-send-email-ykk@rock-chips.com> <1441087620-25586-1-git-send-email-ykk@rock-chips.com> Cc: Russell King , djkurtz@chromium.com, dianders@chromium.com, seanpaul@chromium.com, ajaynumb@gmail.com, Andrzej Hajda , Kyungmin Park , David Airlie , Gustavo Padovan , Andy Yan , Kumar Gala , Ian Campbell , Rob Herring , Pawel Moll , Kishon Vijay Abraham I , architt@codeaurora.org, robherring2@gmail.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <55E8E77C.4020305@samsung.com> Date: Fri, 04 Sep 2015 09:36:12 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-version: 1.0 In-reply-to: <1441087620-25586-1-git-send-email-ykk@rock-chips.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02SSUxTURSGc99w+yBWHmW6AUXTxA1GFMfrEIPR6I0rF6LCRou8gEgLaalx SBRllKkEiEBRwAgyVSEUFTCgApGAUECmoGAbqylaigYBMQhIaYzu/nP+7z//5nC0pID15i4o YgWlQhYlhc7Mm6WOwS2plomgba+KxfjdYwOLMwydFK6dvE9jTe8owLdSbCwubl8xXk0kQJzy U0PhwdlvEGsm77N4ujpRhJc/Wlls+FoJcLYxi8EVMwUiXGg0M9g6EYA1ZiuN+z6nQ9xza1KE 68zDLB5ougvxtGmZxvm9LRRuyH1J4ay8RwzWf/8CcWJzuwj/nJuDuP+BUYTfL6zFhrgcUeBG oivSAZIQnw6JpclKkYHMDIosWkYY0qgdF5HK8hlI6qpuQ/JszsQSY1oHRfSlN0hG/BQkM1XD NFnUvmBIZn0VIM+Gi+gTkhDnA2FC1IVLgnLrwXPOEeMLeTDG4HXZoimDcSDfLRU4cYjfiSxz nZRDe6K+DzUwFThzEr4MIHPbc9oxzADUOPKetlNufAgyJ9eK7NqdT6HQ85Fjdi3hr6Hyz08Z e4DmCyD6VT0C7AbkdyB9eSl0VPiijLRsxq7FvB8aa8ldrWb4TahmeX71qAd/BnX12KCDcUXz OR9WeSf+MJrSja4w3EqBPzL2+9nXNL8B6XU2Ogu4av9LaP9R2v+oEkBXAQ9BfT5GFRou3+6v kslVakW4//loeR1wPMxsAyh7va8V8ByQrhFnFVqCJKzskuqKvBUgjpa6iz1eTgRJxGGyK1cF ZfRZpTpKULUCH46ReokLmr6dlPDhsljhoiDECMq/LsU5eceBwFhl7xi9R39C8jCpLLQi+1O0 NqnB2CV3MZG0/PKIyqXmm93H2Sldcoll3ZG36r2nxpvHxE974e5tadOXD7X17w/WKn7Y+q+H m4Zspzt8E5941he615Qo1J7dKPKTz51dRwOLXJ6cymtRBXM+m2W/3e6l1oUMRBZ73TQPmYjf eimjipAF+NFKlewPlnoxHiwDAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01.09.2015 15:07, Yakir Yang wrote: Empty commit message. Please explain here why you want to add platform device type support. Actually the title is confusing. You are not adding support for platform device types but rather adding a field containing type of device. > Signed-off-by: Yakir Yang > --- > Changes in v4: None > Changes in v3: None > Changes in v2: > - Add GNU license v2 declared and samsung copyright > > drivers/gpu/drm/exynos/exynos_dp.c | 1 + > drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 1 + > include/drm/bridge/analogix_dp.h | 16 ++++++++++++++++ > 3 files changed, 18 insertions(+) > > diff --git a/drivers/gpu/drm/exynos/exynos_dp.c b/drivers/gpu/drm/exynos/exynos_dp.c > index 6060d2c..40ef727 100644 > --- a/drivers/gpu/drm/exynos/exynos_dp.c > +++ b/drivers/gpu/drm/exynos/exynos_dp.c > @@ -224,6 +224,7 @@ static int exynos_dp_bind(struct device *dev, struct device *master, void *data) > dp->dev = dev; > dp->drm_dev = drm_dev; > > + dp->plat_data.dev_type = EXYNOS_DP; > dp->plat_data.power_on = exynos_dp_poweron; > dp->plat_data.power_off = exynos_dp_poweroff; > dp->plat_data.get_modes = exynos_dp_get_modes; > diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > index efea045..4934271 100644 > --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > @@ -293,6 +293,7 @@ static int rockchip_dp_bind(struct device *dev, struct device *master, > return ret; > } > > + dp->plat_data.dev_type = RK3288_DP; > dp->plat_data.attach = NULL; > dp->plat_data.get_modes = NULL; > dp->plat_data.power_on = rockchip_dp_poweron; > diff --git a/include/drm/bridge/analogix_dp.h b/include/drm/bridge/analogix_dp.h > index 8b4ffad..7209a64 100644 > --- a/include/drm/bridge/analogix_dp.h > +++ b/include/drm/bridge/analogix_dp.h > @@ -1,9 +1,25 @@ > +/* > + * Analogix Core DP (Display Port) interface driver. > + * > + * Copyright (C) 2012 Samsung Electronics Co., Ltd. > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms of the GNU General Public License as published by the > + * Free Software Foundation; either version 2 of the License, or (at your > + * option) any later version. > + */ Two questions: 1. Why this change is here? I would rather expect it at patch 3/16 when you created this file... That is the usual time for adding copyrights. 2. Does this file contains previous Samsung work? Best regards, Krzysztof > #ifndef _ANALOGIX_DP_H_ > #define _ANALOGIX_DP_H_ > > #include > > +enum analogix_dp_devtype { > + EXYNOS_DP, > + RK3288_DP, > +}; > + > struct analogix_dp_plat_data { > + enum analogix_dp_devtype dev_type; > struct drm_panel *panel; > > int (*power_on)(struct analogix_dp_plat_data *); > From mboxrd@z Thu Jan 1 00:00:00 1970 From: k.kozlowski@samsung.com (Krzysztof Kozlowski) Date: Fri, 04 Sep 2015 09:36:12 +0900 Subject: [PATCH v4 11/16] drm: bridge: analogix/dp: add platform device type support In-Reply-To: <1441087620-25586-1-git-send-email-ykk@rock-chips.com> References: <1441086371-24838-1-git-send-email-ykk@rock-chips.com> <1441087620-25586-1-git-send-email-ykk@rock-chips.com> Message-ID: <55E8E77C.4020305@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 01.09.2015 15:07, Yakir Yang wrote: Empty commit message. Please explain here why you want to add platform device type support. Actually the title is confusing. You are not adding support for platform device types but rather adding a field containing type of device. > Signed-off-by: Yakir Yang > --- > Changes in v4: None > Changes in v3: None > Changes in v2: > - Add GNU license v2 declared and samsung copyright > > drivers/gpu/drm/exynos/exynos_dp.c | 1 + > drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 1 + > include/drm/bridge/analogix_dp.h | 16 ++++++++++++++++ > 3 files changed, 18 insertions(+) > > diff --git a/drivers/gpu/drm/exynos/exynos_dp.c b/drivers/gpu/drm/exynos/exynos_dp.c > index 6060d2c..40ef727 100644 > --- a/drivers/gpu/drm/exynos/exynos_dp.c > +++ b/drivers/gpu/drm/exynos/exynos_dp.c > @@ -224,6 +224,7 @@ static int exynos_dp_bind(struct device *dev, struct device *master, void *data) > dp->dev = dev; > dp->drm_dev = drm_dev; > > + dp->plat_data.dev_type = EXYNOS_DP; > dp->plat_data.power_on = exynos_dp_poweron; > dp->plat_data.power_off = exynos_dp_poweroff; > dp->plat_data.get_modes = exynos_dp_get_modes; > diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > index efea045..4934271 100644 > --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > @@ -293,6 +293,7 @@ static int rockchip_dp_bind(struct device *dev, struct device *master, > return ret; > } > > + dp->plat_data.dev_type = RK3288_DP; > dp->plat_data.attach = NULL; > dp->plat_data.get_modes = NULL; > dp->plat_data.power_on = rockchip_dp_poweron; > diff --git a/include/drm/bridge/analogix_dp.h b/include/drm/bridge/analogix_dp.h > index 8b4ffad..7209a64 100644 > --- a/include/drm/bridge/analogix_dp.h > +++ b/include/drm/bridge/analogix_dp.h > @@ -1,9 +1,25 @@ > +/* > + * Analogix Core DP (Display Port) interface driver. > + * > + * Copyright (C) 2012 Samsung Electronics Co., Ltd. > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms of the GNU General Public License as published by the > + * Free Software Foundation; either version 2 of the License, or (at your > + * option) any later version. > + */ Two questions: 1. Why this change is here? I would rather expect it at patch 3/16 when you created this file... That is the usual time for adding copyrights. 2. Does this file contains previous Samsung work? Best regards, Krzysztof > #ifndef _ANALOGIX_DP_H_ > #define _ANALOGIX_DP_H_ > > #include > > +enum analogix_dp_devtype { > + EXYNOS_DP, > + RK3288_DP, > +}; > + > struct analogix_dp_plat_data { > + enum analogix_dp_devtype dev_type; > struct drm_panel *panel; > > int (*power_on)(struct analogix_dp_plat_data *); >