From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42677) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXmcR-0006AR-6A for qemu-devel@nongnu.org; Fri, 04 Sep 2015 04:45:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZXmcN-0006ze-5L for qemu-devel@nongnu.org; Fri, 04 Sep 2015 04:45:11 -0400 References: <1438838837-28504-1-git-send-email-bharata@linux.vnet.ibm.com> <1438838837-28504-10-git-send-email-bharata@linux.vnet.ibm.com> <20150904070105.GB6537@voom.redhat.com> From: Thomas Huth Message-ID: <55E95A09.8030700@redhat.com> Date: Fri, 4 Sep 2015 10:44:57 +0200 MIME-Version: 1.0 In-Reply-To: <20150904070105.GB6537@voom.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hK5q2INsegbdoHTtQQPnjG6h83NTeHGQ2" Subject: Re: [Qemu-devel] [RFC PATCH v4 09/11] spapr: Support topologies with unfilled cores List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson , Bharata B Rao Cc: agraf@suse.de, aik@ozlabs.ru, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, qemu-ppc@nongnu.org, tyreld@linux.vnet.ibm.com, imammedo@redhat.com, nfont@linux.vnet.ibm.com, afaerber@suse.de This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hK5q2INsegbdoHTtQQPnjG6h83NTeHGQ2 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/09/15 09:01, David Gibson wrote: > On Thu, Aug 06, 2015 at 10:57:15AM +0530, Bharata B Rao wrote: >> QEMU currently supports CPU topologies where there can be cores >> which are not completely filled with all the threads as per the >> specifed SMT mode. >> >> Restore support for such topologies (Eg -smp 15,cores=3D4,threads=3D4)= >> The last core will always have the deficit even when -device options a= re >> used to cold-plug the cores. >> >> Signed-off-by: Bharata B Rao >=20 > Is there a reason to support these silly toplogies, or should we just > error out if this is specified? FYI, I've recently submitted a patch that tries to catch such illegal SMP configurations and simply errors out in that case: http://lists.nongnu.org/archive/html/qemu-devel/2015-07/msg04549.html It's not upstream yet, but already in Eduardo's x86 branch. I think this will reject the bad topology from your example, too. Thomas --hK5q2INsegbdoHTtQQPnjG6h83NTeHGQ2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJV6VoJAAoJEC7Z13T+cC21GigP/Ao5BtUb3qt+rqElWPR9xV09 9rCcbmcbU+uUgiZhr6za728qFA7Qvjuy7qNDG9+yIHRRR9Qlaq+B00hz3SHN9T8G MgDVnrQv0LUYc/E6MIbKdsn8aCxtAGNCbt0JKZ0ExL6NwviMPztp0/JwVyr/iw+U XGy79Xf8381YYqP0DlwlHhNFFhVcViqlcCOLPngVqfcAKdrttW2e01GE+MhBj2Et Oth+IeayRQx2D1hFIlXgmurb156iUM86HTeqNotSWTypoOGyXwYtkJUf6EXCJAKh 8mRUX0O/XGegGDgPUMD600ADN5PMPqO67CZOrg6m00bL6cN6nYSbT6Q2t7W58/bO UqtACbNBJuZlD2YuFqwzWcJJ/KORMkwr1+aT/7hsOSJgXwvX9rdi1nJTo/0BbVGZ maM3ZEC/3gVBjEnmpoq43neU/4hV8HbrdvbVYi5RK3RrIKJCU6AkAGBqGmYNPBTz aQxiAdUGsq9KarRI5t6XAN09dk6qYeSJSYeRf7XH2x67/IATnlr8T2KfAYMTktJ+ 4o5XFj/2jwGa/82CDS7Svf4qjECqqXqpVaN0wkeq6JaBGW3iEXhuVecBFLzM++PW iQkAswGNxCYwPQdh8Cl+hSJ0XvovsXdH7UgZDHjMcVSUjCMKxRxJ3UPrTfr3DrW8 3UiYeWz98111ro7drl6M =sF+J -----END PGP SIGNATURE----- --hK5q2INsegbdoHTtQQPnjG6h83NTeHGQ2--