All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>, <linux-kernel@vger.kernel.org>
Cc: David Vrabel <david.vrabel@citrix.com>,
	<xen-devel@lists.xenproject.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [Xen-devel] [PATCH] xen-blkback: free requests on disconnection
Date: Fri, 4 Sep 2015 14:51:10 +0100	[thread overview]
Message-ID: <55E9A1CE.9090905@citrix.com> (raw)
In-Reply-To: <1441361287-41234-1-git-send-email-roger.pau@citrix.com>

Hi Roger,

On 04/09/15 11:08, Roger Pau Monne wrote:
> Request allocation has been moved to connect_ring, which is called every
> time blkback connects to the frontend (this can happen multiple times during
> a blkback instance life cycle). On the other hand, request freeing has not
> been moved, so it's only called when destroying the backend instance. Due to
> this mismatch, blkback can allocate the request pool multiple times, without
> freeing it.
> 
> In order to fix it, move the freeing of requests to xen_blkif_disconnect to
> restore the symmetry between request allocation and freeing.
> 
> Reported-by: Julien Grall <julien.grall@citrix.com>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> Cc: Julien Grall <julien.grall@citrix.com>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Cc: David Vrabel <david.vrabel@citrix.com>
> Cc: xen-devel@lists.xenproject.org

The patch is fixing my problem when using UEFI in the guest. Thank you!

Tested-by: Julien Grall <julien.grall@citrix.com>

Regards,

-- 
Julien Grall

  parent reply	other threads:[~2015-09-04 13:52 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-04 10:08 [PATCH] xen-blkback: free requests on disconnection Roger Pau Monne
2015-09-04 13:51 ` Julien Grall
2015-09-04 13:51 ` Julien Grall [this message]
2015-09-04 17:21   ` [Xen-devel] " Konrad Rzeszutek Wilk
2015-09-04 17:21   ` Konrad Rzeszutek Wilk
2015-09-07  6:07   ` Bob Liu
2015-09-07  6:07   ` [Xen-devel] " Bob Liu
2015-09-07 11:10     ` Julien Grall
2015-09-07 11:35       ` Bob Liu
2015-09-08 10:43         ` Roger Pau Monné
2015-09-08 10:43         ` [Xen-devel] " Roger Pau Monné
2015-09-09 15:02           ` Konrad Rzeszutek Wilk
2015-09-21 23:10             ` Julien Grall
2015-09-25 20:05               ` Konrad Rzeszutek Wilk
2015-09-25 20:05               ` [Xen-devel] " Konrad Rzeszutek Wilk
2015-09-21 23:10             ` Julien Grall
2015-09-09 15:02           ` Konrad Rzeszutek Wilk
2015-09-07 11:35       ` Bob Liu
2015-09-07 11:10     ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55E9A1CE.9090905@citrix.com \
    --to=julien.grall@citrix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roger.pau@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.