From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35997) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYDTG-0004PJ-Hz for qemu-devel@nongnu.org; Sat, 05 Sep 2015 09:25:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZYDTC-0007ZC-Vp for qemu-devel@nongnu.org; Sat, 05 Sep 2015 09:25:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40476) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYDTC-0007Z2-PK for qemu-devel@nongnu.org; Sat, 05 Sep 2015 09:25:26 -0400 References: <878u8mb62t.fsf@blackfin.pond.sub.org> <1441410668-25265-1-git-send-email-eblake@redhat.com> <55EAEBDF.5070704@redhat.com> From: Eric Blake Message-ID: <55EAED45.3010301@redhat.com> Date: Sat, 5 Sep 2015 07:25:25 -0600 MIME-Version: 1.0 In-Reply-To: <55EAEBDF.5070704@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5QvLuWtdXhram24XLOrrASrWer24RKhA1" Subject: Re: [Qemu-devel] [PATCH RFC v4 02.5/32] qapi: Hide internal data members of schema objects. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: armbru@redhat.com, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --5QvLuWtdXhram24XLOrrASrWer24RKhA1 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/05/2015 07:19 AM, Eric Blake wrote: > On 09/04/2015 05:51 PM, Eric Blake wrote: >> We have a few fields that exist mainly to hold information from >> __init__() until check() (matching the fact that parsing is >> two-pass; the first to find type names, the second to associate >> types together while honoring forward references), or which should >> only be used through accessor methods. We should not use these >> fields directly in other files after check() has run, so use the >> python convention of naming these fields with leading underscore >> to mark their internal usage, and to check that no one else was >> using them. >> >> Exception: our crazy handling of simple unions (with a C member >> 'kind' matching the QMP wire 'type') requires peeking through >> the hidden field. This leaky abstraction will be cleaned up in >> a later patch. >> >> Signed-off-by: Eric Blake >> --- >> >> Technically, I wrote this patch after 32; if you decide to rebase >> it into the series, you'll have to split it among 2, 10, 11, and 30. >> Up to you if you want to squash this in during your spin of v5, or >> if you want me to keep it as a separate patch for inclusion after >> your series. >=20 > Oh, and tests/qapi-schema/test-qapi.py is annoying - even when it exits= > non-zero, it does NOT cause a failure in 'make check-qapi-schema'. Rather, it does not leave an obvious stack trace or immediate non-zero status; and 'make check-qapi-schema' only fails as a side effect if later output happens to differ from expectations. I would have had a much easier time chasing the problem if I'd had an obvious python stack trace. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --5QvLuWtdXhram24XLOrrASrWer24RKhA1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV6u1FAAoJEKeha0olJ0NqQbUH/02wkihtjwwVN6LDes5MnEj3 7aTYbWcc17PZugIHsNN++D1FmWeyneL9BhudcQpgEQjuNStSZHK99NMUwLwJMBvm Lm5a7S1aza2xcxY2MhK5GpgwiKSdAm5sRcCFl2fIdT3gLKeVbeiRgCvN47cRyyFI eyM+3R1pOAcbpsVO4iJzXpE+X6CHagu1Pe1aF23AjmeAWrspIgNwWSf5wPpowEZu HsfM1wc0CFKoPFXlJBmZ0Rj8cE1O8/ovRHVgbbQAJz7YaJoWvxRoSSl7OD7z2RO8 5x5zZ0/5ApjqVHPRWwsU24zNak4dQrPNjgbKBexhVHYzzS4tspBuEJl2nXoQzw8= =sI4B -----END PGP SIGNATURE----- --5QvLuWtdXhram24XLOrrASrWer24RKhA1--