From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751378AbbIFBeG (ORCPT ); Sat, 5 Sep 2015 21:34:06 -0400 Received: from lucky1.263xmail.com ([211.157.147.131]:47259 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750756AbbIFBd4 (ORCPT ); Sat, 5 Sep 2015 21:33:56 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <55EB97F9.3010503@rock-chips.com> Date: Sun, 06 Sep 2015 09:33:45 +0800 From: Yakir Yang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Joe Perches CC: Krzysztof Kozlowski , Heiko Stuebner , Thierry Reding , Jingoo Han , Inki Dae , Kukjin Kim , Mark Yao , Russell King , djkurtz@chromium.com, dianders@chromium.com, seanpaul@chromium.com, ajaynumb@gmail.com, Andrzej Hajda , Kyungmin Park , David Airlie , Gustavo Padovan , Andy Yan , Kumar Gala , Ian Campbell , Rob Herring , Pawel Moll , Kishon Vijay Abraham I , architt@codeaurora.org, robherring2@gmail.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 01/16] drm: exynos/dp: fix code style References: <1441086371-24838-1-git-send-email-ykk@rock-chips.com> <1441086399-24889-1-git-send-email-ykk@rock-chips.com> <55E79297.3050203@samsung.com> <55E7D4E4.6070808@rock-chips.com> <55E7D5EB.1060505@samsung.com> <55E7DBA7.90504@rock-chips.com> <1441259878.12163.75.camel@perches.com> In-Reply-To: <1441259878.12163.75.camel@perches.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Joe, 在 09/03/2015 01:57 PM, Joe Perches 写道: > On Thu, 2015-09-03 at 13:33 +0800, Yakir Yang wrote: > [] >>>>>> diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c > [] >>>>>> @@ -155,24 +156,22 @@ static int exynos_dp_read_edid(struct >>>>>> exynos_dp_device *dp) >>>>>> } >>>>>> exynos_dp_read_byte_from_dpcd(dp, DP_TEST_REQUEST, >>>>>> - &test_vector); >>>>>> + &test_vector); >>>>>> if (test_vector & DP_TEST_LINK_EDID_READ) { >>>>>> - exynos_dp_write_byte_to_dpcd(dp, >>>>>> - DP_TEST_EDID_CHECKSUM, >>>>>> + exynos_dp_write_byte_to_dpcd( >>>>>> + dp, DP_TEST_EDID_CHECKSUM, >>>>>> edid[EDID_BLOCK_LENGTH + EDID_CHECKSUM]); >>>>>> - exynos_dp_write_byte_to_dpcd(dp, >>>>>> - DP_TEST_RESPONSE, >>>>>> + exynos_dp_write_byte_to_dpcd( >>>>>> + dp, DP_TEST_RESPONSE, >>>>>> DP_TEST_EDID_CHECKSUM_WRITE); >>>>> To me, missing argument after opening parenthesis, looks worse. I would >>>>> prefer: >>>>> >>>>> exynos_dp_write_byte_to_dpcd(dp, >>>>> >>>>> Why you moved the 'dp' argument to new line? >>>> Hmm... Just like style tool indicate, no more warning after >>>> that change. >>>> >>>> For now, I would like to follow the original style, just improved >>>> some obvious style problem. :-) >>> What was the checkpatch warning that said 'dp' has to move to new line? >>> I tried this and I don't see it. >> checkpatch haven't remind me that put dp to new line would fix >> this warning, this just come from my experiments. And I works, >> no more warnings from checkpatch, so I toke this style. > Checkpatch isn't a great arbiter of style. > It's just a brainless tool. > > Always use your instead of anything brainless. > > If it were code I was writing, I'd ignore 80 columns warnings > where appropriate. > > These are long function names and long macro defines, so it's > inappropriate to use 80 columns as a guiding style. > > I'd write: > > exynos_dp_read_byte_from_dpcd(dp, DP_TEST_REQUEST, &test_vector); > if (test_vector & DP_TEST_LINK_EDID_READ) { > exynos_dp_write_byte_to_dpcd(dp, DP_TEST_EDID_CHECKSUM, > edid[EDID_BLOCK_LENGTH + EDID_CHECKSUM]); > exynos_dp_write_byte_to_dpcd(dp, DP_TEST_RESPONSE, > DP_TEST_EDID_CHECKSUM_WRITE); > } > So... just ignore the 80 columns warnings. Actually I prefer to keep the original style in this case. Thanks, - Yakir ] > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yakir Yang Subject: Re: [PATCH v4 01/16] drm: exynos/dp: fix code style Date: Sun, 06 Sep 2015 09:33:45 +0800 Message-ID: <55EB97F9.3010503@rock-chips.com> References: <1441086371-24838-1-git-send-email-ykk@rock-chips.com> <1441086399-24889-1-git-send-email-ykk@rock-chips.com> <55E79297.3050203@samsung.com> <55E7D4E4.6070808@rock-chips.com> <55E7D5EB.1060505@samsung.com> <55E7DBA7.90504@rock-chips.com> <1441259878.12163.75.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1441259878.12163.75.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Joe Perches Cc: Krzysztof Kozlowski , Heiko Stuebner , David Airlie , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Andrzej Hajda , Gustavo Padovan , architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, seanpaul-F7+t8E8rja9Wk0Htik3J/w@public.gmane.org, djkurtz-F7+t8E8rja9Wk0Htik3J/w@public.gmane.org, Kishon Vijay Abraham I , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Kukjin Kim , robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Russell King , Thierry Reding , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Pawel Moll , Ian Campbell , Inki Dae , Rob Herring , dianders-F7+t8E8rja9Wk0Htik3J/w@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Mark Yao , Jingoo Han , linux-kernel-u79uwXL29TaqPxH82wqD4g@public.gmane.org List-Id: devicetree@vger.kernel.org SGkgSm9lLAoK5ZyoIDA5LzAzLzIwMTUgMDE6NTcgUE0sIEpvZSBQZXJjaGVzIOWGmemBkzoKPiBP biBUaHUsIDIwMTUtMDktMDMgYXQgMTM6MzMgKzA4MDAsIFlha2lyIFlhbmcgd3JvdGU6Cj4gW10K Pj4+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcF9jb3Jl LmMKPiBbXQo+Pj4+Pj4gQEAgLTE1NSwyNCArMTU2LDIyIEBAIHN0YXRpYyBpbnQgZXh5bm9zX2Rw X3JlYWRfZWRpZChzdHJ1Y3QKPj4+Pj4+IGV4eW5vc19kcF9kZXZpY2UgKmRwKQo+Pj4+Pj4gICAg ICAgICAgICAgfQo+Pj4+Pj4gICAgICAgICAgICAgICBleHlub3NfZHBfcmVhZF9ieXRlX2Zyb21f ZHBjZChkcCwgRFBfVEVTVF9SRVFVRVNULAo+Pj4+Pj4gLSAgICAgICAgICAgICAgICAgICAgJnRl c3RfdmVjdG9yKTsKPj4+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICZ0ZXN0X3ZlY3Rv cik7Cj4+Pj4+PiAgICAgICAgICAgICBpZiAodGVzdF92ZWN0b3IgJiBEUF9URVNUX0xJTktfRURJ RF9SRUFEKSB7Cj4+Pj4+PiAtICAgICAgICAgICAgZXh5bm9zX2RwX3dyaXRlX2J5dGVfdG9fZHBj ZChkcCwKPj4+Pj4+IC0gICAgICAgICAgICAgICAgRFBfVEVTVF9FRElEX0NIRUNLU1VNLAo+Pj4+ Pj4gKyAgICAgICAgICAgIGV4eW5vc19kcF93cml0ZV9ieXRlX3RvX2RwY2QoCj4+Pj4+PiArICAg ICAgICAgICAgICAgIGRwLCBEUF9URVNUX0VESURfQ0hFQ0tTVU0sCj4+Pj4+PiAgICAgICAgICAg ICAgICAgICAgIGVkaWRbRURJRF9CTE9DS19MRU5HVEggKyBFRElEX0NIRUNLU1VNXSk7Cj4+Pj4+ PiAtICAgICAgICAgICAgZXh5bm9zX2RwX3dyaXRlX2J5dGVfdG9fZHBjZChkcCwKPj4+Pj4+IC0g ICAgICAgICAgICAgICAgRFBfVEVTVF9SRVNQT05TRSwKPj4+Pj4+ICsgICAgICAgICAgICBleHlu b3NfZHBfd3JpdGVfYnl0ZV90b19kcGNkKAo+Pj4+Pj4gKyAgICAgICAgICAgICAgICBkcCwgRFBf VEVTVF9SRVNQT05TRSwKPj4+Pj4+ICAgICAgICAgICAgICAgICAgICAgRFBfVEVTVF9FRElEX0NI RUNLU1VNX1dSSVRFKTsKPj4+Pj4gVG8gbWUsIG1pc3NpbmcgYXJndW1lbnQgYWZ0ZXIgb3Blbmlu ZyBwYXJlbnRoZXNpcywgbG9va3Mgd29yc2UuIEkgd291bGQKPj4+Pj4gcHJlZmVyOgo+Pj4+Pgo+ Pj4+PiAgICAgICAgICAgICAgIGV4eW5vc19kcF93cml0ZV9ieXRlX3RvX2RwY2QoZHAsCj4+Pj4+ Cj4+Pj4+IFdoeSB5b3UgbW92ZWQgdGhlICdkcCcgYXJndW1lbnQgdG8gbmV3IGxpbmU/Cj4+Pj4g SG1tLi4uIEp1c3QgbGlrZSBzdHlsZSB0b29sIGluZGljYXRlLCBubyBtb3JlIHdhcm5pbmcgYWZ0 ZXIKPj4+PiB0aGF0IGNoYW5nZS4KPj4+Pgo+Pj4+IEZvciBub3csIEkgd291bGQgbGlrZSB0byBm b2xsb3cgdGhlIG9yaWdpbmFsIHN0eWxlLCBqdXN0IGltcHJvdmVkCj4+Pj4gc29tZSBvYnZpb3Vz IHN0eWxlIHByb2JsZW0uICA6LSkKPj4+IFdoYXQgd2FzIHRoZSBjaGVja3BhdGNoIHdhcm5pbmcg dGhhdCBzYWlkICdkcCcgaGFzIHRvIG1vdmUgdG8gbmV3IGxpbmU/Cj4+PiBJIHRyaWVkIHRoaXMg YW5kIEkgZG9uJ3Qgc2VlIGl0Lgo+PiBjaGVja3BhdGNoIGhhdmVuJ3QgcmVtaW5kIG1lIHRoYXQg cHV0IGRwIHRvIG5ldyBsaW5lIHdvdWxkIGZpeAo+PiB0aGlzIHdhcm5pbmcsIHRoaXMganVzdCBj b21lIGZyb20gbXkgZXhwZXJpbWVudHMuIEFuZCBJIHdvcmtzLAo+PiBubyBtb3JlIHdhcm5pbmdz IGZyb20gY2hlY2twYXRjaCwgc28gSSB0b2tlIHRoaXMgc3R5bGUuCj4gQ2hlY2twYXRjaCBpc24n dCBhIGdyZWF0IGFyYml0ZXIgb2Ygc3R5bGUuCj4gSXQncyBqdXN0IGEgYnJhaW5sZXNzIHRvb2wu Cj4KPiBBbHdheXMgdXNlIHlvdXIgaW5zdGVhZCBvZiBhbnl0aGluZyBicmFpbmxlc3MuCj4KPiBJ ZiBpdCB3ZXJlIGNvZGUgSSB3YXMgd3JpdGluZywgSSdkIGlnbm9yZSA4MCBjb2x1bW5zIHdhcm5p bmdzCj4gd2hlcmUgYXBwcm9wcmlhdGUuCj4KPiBUaGVzZSBhcmUgbG9uZyBmdW5jdGlvbiBuYW1l cyBhbmQgbG9uZyBtYWNybyBkZWZpbmVzLCBzbyBpdCdzCj4gaW5hcHByb3ByaWF0ZSB0byB1c2Ug ODAgY29sdW1ucyBhcyBhIGd1aWRpbmcgc3R5bGUuCj4KPiBJJ2Qgd3JpdGU6Cj4KPiAJCWV4eW5v c19kcF9yZWFkX2J5dGVfZnJvbV9kcGNkKGRwLCBEUF9URVNUX1JFUVVFU1QsICZ0ZXN0X3ZlY3Rv cik7Cj4gCQlpZiAodGVzdF92ZWN0b3IgJiBEUF9URVNUX0xJTktfRURJRF9SRUFEKSB7Cj4gCQkJ ZXh5bm9zX2RwX3dyaXRlX2J5dGVfdG9fZHBjZChkcCwgRFBfVEVTVF9FRElEX0NIRUNLU1VNLAo+ IAkJCQkJCSAgICAgZWRpZFtFRElEX0JMT0NLX0xFTkdUSCArIEVESURfQ0hFQ0tTVU1dKTsKPiAJ CQlleHlub3NfZHBfd3JpdGVfYnl0ZV90b19kcGNkKGRwLCBEUF9URVNUX1JFU1BPTlNFLAo+IAkJ CQkJCSAgICAgRFBfVEVTVF9FRElEX0NIRUNLU1VNX1dSSVRFKTsKPiAJCX0KPgoKU28uLi4ganVz dCBpZ25vcmUgdGhlIDgwIGNvbHVtbnMgd2FybmluZ3MuIEFjdHVhbGx5IEkgcHJlZmVyIHRvCmtl ZXAgdGhlIG9yaWdpbmFsIHN0eWxlIGluIHRoaXMgY2FzZS4KClRoYW5rcywKLSBZYWtpcgpdCj4K Pgo+CgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxp bnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQu b3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9j a2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 From: ykk@rock-chips.com (Yakir Yang) Date: Sun, 06 Sep 2015 09:33:45 +0800 Subject: [PATCH v4 01/16] drm: exynos/dp: fix code style In-Reply-To: <1441259878.12163.75.camel@perches.com> References: <1441086371-24838-1-git-send-email-ykk@rock-chips.com> <1441086399-24889-1-git-send-email-ykk@rock-chips.com> <55E79297.3050203@samsung.com> <55E7D4E4.6070808@rock-chips.com> <55E7D5EB.1060505@samsung.com> <55E7DBA7.90504@rock-chips.com> <1441259878.12163.75.camel@perches.com> Message-ID: <55EB97F9.3010503@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Joe, ? 09/03/2015 01:57 PM, Joe Perches ??: > On Thu, 2015-09-03 at 13:33 +0800, Yakir Yang wrote: > [] >>>>>> diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c > [] >>>>>> @@ -155,24 +156,22 @@ static int exynos_dp_read_edid(struct >>>>>> exynos_dp_device *dp) >>>>>> } >>>>>> exynos_dp_read_byte_from_dpcd(dp, DP_TEST_REQUEST, >>>>>> - &test_vector); >>>>>> + &test_vector); >>>>>> if (test_vector & DP_TEST_LINK_EDID_READ) { >>>>>> - exynos_dp_write_byte_to_dpcd(dp, >>>>>> - DP_TEST_EDID_CHECKSUM, >>>>>> + exynos_dp_write_byte_to_dpcd( >>>>>> + dp, DP_TEST_EDID_CHECKSUM, >>>>>> edid[EDID_BLOCK_LENGTH + EDID_CHECKSUM]); >>>>>> - exynos_dp_write_byte_to_dpcd(dp, >>>>>> - DP_TEST_RESPONSE, >>>>>> + exynos_dp_write_byte_to_dpcd( >>>>>> + dp, DP_TEST_RESPONSE, >>>>>> DP_TEST_EDID_CHECKSUM_WRITE); >>>>> To me, missing argument after opening parenthesis, looks worse. I would >>>>> prefer: >>>>> >>>>> exynos_dp_write_byte_to_dpcd(dp, >>>>> >>>>> Why you moved the 'dp' argument to new line? >>>> Hmm... Just like style tool indicate, no more warning after >>>> that change. >>>> >>>> For now, I would like to follow the original style, just improved >>>> some obvious style problem. :-) >>> What was the checkpatch warning that said 'dp' has to move to new line? >>> I tried this and I don't see it. >> checkpatch haven't remind me that put dp to new line would fix >> this warning, this just come from my experiments. And I works, >> no more warnings from checkpatch, so I toke this style. > Checkpatch isn't a great arbiter of style. > It's just a brainless tool. > > Always use your instead of anything brainless. > > If it were code I was writing, I'd ignore 80 columns warnings > where appropriate. > > These are long function names and long macro defines, so it's > inappropriate to use 80 columns as a guiding style. > > I'd write: > > exynos_dp_read_byte_from_dpcd(dp, DP_TEST_REQUEST, &test_vector); > if (test_vector & DP_TEST_LINK_EDID_READ) { > exynos_dp_write_byte_to_dpcd(dp, DP_TEST_EDID_CHECKSUM, > edid[EDID_BLOCK_LENGTH + EDID_CHECKSUM]); > exynos_dp_write_byte_to_dpcd(dp, DP_TEST_RESPONSE, > DP_TEST_EDID_CHECKSUM_WRITE); > } > So... just ignore the 80 columns warnings. Actually I prefer to keep the original style in this case. Thanks, - Yakir ] > > >