From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41493) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbUsU-0005T7-GB for qemu-devel@nongnu.org; Mon, 14 Sep 2015 10:37:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZbUsR-00063P-Of for qemu-devel@nongnu.org; Mon, 14 Sep 2015 10:37:06 -0400 References: <1442000463-22777-1-git-send-email-kwolf@redhat.com> <20150914095705.GC3550@noname.str.redhat.com> From: Max Reitz Message-ID: <55F6DB80.8030905@redhat.com> Date: Mon, 14 Sep 2015 16:36:48 +0200 MIME-Version: 1.0 In-Reply-To: <20150914095705.GC3550@noname.str.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cOVLqGX8XBk4DVKl1WCfFVPUnEaK8f4fG" Subject: Re: [Qemu-devel] [PULL 00/23] Block layer patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , Peter Maydell Cc: QEMU Developers , Qemu-block This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --cOVLqGX8XBk4DVKl1WCfFVPUnEaK8f4fG Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 14.09.2015 11:57, Kevin Wolf wrote: > Am 14.09.2015 um 11:46 hat Peter Maydell geschrieben: >> On 11 September 2015 at 20:40, Kevin Wolf wrote: >>> The following changes since commit 30c38c90bd3f1bb105ebc069ac1821067c= 980b7c: >>> >>> scripts/qemu-gdb: Add brief comment describing usage (2015-09-11 17= :14:50 +0100) >>> >>> are available in the git repository at: >>> >>> git://repo.or.cz/qemu/kevin.git tags/for-upstream >>> >>> for you to fetch changes up to 1fcbcc93872953d08cd35830d1169fed191962= 90: >>> >>> qcow2: Make qcow2_alloc_bytes() more explicit (2015-09-11 20:03:02 = +0200) >>> >>> ---------------------------------------------------------------- >>> Block layer patches >>> >>> ---------------------------------------------------------------- >> >> Hi. I'm afraid this fails to build on 32-bit: >> >> /home/pm215/qemu/block/qcow2-refcount.c: In function =E2=80=98realloc_= refcount_array=E2=80=99: >> /home/pm215/qemu/block/qcow2-refcount.c:1294:16: error: cast to >> pointer from integer of different size [-Werror=3Dint-to-pointer-cast]= >> memset((void *)((uintptr_t)new_ptr + old_byte_size), 0, >> ^ >> cc1: all warnings being treated as errors >> /home/pm215/qemu/rules.mak:57: recipe for target 'block/qcow2-refcount= =2Eo' failed >> make: *** [block/qcow2-refcount.o] Error 1 >> >> (old_byte_size is int64_t, so (uintptr_t)new_ptr + old_byte_size >> becomes a 64-bit addition, and then you cast it to a 32-bit >> pointer.) >=20 > Max, I think this is yours. Indeed, I'll send a v3 for "qcow2: Make size_to_clusters() return uint64_t" and "iotests: Add test for checking large image files". You decide whether you are going to include them in a new pull request or just drop them for now. Max --cOVLqGX8XBk4DVKl1WCfFVPUnEaK8f4fG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJV9tuAAAoJEDuxQgLoOKytNNEIAJ/VIRwikhmvaHtykjUYUSe0 oDHPH9uJhCmDmyHOhv0pWeDi/j33cFT2SleBIq/dkKUVw4y3bq8OuYJUQlN5hX9R HcLat3ewRbjIbjQjjMhyqpBLuWJoaM5KObMFLffyRSHMjlRpuHTUZf2q5g3ARUt/ ENtyHxV77ed2I9LPEFxOY53p5a+LNF8Z4+G7ZYhFAv5rcXZcbzUgLhIDvBtjkxTH QlpJJPLKiS/EE2480xHt77+ovAafMp0gzqN1ma7mGOWPwFFw/l0rE/1vQX7LRGTQ Uko0DOkCCv7jzxFADm2p8KiKOMpysakm7S92lP3rmXAVJCVMgoDx2LQ0sskEvUU= =V0AD -----END PGP SIGNATURE----- --cOVLqGX8XBk4DVKl1WCfFVPUnEaK8f4fG--