From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53038)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1Zbd8L-0001Uk-5Z
	for qemu-devel@nongnu.org; Mon, 14 Sep 2015 19:26:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1Zbd8H-0005BX-Va
	for qemu-devel@nongnu.org; Mon, 14 Sep 2015 19:26:01 -0400
Received: from mail-pa0-f54.google.com ([209.85.220.54]:34169)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1Zbd8H-0005BJ-QL
	for qemu-devel@nongnu.org; Mon, 14 Sep 2015 19:25:57 -0400
Received: by padhy16 with SMTP id hy16so156602252pad.1
	for <qemu-devel@nongnu.org>; Mon, 14 Sep 2015 16:25:57 -0700 (PDT)
References: <1442259039-22137-1-git-send-email-mark.cave-ayland@ilande.co.uk>
	<1442259039-22137-2-git-send-email-mark.cave-ayland@ilande.co.uk>
From: Alexey Kardashevskiy <aik@ozlabs.ru>
Message-ID: <55F75780.3010207@ozlabs.ru>
Date: Tue, 15 Sep 2015 09:25:52 +1000
MIME-Version: 1.0
In-Reply-To: <1442259039-22137-2-git-send-email-mark.cave-ayland@ilande.co.uk>
Content-Type: text/plain; charset=koi8-r; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH 1/2] target-ppc: remove
 hreg_compute_mem_idx() from cpu_post_load
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, agraf@suse.de

On 09/15/2015 05:30 AM, Mark Cave-Ayland wrote:
> hreg_compute_mem_idx() has already been called previously by ppc_store_msr()
> via hreg_store_msr() and hreg_compute_hflags(). Drop the duplicate function
> call as it is no longer needed.
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>	

> ---
>   target-ppc/machine.c |    2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/target-ppc/machine.c b/target-ppc/machine.c
> index f4ac761..bd99844 100644
> --- a/target-ppc/machine.c
> +++ b/target-ppc/machine.c
> @@ -197,8 +197,6 @@ static int cpu_post_load(void *opaque, int version_id)
>       env->msr ^= ~((1ULL << MSR_TGPR) | MSR_HVB);
>       ppc_store_msr(env, msr);
>
> -    hreg_compute_mem_idx(env);
> -
>       return 0;
>   }
>
>


-- 
Alexey