From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51424) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbqCB-00073x-R5 for qemu-devel@nongnu.org; Tue, 15 Sep 2015 09:22:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zbpsz-0002ri-2o for qemu-devel@nongnu.org; Tue, 15 Sep 2015 09:03:05 -0400 Received: from mail.uni-paderborn.de ([131.234.142.9]:36277) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zbpsy-0002qv-Sa for qemu-devel@nongnu.org; Tue, 15 Sep 2015 09:03:01 -0400 References: <1441239463-18981-1-git-send-email-rth@twiddle.net> <1441239463-18981-17-git-send-email-rth@twiddle.net> From: Bastian Koppelmann Message-ID: <55F816FF.4090308@mail.uni-paderborn.de> Date: Tue, 15 Sep 2015 15:02:55 +0200 MIME-Version: 1.0 In-Reply-To: <1441239463-18981-17-git-send-email-rth@twiddle.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 16/17] target-openrisc: Write back result before FPE exception List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, proljc@gmail.com On 09/03/2015 02:17 AM, Richard Henderson wrote: > The architecture manual is unclear about this, but the or1ksim > does writeback before the exception. This requires splitting > the helpers in half, with the exception raised by the second. > > Signed-off-by: Richard Henderson > --- > target-openrisc/fpu_helper.c | 252 +++++++++---------------------------------- > target-openrisc/helper.h | 25 +++-- > target-openrisc/translate.c | 118 +++++++++++--------- > 3 files changed, 129 insertions(+), 266 deletions(-) > Reviewed-by: Bastian Koppelmann Cheers, Bastian