From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752954AbbIPJww (ORCPT ); Wed, 16 Sep 2015 05:52:52 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:24963 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751963AbbIPJwu (ORCPT ); Wed, 16 Sep 2015 05:52:50 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-c0-55f93bf0b5cd Subject: Re: [PATCH 01/31] arch/arm/mach-lpc32xx: use kmemdup rather than duplicating its implementation To: Roland Stigge References: <1438934377-4922-1-git-send-email-a.hajda@samsung.com> <1438934377-4922-2-git-send-email-a.hajda@samsung.com> Cc: Bartlomiej Zolnierkiewicz , Marek Szyprowski , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Andrzej Hajda Message-id: <55F93BE5.60508@samsung.com> Date: Wed, 16 Sep 2015 11:52:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-version: 1.0 In-reply-to: <1438934377-4922-2-git-send-email-a.hajda@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJLMWRmVeSWpSXmKPExsVy+t/xy7ofrH+GGixbam2xccZ6VotNj6+x WlzeNYfNYu2Ru+wWk5ecZXVg9ZgzdTejx+Yl9R59W1YxenzeJBfAEsVlk5Kak1mWWqRvl8CV cf/KbsaC2dwVdx+0MzYwtnN2MXJySAiYSPzecogFwhaTuHBvPVsXIxeHkMBSRok1k+aygiSE BJ4DOdMrQGxhgSyJSQePs4PYIgIqEq1fp0LVVEtc/foZrJlZYC2jxOXZV8ASbAKaEn833wRK cHDwCmhI/HpWAhJmEVCVOLXvMNgcUYEIiVNn37KB2LwCghI/Jt8DO4hTwFlix8IHTCCtzAJ6 EvcvaoGEmQXkJTavecs8gVFgFpKOWQhVs5BULWBkXsUomlqaXFCclJ5rqFecmFtcmpeul5yf u4kREsBfdjAuPmZ1iFGAg1GJh9fh5Y9QIdbEsuLK3EOMEhzMSiK8kQo/Q4V4UxIrq1KL8uOL SnNSiw8xSnOwKInzzt31PkRIID2xJDU7NbUgtQgmy8TBKdXAaO3gGZDnO+vD1LTZXa5Po0RW 1j4XLjH3+aq3R9xwk6GP8e/1CxLEf8d2eS9vidtRlFFQ8Klr0qzrBl+8g5RmPWSe3fjp1Lfd quF5l1MTl3+33ZKy5+3K+GUiba7zmK9am00uOxDC03I3Qey1t/4GgWfzHT/NDz96NHLrloe3 9YrvMDoLPvtno8RSnJFoqMVcVJwIAKLtS95cAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ping. Regards Andrzej On 08/07/2015 09:59 AM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda > --- > arch/arm/mach-lpc32xx/pm.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/mach-lpc32xx/pm.c b/arch/arm/mach-lpc32xx/pm.c > index 207e812..dd3a432 100644 > --- a/arch/arm/mach-lpc32xx/pm.c > +++ b/arch/arm/mach-lpc32xx/pm.c > @@ -87,7 +87,8 @@ static int lpc32xx_pm_enter(suspend_state_t state) > void *iram_swap_area; > > /* Allocate some space for temporary IRAM storage */ > - iram_swap_area = kmalloc(lpc32xx_sys_suspend_sz, GFP_KERNEL); > + iram_swap_area = kmemdup((void *)TEMP_IRAM_AREA, > + lpc32xx_sys_suspend_sz, GFP_KERNEL); > if (!iram_swap_area) { > printk(KERN_ERR > "PM Suspend: cannot allocate memory to save portion " > @@ -95,10 +96,6 @@ static int lpc32xx_pm_enter(suspend_state_t state) > return -ENOMEM; > } > > - /* Backup a small area of IRAM used for the suspend code */ > - memcpy(iram_swap_area, (void *) TEMP_IRAM_AREA, > - lpc32xx_sys_suspend_sz); > - > /* > * Copy code to suspend system into IRAM. The suspend code > * needs to run from IRAM as DRAM may no longer be available From mboxrd@z Thu Jan 1 00:00:00 1970 From: a.hajda@samsung.com (Andrzej Hajda) Date: Wed, 16 Sep 2015 11:52:37 +0200 Subject: [PATCH 01/31] arch/arm/mach-lpc32xx: use kmemdup rather than duplicating its implementation In-Reply-To: <1438934377-4922-2-git-send-email-a.hajda@samsung.com> References: <1438934377-4922-1-git-send-email-a.hajda@samsung.com> <1438934377-4922-2-git-send-email-a.hajda@samsung.com> Message-ID: <55F93BE5.60508@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Ping. Regards Andrzej On 08/07/2015 09:59 AM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda > --- > arch/arm/mach-lpc32xx/pm.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/mach-lpc32xx/pm.c b/arch/arm/mach-lpc32xx/pm.c > index 207e812..dd3a432 100644 > --- a/arch/arm/mach-lpc32xx/pm.c > +++ b/arch/arm/mach-lpc32xx/pm.c > @@ -87,7 +87,8 @@ static int lpc32xx_pm_enter(suspend_state_t state) > void *iram_swap_area; > > /* Allocate some space for temporary IRAM storage */ > - iram_swap_area = kmalloc(lpc32xx_sys_suspend_sz, GFP_KERNEL); > + iram_swap_area = kmemdup((void *)TEMP_IRAM_AREA, > + lpc32xx_sys_suspend_sz, GFP_KERNEL); > if (!iram_swap_area) { > printk(KERN_ERR > "PM Suspend: cannot allocate memory to save portion " > @@ -95,10 +96,6 @@ static int lpc32xx_pm_enter(suspend_state_t state) > return -ENOMEM; > } > > - /* Backup a small area of IRAM used for the suspend code */ > - memcpy(iram_swap_area, (void *) TEMP_IRAM_AREA, > - lpc32xx_sys_suspend_sz); > - > /* > * Copy code to suspend system into IRAM. The suspend code > * needs to run from IRAM as DRAM may no longer be available