From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753173AbbIPJ46 (ORCPT ); Wed, 16 Sep 2015 05:56:58 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:34959 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752059AbbIPJ44 (ORCPT ); Wed, 16 Sep 2015 05:56:56 -0400 X-AuditID: cbfec7f5-f794b6d000001495-61-55f93ce714a3 Subject: Re: [PATCH 12/31] drm/amdgpu: use kmemdup rather than duplicating its implementation To: Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , David Airlie References: <1438934377-4922-1-git-send-email-a.hajda@samsung.com> <1438934377-4922-13-git-send-email-a.hajda@samsung.com> Cc: Bartlomiej Zolnierkiewicz , Marek Szyprowski , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org From: Andrzej Hajda Message-id: <55F93CDB.70505@samsung.com> Date: Wed, 16 Sep 2015 11:56:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-version: 1.0 In-reply-to: <1438934377-4922-13-git-send-email-a.hajda@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrBLMWRmVeSWpSXmKPExsVy+t/xK7rPbX6GGlz9KWDRe+4kk8W0O7tZ LTbOWM9q8fY+kHXl63s2i8u75rBZrD1yl92B3aP10l82j+3fHrB63O8+zuTRt2UVo8fnTXIB rFFcNimpOZllqUX6dglcGQt/PGUuuM5R8fnARdYGxvnsXYycHBICJhJTdm1jgbDFJC7cW8/W xcjFISSwlFFi1oYWVgjnOaPElseHGbsYOTiEBeIlTj/QB2kQEehjlPhxSA/EFhKokTj38hYT SD2zwApGiYXHd4NNZRPQlPi7+SYbiM0roCHR0bqSFWQOi4CqxNb38iBhUYEIiVNn30KVCEr8 mHyPBaSEU8BFYtEeAxCTWUBP4v5FLZAKZgF5ic1r3jJPYBSYhaRhFkLVLCRVCxiZVzGKppYm FxQnpeca6RUn5haX5qXrJefnbmKEhPfXHYxLj1kdYhTgYFTi4XV4+SNUiDWxrLgy9xCjBAez kgjvI6ufoUK8KYmVValF+fFFpTmpxYcYpTlYlMR5Z+56HyIkkJ5YkpqdmlqQWgSTZeLglGpg nKnKfmzhvjXs9UKXd7FNiU6bEXFltTZ328lezry1jS/SVgsulN85v719sZ6ffqHu7WieGSer n7eWS15+ufr7j3epq6z3mL2Zl+9xLv1PL7vJoQMvTUUzDWdkuf69p/d69a3Mmi8qTLE1ev2n 98S376kQD1jSnTPnguBE1zcPY0xXv4laseGdlhJLcUaioRZzUXEiAId6i6prAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ping. Regards Andrzej On 08/07/2015 09:59 AM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c > index 8da6424..94bd992 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c > @@ -549,12 +549,10 @@ int amdgpu_bo_set_metadata (struct amdgpu_bo *bo, void *metadata, > if (metadata == NULL) > return -EINVAL; > > - buffer = kzalloc(metadata_size, GFP_KERNEL); > + buffer = kmemdup(metadata, metadata_size, GFP_KERNEL); > if (buffer == NULL) > return -ENOMEM; > > - memcpy(buffer, metadata, metadata_size); > - > kfree(bo->metadata); > bo->metadata_flags = flags; > bo->metadata = buffer; From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrzej Hajda Subject: Re: [PATCH 12/31] drm/amdgpu: use kmemdup rather than duplicating its implementation Date: Wed, 16 Sep 2015 11:56:43 +0200 Message-ID: <55F93CDB.70505@samsung.com> References: <1438934377-4922-1-git-send-email-a.hajda@samsung.com> <1438934377-4922-13-git-send-email-a.hajda@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mailout3.w1.samsung.com (mailout3.w1.samsung.com [210.118.77.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id 411636E0FC for ; Wed, 16 Sep 2015 02:56:58 -0700 (PDT) Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NUR005Z3KYVN940@mailout3.w1.samsung.com> for dri-devel@lists.freedesktop.org; Wed, 16 Sep 2015 10:56:55 +0100 (BST) In-reply-to: <1438934377-4922-13-git-send-email-a.hajda@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , David Airlie Cc: Marek Szyprowski , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Bartlomiej Zolnierkiewicz List-Id: dri-devel@lists.freedesktop.org UGluZy4KClJlZ2FyZHMKQW5kcnplagoKT24gMDgvMDcvMjAxNSAwOTo1OSBBTSwgQW5kcnplaiBI YWpkYSB3cm90ZToKPiBUaGUgcGF0Y2ggd2FzIGdlbmVyYXRlZCB1c2luZyBmaXhlZCBjb2NjaW5l bGxlIHNlbWFudGljIHBhdGNoCj4gc2NyaXB0cy9jb2NjaW5lbGxlL2FwaS9tZW1kdXAuY29jY2kg WzFdLgo+Cj4gWzFdOiBodHRwOi8vcGVybWFsaW5rLmdtYW5lLm9yZy9nbWFuZS5saW51eC5rZXJu ZWwvMjAxNDMyMAo+Cj4gU2lnbmVkLW9mZi1ieTogQW5kcnplaiBIYWpkYSA8YS5oYWpkYUBzYW1z dW5nLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X29iamVj dC5jIHwgNCArLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMyBkZWxldGlv bnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVf b2JqZWN0LmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfb2JqZWN0LmMKPiBp bmRleCA4ZGE2NDI0Li45NGJkOTkyIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQv YW1kZ3B1L2FtZGdwdV9vYmplY3QuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1 L2FtZGdwdV9vYmplY3QuYwo+IEBAIC01NDksMTIgKzU0OSwxMCBAQCBpbnQgYW1kZ3B1X2JvX3Nl dF9tZXRhZGF0YSAoc3RydWN0IGFtZGdwdV9ibyAqYm8sIHZvaWQgKm1ldGFkYXRhLAo+ICAJaWYg KG1ldGFkYXRhID09IE5VTEwpCj4gIAkJcmV0dXJuIC1FSU5WQUw7Cj4gIAo+IC0JYnVmZmVyID0g a3phbGxvYyhtZXRhZGF0YV9zaXplLCBHRlBfS0VSTkVMKTsKPiArCWJ1ZmZlciA9IGttZW1kdXAo bWV0YWRhdGEsIG1ldGFkYXRhX3NpemUsIEdGUF9LRVJORUwpOwo+ICAJaWYgKGJ1ZmZlciA9PSBO VUxMKQo+ICAJCXJldHVybiAtRU5PTUVNOwo+ICAKPiAtCW1lbWNweShidWZmZXIsIG1ldGFkYXRh LCBtZXRhZGF0YV9zaXplKTsKPiAtCj4gIAlrZnJlZShiby0+bWV0YWRhdGEpOwo+ICAJYm8tPm1l dGFkYXRhX2ZsYWdzID0gZmxhZ3M7Cj4gIAliby0+bWV0YWRhdGEgPSBidWZmZXI7CgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGlu ZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=