From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752799AbbIPKBT (ORCPT <rfc822;w@1wt.eu>);
	Wed, 16 Sep 2015 06:01:19 -0400
Received: from mailout2.w1.samsung.com ([210.118.77.12]:25381 "EHLO
	mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752196AbbIPKBS (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 16 Sep 2015 06:01:18 -0400
X-AuditID: cbfec7f4-f79c56d0000012ee-7b-55f93deb49c2
Subject: Re: [PATCH 14/31] message/fusion: use kmemdup rather than duplicating
 its implementation
To: Sreekanth Reddy <sreekanth.reddy@avagotech.com>
References: <1438934377-4922-1-git-send-email-a.hajda@samsung.com>
 <1438934377-4922-15-git-send-email-a.hajda@samsung.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        linux-kernel@vger.kernel.org, MPT-FusionLinux.pdl@avagotech.com,
        linux-scsi@vger.kernel.org
From: Andrzej Hajda <a.hajda@samsung.com>
Message-id: <55F93DDF.3060507@samsung.com>
Date: Wed, 16 Sep 2015 12:01:03 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-version: 1.0
In-reply-to: <1438934377-4922-15-git-send-email-a.hajda@samsung.com>
Content-type: text/plain; charset=windows-1252
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJLMWRmVeSWpSXmKPExsVy+t/xK7qvbX+GGrR/VLDYOGM9q8XlXXPY
	LLqv72CzWHvkLrvFwQnXWS3mvOtgdWDzWHZ+IrNH35ZVjB6fN8kFMEdx2aSk5mSWpRbp2yVw
	ZXxZnlHQylHR8ucKewPjcbYuRg4OCQETiZefuLsYOYFMMYkL99YDhbk4hASWMkp86DrLCuE8
	B3Je/WYGqRIWSJb49nszK4gtImAs0fr2OguILSRQI9F4bAdYnFngGKNE9z9lEJtNQFPi7+ab
	bCA2r4CWxJ5p/5hAbBYBVYlvPW/BekUFIiROnX0LVSMo8WPyPbA4p4CLRP/f+YwghzIL6Enc
	v6gFMV5eYvOat8wTGAVmIemYhVA1C0nVAkbmVYyiqaXJBcVJ6bmGesWJucWleel6yfm5mxgh
	AfxlB+PiY1aHGAU4GJV4eB1e/ggVYk0sK67MPcQowcGsJML7yOpnqBBvSmJlVWpRfnxRaU5q
	8SFGaQ4WJXHeubvehwgJpCeWpGanphakFsFkmTg4pRoYdQtVEpQemnjLHY77tO7n4sBezcib
	C7zvXLqWHHhIKeuJ2KeKT/5RHj80yuollF+tWhGbI+TO+HTd54ua6vdmCuXLl1Vp3nx+8n3b
	oSjG46te1M4ou52i9YWxxnT+vyDhpXPWFXDMVpxXYHa/ozVg2Q3WV2prL3DqHWdPZAg5/sGL
	U+jgT6aLSizFGYmGWsxFxYkAJhyho1wCAAA=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Ping.

Regards
Andrzej

On 08/07/2015 09:59 AM, Andrzej Hajda wrote:
> The patch was generated using fixed coccinelle semantic patch
> scripts/coccinelle/api/memdup.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
>  drivers/message/fusion/mptbase.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c
> index 5dcc031..1551f51 100644
> --- a/drivers/message/fusion/mptbase.c
> +++ b/drivers/message/fusion/mptbase.c
> @@ -5971,13 +5971,12 @@ mpt_findImVolumes(MPT_ADAPTER *ioc)
>  	if (mpt_config(ioc, &cfg) != 0)
>  		goto out;
>  
> -	mem = kmalloc(iocpage2sz, GFP_KERNEL);
> +	mem = kmemdup((u8 *)pIoc2, iocpage2sz, GFP_KERNEL);
>  	if (!mem) {
>  		rc = -ENOMEM;
>  		goto out;
>  	}
>  
> -	memcpy(mem, (u8 *)pIoc2, iocpage2sz);
>  	ioc->raid_data.pIocPg2 = (IOCPage2_t *) mem;
>  
>  	mpt_read_ioc_pg_3(ioc);