From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753566AbbIPKCl (ORCPT ); Wed, 16 Sep 2015 06:02:41 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:25654 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751945AbbIPKCj (ORCPT ); Wed, 16 Sep 2015 06:02:39 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-e4-55f93e3c545c Subject: Re: [PATCH 16/31] net/cavium/liquidio: use kmemdup rather than duplicating its implementation To: Derek Chickles , Satanand Burla , Felix Manlunas , Raghu Vatsavayi , Sunil Goutham , Robert Richter References: <1438934377-4922-1-git-send-email-a.hajda@samsung.com> <1438934377-4922-17-git-send-email-a.hajda@samsung.com> Cc: Bartlomiej Zolnierkiewicz , Marek Szyprowski , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Andrzej Hajda Message-id: <55F93E30.8080101@samsung.com> Date: Wed, 16 Sep 2015 12:02:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-version: 1.0 In-reply-to: <1438934377-4922-17-git-send-email-a.hajda@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMLMWRmVeSWpSXmKPExsVy+t/xy7o2dj9DDe6tlLPYOGM9q8WiDx+Z LZY2/mK32PT4GqvF5V1z2CzWHrnLbnFsgZjFla3HWSwOrtrIZPFl+342i8uXfzA7cHvM+L2I xWPDiX5Wj02rOtk8Ni+p9+jbsorR4/MmuQC2KC6blNSczLLUIn27BK6M1RO+MxbM5KzY23yF uYHxPnsXIyeHhICJxISvl5kgbDGJC/fWs3UxcnEICSxllPj8dwkzhPOcUeLn8ZlgHcICGRJX F84CqxIRWMIk8fDncRaQhJBAjcSbJb+ZQBLMAkcZJd59XsoMkmAT0JT4u/kmG4jNK6AlMfPK G7BJLAKqEi/ft4HtFhWIkDh19i1UjaDEj8n3wIZyCrhITLgyGaiGA2ionsT9i1ogYWYBeYnN a94yT2AUmIWkYxZC1SwkVQsYmVcxiqaWJhcUJ6XnGuoVJ+YWl+al6yXn525ihETFlx2Mi49Z HWIU4GBU4uF1ePkjVIg1say4MvcQowQHs5II7yOrn6FCvCmJlVWpRfnxRaU5qcWHGKU5WJTE eefueh8iJJCeWJKanZpakFoEk2Xi4JRqYFy8paWTQdd3H4Nu+XT5abpN3Yrz9p1UeWH77/37 XYe85zjZF/EsnzP337M+dXW5gyK39vEwN74rsV8WIl/L+KnNgjW8tkxzxbGCl/WvayuqbApy 3vB97BVKq5rHE+Pusk+ueP6DltPPFYy2zJew3lFhpDj9lJTKJ15h8/OcBxRdVxrLrv77Woml OCPRUIu5qDgRALrqYMmGAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ping. Regards Andrzej On 08/07/2015 09:59 AM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda > --- > drivers/net/ethernet/cavium/liquidio/octeon_device.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_device.c b/drivers/net/ethernet/cavium/liquidio/octeon_device.c > index f67641a..8e23e3f 100644 > --- a/drivers/net/ethernet/cavium/liquidio/octeon_device.c > +++ b/drivers/net/ethernet/cavium/liquidio/octeon_device.c > @@ -602,12 +602,10 @@ int octeon_download_firmware(struct octeon_device *oct, const u8 *data, > snprintf(oct->fw_info.liquidio_firmware_version, 32, "LIQUIDIO: %s", > h->version); > > - buffer = kmalloc(size, GFP_KERNEL); > + buffer = kmemdup(data, size, GFP_KERNEL); > if (!buffer) > return -ENOMEM; > > - memcpy(buffer, data, size); > - > p = buffer + sizeof(struct octeon_firmware_file_header); > > /* load all images */ From mboxrd@z Thu Jan 1 00:00:00 1970 From: a.hajda@samsung.com (Andrzej Hajda) Date: Wed, 16 Sep 2015 12:02:24 +0200 Subject: [PATCH 16/31] net/cavium/liquidio: use kmemdup rather than duplicating its implementation In-Reply-To: <1438934377-4922-17-git-send-email-a.hajda@samsung.com> References: <1438934377-4922-1-git-send-email-a.hajda@samsung.com> <1438934377-4922-17-git-send-email-a.hajda@samsung.com> Message-ID: <55F93E30.8080101@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Ping. Regards Andrzej On 08/07/2015 09:59 AM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda > --- > drivers/net/ethernet/cavium/liquidio/octeon_device.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_device.c b/drivers/net/ethernet/cavium/liquidio/octeon_device.c > index f67641a..8e23e3f 100644 > --- a/drivers/net/ethernet/cavium/liquidio/octeon_device.c > +++ b/drivers/net/ethernet/cavium/liquidio/octeon_device.c > @@ -602,12 +602,10 @@ int octeon_download_firmware(struct octeon_device *oct, const u8 *data, > snprintf(oct->fw_info.liquidio_firmware_version, 32, "LIQUIDIO: %s", > h->version); > > - buffer = kmalloc(size, GFP_KERNEL); > + buffer = kmemdup(data, size, GFP_KERNEL); > if (!buffer) > return -ENOMEM; > > - memcpy(buffer, data, size); > - > p = buffer + sizeof(struct octeon_firmware_file_header); > > /* load all images */