From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753940AbbIPKEI (ORCPT ); Wed, 16 Sep 2015 06:04:08 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:25744 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753920AbbIPKED (ORCPT ); Wed, 16 Sep 2015 06:04:03 -0400 X-AuditID: cbfec7f5-f794b6d000001495-87-55f93e92ac4d Subject: Re: [PATCH 21/31] fs/dlm: use kmemdup rather than duplicating its implementation To: Christine Caulfield , David Teigland References: <1438934377-4922-1-git-send-email-a.hajda@samsung.com> <1438934377-4922-22-git-send-email-a.hajda@samsung.com> Cc: Bartlomiej Zolnierkiewicz , Marek Szyprowski , linux-kernel@vger.kernel.org, cluster-devel@redhat.com From: Andrzej Hajda Message-id: <55F93E86.70906@samsung.com> Date: Wed, 16 Sep 2015 12:03:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-version: 1.0 In-reply-to: <1438934377-4922-22-git-send-email-a.hajda@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrNLMWRmVeSWpSXmKPExsVy+t/xq7qT7H6GGlyfJ2WxccZ6VovHfxtZ LU6ufsxmcXnXHDaLtUfuslssaNjF6sDm8X7fVTaPvi2rGD0+b5ILYI7isklJzcksSy3St0vg ymhfLlnwga1i39z3LA2Mh1m7GDk5JARMJKbfPcIMYYtJXLi3nq2LkYtDSGApo8TGb9cYIZzn jBKnOiaxgVQJC0RLvNrSA2aLCIRK3Lm+CcwWEqiReLNpBwtIA7PAQkaJ2TO/sIAk2AQ0Jf5u vglWxCugIfF7w0Z2EJtFQFVi0cwFYHFRgQiJU2ffQtUISvyYfA+sl1PAReLY7OlA53EADdWT uH9RCyTMLCAvsXnNW+YJjAKzkHTMQqiahaRqASPzKkbR1NLkguKk9FwjveLE3OLSvHS95Pzc TYyQIP66g3HpMatDjAIcjEo8vA4vf4QKsSaWFVfmHmKU4GBWEuF9ZPUzVIg3JbGyKrUoP76o NCe1+BCjNAeLkjjvzF3vQ4QE0hNLUrNTUwtSi2CyTBycUg2M58uu386bVntjs7y0pGbtzSlh AfOVn6ZXyQpfXdBae0xyj3hPvX/xvh9tj4+7TN9QlMFSVqHAu0Mk2nehwbG988RlZq0uPyFl b7srwjfnTtZD5kmze/eWbz5S1SOneeYHS+RUIbVdwsxnVXn273VS9N15+tVhnvxPh74bPtdw +H6NW6/r8faVSizFGYmGWsxFxYkA7lX6/l4CAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ping. Regards Andrzej On 08/07/2015 09:59 AM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda > --- > fs/dlm/lowcomms.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c > index 754fd6c..b31b32a 100644 > --- a/fs/dlm/lowcomms.c > +++ b/fs/dlm/lowcomms.c > @@ -1317,10 +1317,9 @@ static void init_local(void) > if (dlm_our_addr(&sas, i)) > break; > > - addr = kmalloc(sizeof(*addr), GFP_NOFS); > + addr = kmemdup(&sas, sizeof(*addr), GFP_NOFS); > if (!addr) > break; > - memcpy(addr, &sas, sizeof(*addr)); > dlm_local_addr[dlm_local_count++] = addr; > } > } From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrzej Hajda Date: Wed, 16 Sep 2015 12:03:50 +0200 Subject: [Cluster-devel] [PATCH 21/31] fs/dlm: use kmemdup rather than duplicating its implementation In-Reply-To: <1438934377-4922-22-git-send-email-a.hajda@samsung.com> References: <1438934377-4922-1-git-send-email-a.hajda@samsung.com> <1438934377-4922-22-git-send-email-a.hajda@samsung.com> Message-ID: <55F93E86.70906@samsung.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Ping. Regards Andrzej On 08/07/2015 09:59 AM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda > --- > fs/dlm/lowcomms.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c > index 754fd6c..b31b32a 100644 > --- a/fs/dlm/lowcomms.c > +++ b/fs/dlm/lowcomms.c > @@ -1317,10 +1317,9 @@ static void init_local(void) > if (dlm_our_addr(&sas, i)) > break; > > - addr = kmalloc(sizeof(*addr), GFP_NOFS); > + addr = kmemdup(&sas, sizeof(*addr), GFP_NOFS); > if (!addr) > break; > - memcpy(addr, &sas, sizeof(*addr)); > dlm_local_addr[dlm_local_count++] = addr; > } > }