From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753959AbbIPKE1 (ORCPT ); Wed, 16 Sep 2015 06:04:27 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:25588 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753481AbbIPKEY (ORCPT ); Wed, 16 Sep 2015 06:04:24 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-77-55f93ea66f56 Subject: Re: [PATCH 22/31] fs/ntfs: use kmemdup rather than duplicating its implementation To: Anton Altaparmakov References: <1438934377-4922-1-git-send-email-a.hajda@samsung.com> <1438934377-4922-23-git-send-email-a.hajda@samsung.com> Cc: Bartlomiej Zolnierkiewicz , Marek Szyprowski , linux-kernel@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net From: Andrzej Hajda Message-id: <55F93E9A.9070708@samsung.com> Date: Wed, 16 Sep 2015 12:04:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-version: 1.0 In-reply-to: <1438934377-4922-23-git-send-email-a.hajda@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrFLMWRmVeSWpSXmKPExsVy+t/xy7rL7H6GGpxYI2axc9MWVouNM9az WlzeNYfNor1jDqPF2iN32R1YPXYv+Mzk0bdlFaPHipXvmTw+b5ILYInisklJzcksSy3St0vg yni/Oaegm6ti0b9GlgbGaRxdjJwcEgImEg17VrJB2GISF+6tB7K5OIQEljJK/Jg0nx3Cec4o 8eJsEwtIlbBAjMT5S1+AbA4OEQFNiVW/akDCQgI1EleOb2cGqWcWWMsocW7BMrB6NqCav5tv gm3gFdCS+P13PVicRUBV4tm1G2BxUYEIiVNn30LVCEr8mHwPrIZTwEXiz/4f7CC7mAX0JO5f 1AIJMwvIS2xe85Z5AqPALCQdsxCqZiGpWsDIvIpRNLU0uaA4KT3XUK84Mbe4NC9dLzk/dxMj JIS/7GBcfMzqEKMAB6MSD6/Dyx+hQqyJZcWVuYcYJTiYlUR4H1n9DBXiTUmsrEotyo8vKs1J LT7EKM3BoiTOO3fX+xAhgfTEktTs1NSC1CKYLBMHp1QDo5xVylm3dbJRP3Jnzs35cEgiaSaL SFXfWxljS9bYCvOa0ztPrF9lZ/UrehILp9EDiSuL0irUezoWLnrd9W+ZnAr7X95sNukJZTbL Xr4+nCp73OpLj0pZWYfogupjAav1j13dUvWpieG33IbVjX+uzpnimy+j9p6bO9VEJDQ5s2Kl d2zC8w+PlViKMxINtZiLihMBkK2r5V0CAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ping. Regards Andrzej On 08/07/2015 09:59 AM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda > --- > fs/ntfs/dir.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/fs/ntfs/dir.c b/fs/ntfs/dir.c > index 9e38daf..2b7fef0 100644 > --- a/fs/ntfs/dir.c > +++ b/fs/ntfs/dir.c > @@ -1172,14 +1172,13 @@ static int ntfs_readdir(struct file *file, struct dir_context *actor) > * map the mft record without deadlocking. > */ > rc = le32_to_cpu(ctx->attr->data.resident.value_length); > - ir = kmalloc(rc, GFP_NOFS); > + /* Copy the index root value (it has been verified in read_inode). */ > + ir = kmemdup((u8 *)ctx->attr + le16_to_cpu(ctx->attr->data.resident.value_offset), > + rc, GFP_NOFS); > if (unlikely(!ir)) { > err = -ENOMEM; > goto err_out; > } > - /* Copy the index root value (it has been verified in read_inode). */ > - memcpy(ir, (u8*)ctx->attr + > - le16_to_cpu(ctx->attr->data.resident.value_offset), rc); > ntfs_attr_put_search_ctx(ctx); > unmap_mft_record(ndir); > ctx = NULL;