From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753024AbbIPQVp (ORCPT ); Wed, 16 Sep 2015 12:21:45 -0400 Received: from pegasos-out.vodafone.de ([80.84.1.38]:39502 "EHLO pegasos-out.vodafone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752377AbbIPQVn (ORCPT ); Wed, 16 Sep 2015 12:21:43 -0400 X-Spam-Flag: NO X-Spam-Score: -0.054 Authentication-Results: rohrpostix2.prod.vfnet.de (amavisd-new); dkim=pass header.i=@vodafone.de X-DKIM: OpenDKIM Filter v2.6.8 pegasos-out.vodafone.de B12AC1F6CD7 Subject: Re: [PATCH 12/31] drm/amdgpu: use kmemdup rather than duplicating its implementation To: Andrzej Hajda , Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , David Airlie References: <1438934377-4922-1-git-send-email-a.hajda@samsung.com> <1438934377-4922-13-git-send-email-a.hajda@samsung.com> <55F93CDB.70505@samsung.com> Cc: Marek Szyprowski , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Bartlomiej Zolnierkiewicz From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <55F9970E.7090201@vodafone.de> Date: Wed, 16 Sep 2015 18:21:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <55F93CDB.70505@samsung.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16.09.2015 11:56, Andrzej Hajda wrote: > Ping. > > Regards > Andrzej > > On 08/07/2015 09:59 AM, Andrzej Hajda wrote: >> The patch was generated using fixed coccinelle semantic patch >> scripts/coccinelle/api/memdup.cocci [1]. >> >> [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 >> >> Signed-off-by: Andrzej Hajda Somehow missed that. Patch is Reviewed-by: Christian König . Regards, Christian. >> --- >> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c >> index 8da6424..94bd992 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c >> @@ -549,12 +549,10 @@ int amdgpu_bo_set_metadata (struct amdgpu_bo *bo, void *metadata, >> if (metadata == NULL) >> return -EINVAL; >> >> - buffer = kzalloc(metadata_size, GFP_KERNEL); >> + buffer = kmemdup(metadata, metadata_size, GFP_KERNEL); >> if (buffer == NULL) >> return -ENOMEM; >> >> - memcpy(buffer, metadata, metadata_size); >> - >> kfree(bo->metadata); >> bo->metadata_flags = flags; >> bo->metadata = buffer; > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 12/31] drm/amdgpu: use kmemdup rather than duplicating its implementation Date: Wed, 16 Sep 2015 18:21:34 +0200 Message-ID: <55F9970E.7090201@vodafone.de> References: <1438934377-4922-1-git-send-email-a.hajda@samsung.com> <1438934377-4922-13-git-send-email-a.hajda@samsung.com> <55F93CDB.70505@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from pegasos-out.vodafone.de (pegasos-out.vodafone.de [80.84.1.38]) by gabe.freedesktop.org (Postfix) with ESMTP id 55CD06E48D for ; Wed, 16 Sep 2015 09:21:46 -0700 (PDT) In-Reply-To: <55F93CDB.70505@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Andrzej Hajda , Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , David Airlie Cc: Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Marek Szyprowski List-Id: dri-devel@lists.freedesktop.org T24gMTYuMDkuMjAxNSAxMTo1NiwgQW5kcnplaiBIYWpkYSB3cm90ZToKPiBQaW5nLgo+Cj4gUmVn YXJkcwo+IEFuZHJ6ZWoKPgo+IE9uIDA4LzA3LzIwMTUgMDk6NTkgQU0sIEFuZHJ6ZWogSGFqZGEg d3JvdGU6Cj4+IFRoZSBwYXRjaCB3YXMgZ2VuZXJhdGVkIHVzaW5nIGZpeGVkIGNvY2NpbmVsbGUg c2VtYW50aWMgcGF0Y2gKPj4gc2NyaXB0cy9jb2NjaW5lbGxlL2FwaS9tZW1kdXAuY29jY2kgWzFd Lgo+Pgo+PiBbMV06IGh0dHA6Ly9wZXJtYWxpbmsuZ21hbmUub3JnL2dtYW5lLmxpbnV4Lmtlcm5l bC8yMDE0MzIwCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IEFuZHJ6ZWogSGFqZGEgPGEuaGFqZGFAc2Ft c3VuZy5jb20+CgpTb21laG93IG1pc3NlZCB0aGF0LiBQYXRjaCBpcyBSZXZpZXdlZC1ieTogQ2hy aXN0aWFuIEvDtm5pZyAKPGNocmlzdGlhbi5rb2VuaWdAYW1kLmNvbT4uCgpSZWdhcmRzLApDaHJp c3RpYW4uCgo+PiAtLS0KPj4gICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfb2Jq ZWN0LmMgfCA0ICstLS0KPj4gICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDMgZGVs ZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9h bWRncHVfb2JqZWN0LmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfb2JqZWN0 LmMKPj4gaW5kZXggOGRhNjQyNC4uOTRiZDk5MiAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2FtZC9hbWRncHUvYW1kZ3B1X29iamVjdC5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9h bWQvYW1kZ3B1L2FtZGdwdV9vYmplY3QuYwo+PiBAQCAtNTQ5LDEyICs1NDksMTAgQEAgaW50IGFt ZGdwdV9ib19zZXRfbWV0YWRhdGEgKHN0cnVjdCBhbWRncHVfYm8gKmJvLCB2b2lkICptZXRhZGF0 YSwKPj4gICAJaWYgKG1ldGFkYXRhID09IE5VTEwpCj4+ICAgCQlyZXR1cm4gLUVJTlZBTDsKPj4g ICAKPj4gLQlidWZmZXIgPSBremFsbG9jKG1ldGFkYXRhX3NpemUsIEdGUF9LRVJORUwpOwo+PiAr CWJ1ZmZlciA9IGttZW1kdXAobWV0YWRhdGEsIG1ldGFkYXRhX3NpemUsIEdGUF9LRVJORUwpOwo+ PiAgIAlpZiAoYnVmZmVyID09IE5VTEwpCj4+ICAgCQlyZXR1cm4gLUVOT01FTTsKPj4gICAKPj4g LQltZW1jcHkoYnVmZmVyLCBtZXRhZGF0YSwgbWV0YWRhdGFfc2l6ZSk7Cj4+IC0KPj4gICAJa2Zy ZWUoYm8tPm1ldGFkYXRhKTsKPj4gICAJYm8tPm1ldGFkYXRhX2ZsYWdzID0gZmxhZ3M7Cj4+ICAg CWJvLT5tZXRhZGF0YSA9IGJ1ZmZlcjsKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2RyaS1kZXZlbAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9k cmktZGV2ZWwK