From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753240AbbIQBTU (ORCPT ); Wed, 16 Sep 2015 21:19:20 -0400 Received: from mail1.windriver.com ([147.11.146.13]:37028 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752935AbbIQBTS (ORCPT ); Wed, 16 Sep 2015 21:19:18 -0400 Subject: Re: [PATCH 27/31] net/tipc: use kmemdup rather than duplicating its implementation To: Andrzej Hajda , Jon Maloy References: <1438934377-4922-1-git-send-email-a.hajda@samsung.com> <1438934377-4922-28-git-send-email-a.hajda@samsung.com> CC: Bartlomiej Zolnierkiewicz , Marek Szyprowski , , "David S. Miller" , From: Ying Xue Message-ID: <55FA1509.7090008@windriver.com> Date: Thu, 17 Sep 2015 09:19:05 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1438934377-4922-28-git-send-email-a.hajda@samsung.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [128.224.163.180] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/07/2015 03:59 PM, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda Reviewed-by: Ying Xue > --- > net/tipc/server.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/net/tipc/server.c b/net/tipc/server.c > index 922e04a..c187cad 100644 > --- a/net/tipc/server.c > +++ b/net/tipc/server.c > @@ -411,13 +411,12 @@ static struct outqueue_entry *tipc_alloc_entry(void *data, int len) > if (!entry) > return NULL; > > - buf = kmalloc(len, GFP_ATOMIC); > + buf = kmemdup(data, len, GFP_ATOMIC); > if (!buf) { > kfree(entry); > return NULL; > } > > - memcpy(buf, data, len); > entry->iov.iov_base = buf; > entry->iov.iov_len = len; > >