From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751906AbbIQLSM (ORCPT ); Thu, 17 Sep 2015 07:18:12 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:20375 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751816AbbIQLSK (ORCPT ); Thu, 17 Sep 2015 07:18:10 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-cf-55faa16f8fc6 Subject: Re: [PATCH] usb: gadget: uvc: fix returnvar.cocci warnings To: Julia Lawall References: <201509170828.xv0cYNA5%fengguang.wu@intel.com> <20150917000130.GA25134@lkp-ib04> Cc: kbuild-all@01.org, Felipe Balbi , Laurent Pinchart , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org From: Andrzej Pietrasiewicz Message-id: <55FAA16C.5070601@samsung.com> Date: Thu, 17 Sep 2015 13:18:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-version: 1.0 In-reply-to: Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrPLMWRmVeSWpSXmKPExsVy+t/xK7r5C3+FGqxuYLM4eL/eonnxejaL ZQ9OM1ocuz6R2aJz4hJ2i8u75rBZLFrWyuzA7nF/L7vH7I6ZrB77565h99i7Jcvj+I3tTB6f N8kFsEVx2aSk5mSWpRbp2yVwZXza94Sx4JBAxckD+1gbGM/wdjFyckgImEg87WxihbDFJC7c W8/WxcjFISSwlFFi9vITLBDOC0aJowv3sIBUCQs4S6zqXQ/UwcEhIqAu0fshF6Kmm1Fi3tF/ 7CAOs8ANRonm02vYQRrYBIwl9h7sYASxeQW0JPYt+cAGYrMIqEpsa1gDZosKREicOvuWDaJG UOLH5HtgyzgFLCV2XzkFZjML2EoseL8OypaX2LzmLfMERoFZSFpmISmbhaRsASPzKkbR1NLk guKk9FxDveLE3OLSvHS95PzcTYyQYP+yg3HxMatDjAIcjEo8vAouv0KFWBPLiitzDzFKcDAr ifCqLwAK8aYkVlalFuXHF5XmpBYfYpTmYFES5527632IkEB6YklqdmpqQWoRTJaJg1OqgTGt YL2Owa3MbVOqF08v5FBf+Lx5sqdqSbahhiSDe4yQ3/77D/Zq3b0SWTF3UVOksvahj0ueceU/ 3Bf3d/oXU7bHTe7B+zaX1j8XfR+p6MOrF3Vr1sugiLslS9pe1yX7eoS6/OR8ZJn9T+Ov6rRX i+Rz921qKVonFPpyP/MM70uqSvy25c+d+pVYijMSDbWYi4oTAaS0L1dyAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Julia, W dniu 17.09.2015 o 10:57, Julia Lawall pisze: > Coccinelle suggests the following patch. But the code is curious. Is the > function expected to always return a failure value? > Thank you for catching this. The function is not expected to always return a failure value. Fortunately it does not matter anyway because the return value of the drop_link() operation is silently ignored by its caller in fs/configfs/symlink.c, functions configfs_symlink() and configfs_unlink(). For my comments see inline. > thanks, > julia > > On Thu, 17 Sep 2015, kbuild test robot wrote: > >> TO: Andrzej Pietrasiewicz >> CC: kbuild-all@01.org >> CC: Felipe Balbi >> CC: Laurent Pinchart >> CC: "Greg Kroah-Hartman" >> CC: linux-usb@vger.kernel.org >> CC: linux-kernel@vger.kernel.org >> >> drivers/usb/gadget/function/uvc_configfs.c:866:5-8: Unneeded variable: "ret". Return "- EINVAL" on line 891 >> >> >> Remove unneeded variable used to store return value. >> >> Generated by: scripts/coccinelle/misc/returnvar.cocci >> >> CC: Andrzej Pietrasiewicz >> Signed-off-by: Fengguang Wu >> --- >> >> Please take the patch only if it's a positive warning. Thanks! >> >> uvc_configfs.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> --- a/drivers/usb/gadget/function/uvc_configfs.c >> +++ b/drivers/usb/gadget/function/uvc_configfs.c >> @@ -863,7 +863,6 @@ static int uvcg_streaming_header_drop_li >> struct uvcg_streaming_header *src_hdr; >> struct uvcg_format *target_fmt = NULL; >> struct uvcg_format_ptr *format_ptr, *tmp; >> - int ret = -EINVAL; >> >> src_hdr = to_uvcg_streaming_header(src); >> mutex_lock(su_mutex); /* for navigating configfs hierarchy */ >> @@ -888,7 +887,7 @@ static int uvcg_streaming_header_drop_li >> out: >> mutex_unlock(&opts->lock); >> mutex_unlock(su_mutex); >> - return ret; >> + return -EINVAL; return 0; Thanks, AP