From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751605AbbIUGTh (ORCPT ); Mon, 21 Sep 2015 02:19:37 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:51530 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750719AbbIUGTg (ORCPT ); Mon, 21 Sep 2015 02:19:36 -0400 Subject: Re: [PATCH RFC 6/7] ASoC: tlv320aic26: Add support for DSP_B data format To: "Cormier, Jonathan" , Liam Girdwood References: <1442607076-26681-1-git-send-email-jcormier@criticallink.com> <1442607076-26681-7-git-send-email-jcormier@criticallink.com> CC: Bob Duke , Mike Williamson , Mark Brown , Jaroslav Kysela , Takashi Iwai , Jyri Sarha , Misael Lopez Cruz , , , Greg Gluszek From: Peter Ujfalusi Message-ID: <55FFA16B.8060105@ti.com> Date: Mon, 21 Sep 2015 09:19:23 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1442607076-26681-7-git-send-email-jcormier@criticallink.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/18/2015 11:11 PM, Cormier, Jonathan wrote: > Signed-off-by: Cormier, Jonathan > --- > sound/soc/codecs/tlv320aic26.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/soc/codecs/tlv320aic26.c b/sound/soc/codecs/tlv320aic26.c > index c3b0a698ea66..5c5641cd28de 100644 > --- a/sound/soc/codecs/tlv320aic26.c > +++ b/sound/soc/codecs/tlv320aic26.c > @@ -211,6 +211,7 @@ static int aic26_set_fmt(struct snd_soc_dai *codec_dai, unsigned int fmt) > switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) { > case SND_SOC_DAIFMT_I2S: aic26->datfm = AIC26_DATFM_I2S; break; > case SND_SOC_DAIFMT_DSP_A: aic26->datfm = AIC26_DATFM_DSP; break; > + case SND_SOC_DAIFMT_DSP_B: aic26->datfm = AIC26_DATFM_DSP; break; Are you sure about this? According to the datasheet: www.ti.com/litv/slas412 page 18 there is no bit to change the data delay and the format the codec supports is DSP_A. > case SND_SOC_DAIFMT_RIGHT_J: aic26->datfm = AIC26_DATFM_RIGHTJ; break; > case SND_SOC_DAIFMT_LEFT_J: aic26->datfm = AIC26_DATFM_LEFTJ; break; > default: > -- Péter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Ujfalusi Subject: Re: [PATCH RFC 6/7] ASoC: tlv320aic26: Add support for DSP_B data format Date: Mon, 21 Sep 2015 09:19:23 +0300 Message-ID: <55FFA16B.8060105@ti.com> References: <1442607076-26681-1-git-send-email-jcormier@criticallink.com> <1442607076-26681-7-git-send-email-jcormier@criticallink.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1442607076-26681-7-git-send-email-jcormier@criticallink.com> Sender: linux-kernel-owner@vger.kernel.org To: "Cormier, Jonathan" , Liam Girdwood Cc: Bob Duke , Mike Williamson , Mark Brown , Jaroslav Kysela , Takashi Iwai , Jyri Sarha , Misael Lopez Cruz , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Greg Gluszek List-Id: alsa-devel@alsa-project.org On 09/18/2015 11:11 PM, Cormier, Jonathan wrote: > Signed-off-by: Cormier, Jonathan > --- > sound/soc/codecs/tlv320aic26.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/sound/soc/codecs/tlv320aic26.c b/sound/soc/codecs/tlv320= aic26.c > index c3b0a698ea66..5c5641cd28de 100644 > --- a/sound/soc/codecs/tlv320aic26.c > +++ b/sound/soc/codecs/tlv320aic26.c > @@ -211,6 +211,7 @@ static int aic26_set_fmt(struct snd_soc_dai *code= c_dai, unsigned int fmt) > switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) { > case SND_SOC_DAIFMT_I2S: aic26->datfm =3D AIC26_DATFM_I2S; brea= k; > case SND_SOC_DAIFMT_DSP_A: aic26->datfm =3D AIC26_DATFM_DSP; brea= k; > + case SND_SOC_DAIFMT_DSP_B: aic26->datfm =3D AIC26_DATFM_DSP; brea= k; Are you sure about this? According to the datasheet: www.ti.com/litv/slas412 page 18 there is no bit to change the data dela= y and the format the codec supports is DSP_A. > case SND_SOC_DAIFMT_RIGHT_J: aic26->datfm =3D AIC26_DATFM_RIGHTJ; b= reak; > case SND_SOC_DAIFMT_LEFT_J: aic26->datfm =3D AIC26_DATFM_LEFTJ; br= eak; > default: >=20 --=20 P=E9ter