All of lore.kernel.org
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javierm@redhat.com>
To: Leif Lindholm <leif.lindholm@linaro.org>,
	The development of GNU GRUB <grub-devel@gnu.org>
Cc: Mark Salter <msalter@redhat.com>, Daniel Kiper <daniel.kiper@oracle.com>
Subject: Re: [PATCH] arm64: make sure fdt has #address-cells and #size-cells properties
Date: Thu, 7 Nov 2019 18:39:26 +0100	[thread overview]
Message-ID: <55ab3ab9-557c-4ae9-6417-54b3973e04c8@redhat.com> (raw)
In-Reply-To: <20191107164035.GR16820@bivouac.eciton.net>

Hello Leif,

On 11/7/19 5:40 PM, Leif Lindholm wrote:
> On Thu, Oct 31, 2019 at 11:37:40AM +0100, Javier Martinez Canillas wrote:
>> From: Mark Salter <msalter@redhat.com>
>>
>> Recent upstream changes to kexec-tools relies on #address-cells
>> and #size-cells properties in the FDT. If grub2 needs to create
>> a chosen node, it is likely because firmware did not provide one.
>> In that case, set #address-cells and #size-cells properties to
>> make sure they exist.
> 
> I assumed we fixed that in 347210a5d5ce
> ("efi/fdt: Set address/size cells to 2 for empty tree")?
> 

That indeed seems to be the case. I missed that was already fixed when
rebasing Mark's patch because the fix was a different one.

So it's another patch that can be dropped from our package, thanks a
lot for pointing it out.

Best regards,
-- 
Javier Martinez Canillas
Software Engineer - Desktop Hardware Enablement
Red Hat


      reply	other threads:[~2019-11-07 17:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-31 10:37 [PATCH] arm64: make sure fdt has #address-cells and #size-cells properties Javier Martinez Canillas
2019-10-31 11:56 ` Vladimir 'phcoder' Serbinenko
2019-10-31 15:59   ` Javier Martinez Canillas
2019-10-31 17:24     ` Mark Salter
2019-11-05 14:47       ` Daniel Kiper
2019-11-07 16:40 ` Leif Lindholm
2019-11-07 17:39   ` Javier Martinez Canillas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55ab3ab9-557c-4ae9-6417-54b3973e04c8@redhat.com \
    --to=javierm@redhat.com \
    --cc=daniel.kiper@oracle.com \
    --cc=grub-devel@gnu.org \
    --cc=leif.lindholm@linaro.org \
    --cc=msalter@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.