All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ed Avis <eda@waniasset.com>
To: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: git-log diff formatting options: some turn on diffs, some don't
Date: Fri, 22 Nov 2019 11:42:58 +0000	[thread overview]
Message-ID: <55ab4d09c51446c6b23abbb1c92441d6@WCL-EX13MBX-DR.wcl.local> (raw)

If you run git log -c this implies the -p flag.  But git log -r does not imply -p, even though both -r and -c are flags which exist to 'control the formatting of diff output' according to the documentation.

I think that all the flags listed in that section should implicitly turn on -p if it wasn't given.  (I'd also be content if they died with an error when -p wasn't given, but that could break existing users.)  The current behaviour is inconsistent and a bit of a headscratcher when 'git log -r' produces the same output as plain 'git log'.


To learn how we protect privacy, please use this link (https://www.qma.com/gdpr.html) to read our Privacy Notice.

This email and any files transmitted with it are CONFIDENTIAL and are intended solely for the use of the individual(s) or entity to whom they are addressed. Any unauthorised copying, disclosure or distribution of the material within this email is strictly forbidden. Any views or opinions presented within this email are solely those of the author and do not necessarily represent those of QMA Wadhwani (QMAW) unless otherwise specifically stated. An electronic message is not binding on its sender. Any message referring to a binding agreement must be confirmed in writing and duly signed. If you have received this email in error, please notify the sender immediately and delete the original. Telephone, electronic and other communications and conversations with QMAW and/or its associated persons may be recorded and retained.

Please note that your personal information may be stored and processed in any country where we have facilities or in which we engage service providers. If you provide personal information to us by email or otherwise, you consent to the transfer of that information to countries outside of your country of residence and these countries may have different data protection rules than your country.


             reply	other threads:[~2019-11-22 11:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-22 11:42 Ed Avis [this message]
2019-11-23  2:15 ` git-log diff formatting options: some turn on diffs, some don't Junio C Hamano
2019-11-25 10:46   ` Ed Avis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55ab4d09c51446c6b23abbb1c92441d6@WCL-EX13MBX-DR.wcl.local \
    --to=eda@waniasset.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.