All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Lendacky <thomas.lendacky@amd.com>
To: Peter Gonda <pgonda@google.com>,
	dionnaglaze@google.com, linux-kernel@vger.kernel.org,
	x86@kernel.org
Cc: jroedel@suse.de, luto@kernel.org, mingo@redhat.com, pbonzini@redhat.com
Subject: Re: [PATCH v5 1/4] ccp: Name -1 return value as SEV_RET_NO_FW_CALL
Date: Wed, 2 Nov 2022 12:30:17 -0500	[thread overview]
Message-ID: <55c2794b-a8fc-790d-1529-424ae804185e@amd.com> (raw)
In-Reply-To: <20221102151836.1310509-2-dionnaglaze@google.com>

On 11/2/22 10:43, Peter Gonda wrote:
> From: Dionna Glaze <dionnaglaze@google.com>
> 
> The PSP can return a "firmware error" code of -1 in circumstances where
> the PSP is not actually called. To make this protocol unambiguous, we
> add a constant naming the return value.
> 
> From: Peter Gonda <pgonda@google.com>
> Cc: Thomas Lendacky <Thomas.Lendacky@amd.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Joerg Roedel <jroedel@suse.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Andy Lutomirsky <luto@kernel.org>
> 
> Signed-off-by: Dionna Glaze <dionnaglaze@google.com>
> 
> I think you can modify the author of this commit to be 'Peter Gonda
> <pgonda@google.com>' then include my Signed-off-by.
> 

Since you have to resend for the proper Signed-off-by: chain, the subject 
line should really be: crypto: ccp - Name -1 ...

and you missed copying the other CCP driver maintainer.

It's always good to do a git log on the file(s) you're updating to get an 
idea of the appropriate prefix to use.

Thanks,
Tom

> 

  reply	other threads:[~2022-11-02 17:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-02 15:18 [PATCH v5 0/4] Add throttling detection to sev-guest Dionna Glaze
2022-11-02 15:18 ` [PATCH v5 1/4] ccp: Name -1 return value as SEV_RET_NO_FW_CALL Dionna Glaze
2022-11-02 17:30   ` Tom Lendacky [this message]
2022-11-02 18:46     ` Borislav Petkov
2022-11-02 15:18 ` [PATCH v5 2/4] x86/sev: Change snp_guest_issue_request's fw_err Dionna Glaze
2022-11-02 15:18 ` [PATCH v5 3/4] virt/coco/sev-guest: Remove err in handle_guest_request Dionna Glaze
2022-11-02 15:18 ` [PATCH v5 4/4] virt/coco/sev-guest: interpret VMM errors from guest request Dionna Glaze
2022-11-03 15:26 ` [PATCH v5 0/4] Add throttling detection to sev-guest Peter Gonda
2022-11-03 19:03   ` Dionna Amalie Glaze

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55c2794b-a8fc-790d-1529-424ae804185e@amd.com \
    --to=thomas.lendacky@amd.com \
    --cc=dionnaglaze@google.com \
    --cc=jroedel@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=pgonda@google.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.