From: Quentin Schulz <foss@0leil.net>
To: Antoine Tenart <antoine.tenart@bootlin.com>
Cc: davem@davemloft.net, andrew@lunn.ch, f.fainelli@gmail.com,
hkallweit1@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/3] net: phy: mscc: add support for RGMII MAC mode
Date: Thu, 27 Feb 2020 17:09:25 +0100 [thread overview]
Message-ID: <55c4a6d121868a083b1d8ca78c65cd37@0leil.net> (raw)
In-Reply-To: <20200227152859.1687119-2-antoine.tenart@bootlin.com>
Hi Antoine,
I guess I slipped through in your Cc list but now that it's too late to
undo it, I'll give my 2¢ :)
On 2020-02-27 16:28, Antoine Tenart wrote:
> This patch adds support for connecting VSC8584 PHYs to the MAC using
> RGMII.
>
> Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
> ---
> drivers/net/phy/mscc.c | 33 +++++++++++++++++++++------------
> 1 file changed, 21 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/net/phy/mscc.c b/drivers/net/phy/mscc.c
> index d24577de0775..ecb45c43e5ed 100644
> --- a/drivers/net/phy/mscc.c
> +++ b/drivers/net/phy/mscc.c
> @@ -272,6 +272,7 @@ enum macsec_bank {
> #define MAC_CFG_MASK 0xc000
> #define MAC_CFG_SGMII 0x0000
> #define MAC_CFG_QSGMII 0x4000
> +#define MAC_CFG_RGMII 0x8000
>
> /* Test page Registers */
> #define MSCC_PHY_TEST_PAGE_5 5
> @@ -2751,27 +2752,35 @@ static int vsc8584_config_init(struct
> phy_device *phydev)
>
> val = phy_base_read(phydev, MSCC_PHY_MAC_CFG_FASTLINK);
> val &= ~MAC_CFG_MASK;
> - if (phydev->interface == PHY_INTERFACE_MODE_QSGMII)
> + if (phydev->interface == PHY_INTERFACE_MODE_QSGMII) {
> val |= MAC_CFG_QSGMII;
> - else
> + } else if (phydev->interface == PHY_INTERFACE_MODE_SGMII) {
> val |= MAC_CFG_SGMII;
> + } else if (phy_interface_mode_is_rgmii(phydev->interface)) {
Nitpick:
I don't know much the difference between that one and
phy_interface_is_rgmii wrt when one should be used and not the other,
but seeing the implementation
(https://elixir.bootlin.com/linux/latest/source/include/linux/phy.h#L999)...
we should be safe :) Since you already have a phydev in hands at that
time, maybe using phy_interface_is_rgmii would be cleaner? (shorter).
> + val |= MAC_CFG_RGMII;
> + } else {
> + ret = -EINVAL;
> + goto err;
> + }
>
> ret = phy_base_write(phydev, MSCC_PHY_MAC_CFG_FASTLINK, val);
> if (ret)
> goto err;
>
> - val = PROC_CMD_MCB_ACCESS_MAC_CONF | PROC_CMD_RST_CONF_PORT |
> - PROC_CMD_READ_MOD_WRITE_PORT;
> - if (phydev->interface == PHY_INTERFACE_MODE_QSGMII)
> - val |= PROC_CMD_QSGMII_MAC;
> - else
> - val |= PROC_CMD_SGMII_MAC;
> + if (!phy_interface_mode_is_rgmii(phydev->interface)) {
Ditto.
Thanks,
Quentin
next prev parent reply other threads:[~2020-02-27 16:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 15:28 [PATCH net-next 0/3] net: phy: mscc: add support for RGMII MAC mode Antoine Tenart
2020-02-27 15:28 ` [PATCH net-next 1/3] " Antoine Tenart
2020-02-27 16:09 ` Quentin Schulz [this message]
2020-02-27 15:28 ` [PATCH net-next 2/3] dt-bindings: net: phy: mscc: document rgmii skew properties Antoine Tenart
2020-02-27 15:28 ` [PATCH net-next 3/3] net: phy: mscc: implement RGMII skew delay configuration Antoine Tenart
2020-02-27 15:51 ` Andrew Lunn
2020-02-27 16:01 ` Antoine Tenart
2020-02-27 16:21 ` Quentin Schulz
2020-02-27 16:25 ` Andrew Lunn
2020-02-27 18:53 ` Antoine Tenart
2020-02-27 18:55 ` Antoine Tenart
2020-02-28 15:07 ` kbuild test robot
2020-02-28 16:24 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55c4a6d121868a083b1d8ca78c65cd37@0leil.net \
--to=foss@0leil.net \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@bootlin.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.